| Message ID | 20190517112422.20671-2-lhenriques@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Use numeric user and group IDs in getfacl | expand |
On Fri, May 17, 2019 at 12:49 PM Luis Henriques <lhenriques@suse.com> wrote: > > This prevents test failures if cases where, e.g., /etc/group doesn't > include the 'root' group ID. > > Cc: Filipe Manana <fdmanana@suse.com> > Signed-off-by: Luis Henriques <lhenriques@suse.com> Reviewed-by: Filipe Manana <fdmanana@suse.com> Looks good, thanks. > --- > tests/generic/319 | 4 ++-- > tests/generic/319.out | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tests/generic/319 b/tests/generic/319 > index 02973d90cbe2..504cf627537b 100755 > --- a/tests/generic/319 > +++ b/tests/generic/319 > @@ -44,10 +44,10 @@ _scratch_mount > > mkdir $SCRATCH_MNT/testdir > setfacl -d --set u::rwx,g::rwx,o::- $SCRATCH_MNT/testdir > -getfacl --absolute-names $SCRATCH_MNT/testdir | _filter_scratch > +getfacl -n --absolute-names $SCRATCH_MNT/testdir | _filter_scratch > > mkdir $SCRATCH_MNT/testdir/testsubdir > -getfacl --absolute-names $SCRATCH_MNT/testdir/testsubdir | _filter_scratch > +getfacl -n --absolute-names $SCRATCH_MNT/testdir/testsubdir | _filter_scratch > > # success, all done > status=0 > diff --git a/tests/generic/319.out b/tests/generic/319.out > index b090bfaf6a04..bf6b4bc80462 100644 > --- a/tests/generic/319.out > +++ b/tests/generic/319.out > @@ -1,7 +1,7 @@ > QA output created by 319 > # file: SCRATCH_MNT/testdir > -# owner: root > -# group: root > +# owner: 0 > +# group: 0 > user::rwx > group::r-x > other::r-x > @@ -10,8 +10,8 @@ default:group::rwx > default:other::--- > > # file: SCRATCH_MNT/testdir/testsubdir > -# owner: root > -# group: root > +# owner: 0 > +# group: 0 > user::rwx > group::rwx > other::---
diff --git a/tests/generic/319 b/tests/generic/319 index 02973d90cbe2..504cf627537b 100755 --- a/tests/generic/319 +++ b/tests/generic/319 @@ -44,10 +44,10 @@ _scratch_mount mkdir $SCRATCH_MNT/testdir setfacl -d --set u::rwx,g::rwx,o::- $SCRATCH_MNT/testdir -getfacl --absolute-names $SCRATCH_MNT/testdir | _filter_scratch +getfacl -n --absolute-names $SCRATCH_MNT/testdir | _filter_scratch mkdir $SCRATCH_MNT/testdir/testsubdir -getfacl --absolute-names $SCRATCH_MNT/testdir/testsubdir | _filter_scratch +getfacl -n --absolute-names $SCRATCH_MNT/testdir/testsubdir | _filter_scratch # success, all done status=0 diff --git a/tests/generic/319.out b/tests/generic/319.out index b090bfaf6a04..bf6b4bc80462 100644 --- a/tests/generic/319.out +++ b/tests/generic/319.out @@ -1,7 +1,7 @@ QA output created by 319 # file: SCRATCH_MNT/testdir -# owner: root -# group: root +# owner: 0 +# group: 0 user::rwx group::r-x other::r-x @@ -10,8 +10,8 @@ default:group::rwx default:other::--- # file: SCRATCH_MNT/testdir/testsubdir -# owner: root -# group: root +# owner: 0 +# group: 0 user::rwx group::rwx other::---
This prevents test failures if cases where, e.g., /etc/group doesn't include the 'root' group ID. Cc: Filipe Manana <fdmanana@suse.com> Signed-off-by: Luis Henriques <lhenriques@suse.com> --- tests/generic/319 | 4 ++-- tests/generic/319.out | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)