| Message ID | 20190519153128.17071-1-yuval.shaia@oracle.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 8ce0048f76542a1f4d68b647c5d4a4d35e7547cf |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | IB/mlx4: Delete unused func arg | expand |
> On May 19, 2019, at 8:54 PM, Yuval Shaia <yuval.shaia@oracle.com> wrote: > > The function argument virt_addr is not in use - delete it. > > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> Reviewed-by: Majd Dibbiny <majd@mellanox.com> > --- > drivers/infiniband/hw/mlx4/mr.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx4/mr.c b/drivers/infiniband/hw/mlx4/mr.c > index 355205a28544..2e132883848b 100644 > --- a/drivers/infiniband/hw/mlx4/mr.c > +++ b/drivers/infiniband/hw/mlx4/mr.c > @@ -368,8 +368,7 @@ int mlx4_ib_umem_calc_optimal_mtt_size(struct ib_umem *umem, u64 start_va, > } > > static struct ib_umem *mlx4_get_umem_mr(struct ib_udata *udata, u64 start, > - u64 length, u64 virt_addr, > - int access_flags) > + u64 length, int access_flags) > { > /* > * Force registering the memory as writable if the underlying pages > @@ -415,8 +414,7 @@ struct ib_mr *mlx4_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, > if (!mr) > return ERR_PTR(-ENOMEM); > > - mr->umem = > - mlx4_get_umem_mr(udata, start, length, virt_addr, access_flags); > + mr->umem = mlx4_get_umem_mr(udata, start, length, access_flags); > if (IS_ERR(mr->umem)) { > err = PTR_ERR(mr->umem); > goto err_free; > @@ -505,7 +503,7 @@ int mlx4_ib_rereg_user_mr(struct ib_mr *mr, int flags, > > mlx4_mr_rereg_mem_cleanup(dev->dev, &mmr->mmr); > ib_umem_release(mmr->umem); > - mmr->umem = mlx4_get_umem_mr(udata, start, length, virt_addr, > + mmr->umem = mlx4_get_umem_mr(udata, start, length, > mr_access_flags); > if (IS_ERR(mmr->umem)) { > err = PTR_ERR(mmr->umem); > -- > 2.20.1 >
On Sun, May 19, 2019 at 06:31:27PM +0300, Yuval Shaia wrote: > The function argument virt_addr is not in use - delete it. > > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > Reviewed-by: Majd Dibbiny <majd@mellanox.com> > --- > drivers/infiniband/hw/mlx4/mr.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/mlx4/mr.c b/drivers/infiniband/hw/mlx4/mr.c index 355205a28544..2e132883848b 100644 --- a/drivers/infiniband/hw/mlx4/mr.c +++ b/drivers/infiniband/hw/mlx4/mr.c @@ -368,8 +368,7 @@ int mlx4_ib_umem_calc_optimal_mtt_size(struct ib_umem *umem, u64 start_va, } static struct ib_umem *mlx4_get_umem_mr(struct ib_udata *udata, u64 start, - u64 length, u64 virt_addr, - int access_flags) + u64 length, int access_flags) { /* * Force registering the memory as writable if the underlying pages @@ -415,8 +414,7 @@ struct ib_mr *mlx4_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, if (!mr) return ERR_PTR(-ENOMEM); - mr->umem = - mlx4_get_umem_mr(udata, start, length, virt_addr, access_flags); + mr->umem = mlx4_get_umem_mr(udata, start, length, access_flags); if (IS_ERR(mr->umem)) { err = PTR_ERR(mr->umem); goto err_free; @@ -505,7 +503,7 @@ int mlx4_ib_rereg_user_mr(struct ib_mr *mr, int flags, mlx4_mr_rereg_mem_cleanup(dev->dev, &mmr->mmr); ib_umem_release(mmr->umem); - mmr->umem = mlx4_get_umem_mr(udata, start, length, virt_addr, + mmr->umem = mlx4_get_umem_mr(udata, start, length, mr_access_flags); if (IS_ERR(mmr->umem)) { err = PTR_ERR(mmr->umem);
The function argument virt_addr is not in use - delete it. Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> --- drivers/infiniband/hw/mlx4/mr.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)