| Message ID | 20190517005114.19456-1-richardw.yang@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/acpi: ACPI_PCI should depends on both ACPI and PCI | expand |
On 5/16/19 5:51 PM, Wei Yang wrote: > Pointed out by Philippe Mathieu-Daudé <philmd@redhat.com>. > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > --- > hw/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Fri, 17 May 2019 08:51:14 +0800 Wei Yang <richardw.yang@linux.intel.com> wrote: > Pointed out by Philippe Mathieu-Daudé <philmd@redhat.com>. > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > --- > hw/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig > index 7265843cc3..7c59cf900b 100644 > --- a/hw/acpi/Kconfig > +++ b/hw/acpi/Kconfig > @@ -25,7 +25,7 @@ config ACPI_NVDIMM > > config ACPI_PCI > bool > - depends on ACPI > + depends on ACPI && PCI > > config ACPI_VMGENID > bool are you sure you didn't miss anything? On Fri, 17 May 2019 10:37:42 +0200 Philippe Mathieu-Daudé <philmd@redhat.com> wrote: [...] > > config ARM_VIRT > ... > select ACPI_PCI > > config ACPI_PCI > bool > depends on ACPI && PCI >
On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote: >On Fri, 17 May 2019 08:51:14 +0800 >Wei Yang <richardw.yang@linux.intel.com> wrote: > >> Pointed out by Philippe Mathieu-Daud?? <philmd@redhat.com>. >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> >> --- >> hw/acpi/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig >> index 7265843cc3..7c59cf900b 100644 >> --- a/hw/acpi/Kconfig >> +++ b/hw/acpi/Kconfig >> @@ -25,7 +25,7 @@ config ACPI_NVDIMM >> >> config ACPI_PCI >> bool >> - depends on ACPI >> + depends on ACPI && PCI >> >> config ACPI_VMGENID >> bool > >are you sure you didn't miss anything? > This patch is based on the comment in http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913 My understanding is not correct? >On Fri, 17 May 2019 10:37:42 +0200 >Philippe Mathieu-Daud?? <philmd@redhat.com> wrote: > >[...] >> >> config ARM_VIRT >> ... >> select ACPI_PCI >> >> config ACPI_PCI >> bool >> depends on ACPI && PCI >> > >
On Fri, 17 May 2019 12:59:57 +0000 Wei Yang <richard.weiyang@gmail.com> wrote: > On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote: > >On Fri, 17 May 2019 08:51:14 +0800 > >Wei Yang <richardw.yang@linux.intel.com> wrote: > > > >> Pointed out by Philippe Mathieu-Daud?? <philmd@redhat.com>. > >> > >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > >> --- > >> hw/acpi/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig > >> index 7265843cc3..7c59cf900b 100644 > >> --- a/hw/acpi/Kconfig > >> +++ b/hw/acpi/Kconfig > >> @@ -25,7 +25,7 @@ config ACPI_NVDIMM > >> > >> config ACPI_PCI > >> bool > >> - depends on ACPI > >> + depends on ACPI && PCI > >> > >> config ACPI_VMGENID > >> bool > > > >are you sure you didn't miss anything? > > > > This patch is based on the comment in > http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913 > > My understanding is not correct? That wasn't the end of discussion, it continued on until Philippe suggested the below changes > > >On Fri, 17 May 2019 10:37:42 +0200 > >Philippe Mathieu-Daud?? <philmd@redhat.com> wrote: > > > >[...] > >> > >> config ARM_VIRT > >> ... > >> select ACPI_PCI > >> > >> config ACPI_PCI > >> bool > >> depends on ACPI && PCI > >> > > > > >
On Fri, May 17, 2019 at 04:29:03PM +0200, Igor Mammedov wrote: >On Fri, 17 May 2019 12:59:57 +0000 >Wei Yang <richard.weiyang@gmail.com> wrote: > >> On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote: >> >On Fri, 17 May 2019 08:51:14 +0800 >> >Wei Yang <richardw.yang@linux.intel.com> wrote: >> > >> >> Pointed out by Philippe Mathieu-Daud?? <philmd@redhat.com>. >> >> >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> >> >> --- >> >> hw/acpi/Kconfig | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig >> >> index 7265843cc3..7c59cf900b 100644 >> >> --- a/hw/acpi/Kconfig >> >> +++ b/hw/acpi/Kconfig >> >> @@ -25,7 +25,7 @@ config ACPI_NVDIMM >> >> >> >> config ACPI_PCI >> >> bool >> >> - depends on ACPI >> >> + depends on ACPI && PCI >> >> >> >> config ACPI_VMGENID >> >> bool >> > >> >are you sure you didn't miss anything? >> > >> >> This patch is based on the comment in >> http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913 >> >> My understanding is not correct? > >That wasn't the end of discussion, it continued on until Philippe suggested >the below changes > Yep, just see the latest reply. >> >> >On Fri, 17 May 2019 10:37:42 +0200 >> >Philippe Mathieu-Daud?? <philmd@redhat.com> wrote: >> > >> >[...] >> >> >> >> config ARM_VIRT >> >> ... >> >> select ACPI_PCI >> >> >> >> config ACPI_PCI >> >> bool >> >> depends on ACPI && PCI >> >> >> > >> > >>
diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig index 7265843cc3..7c59cf900b 100644 --- a/hw/acpi/Kconfig +++ b/hw/acpi/Kconfig @@ -25,7 +25,7 @@ config ACPI_NVDIMM config ACPI_PCI bool - depends on ACPI + depends on ACPI && PCI config ACPI_VMGENID bool
Pointed out by Philippe Mathieu-Daudé <philmd@redhat.com>. Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> --- hw/acpi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)