| Message ID | 20190520085846.22320-1-masneyb@onstation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: backlight: lm3630a: correct schema validation | expand |
On Mon, May 20, 2019 at 3:59 AM Brian Masney <masneyb@onstation.org> wrote: > > The '#address-cells' and '#size-cells' properties were not defined in > the lm3630a bindings and would cause the following error when > attempting to validate the examples against the schema: > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > '#address-cells', '#size-cells' do not match any of the regexes: > '^led@[01]$', 'pinctrl-[0-9]+' > > Correct this by adding those two properties. > > While we're here, move the ti,linear-mapping-mode property to the > led@[01] child nodes to correct the following validation error: > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > led@0: 'ti,linear-mapping-mode' does not match any of the regexes: > 'pinctrl-[0-9]+' > > Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings") > Signed-off-by: Brian Masney <masneyb@onstation.org> > Reported-by: Rob Herring <robh+dt@kernel.org> > --- > .../leds/backlight/lm3630a-backlight.yaml | 20 +++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, May 20, 2019 at 08:14:03AM -0500, Rob Herring wrote: > On Mon, May 20, 2019 at 3:59 AM Brian Masney <masneyb@onstation.org> wrote: > > > > The '#address-cells' and '#size-cells' properties were not defined in > > the lm3630a bindings and would cause the following error when > > attempting to validate the examples against the schema: > > > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > > '#address-cells', '#size-cells' do not match any of the regexes: > > '^led@[01]$', 'pinctrl-[0-9]+' > > > > Correct this by adding those two properties. > > > > While we're here, move the ti,linear-mapping-mode property to the > > led@[01] child nodes to correct the following validation error: > > > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > > led@0: 'ti,linear-mapping-mode' does not match any of the regexes: > > 'pinctrl-[0-9]+' > > > > Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings") > > Signed-off-by: Brian Masney <masneyb@onstation.org> > > Reported-by: Rob Herring <robh+dt@kernel.org> > > --- > > .../leds/backlight/lm3630a-backlight.yaml | 20 +++++++++++++------ > > 1 file changed, 14 insertions(+), 6 deletions(-) > > Reviewed-by: Rob Herring <robh@kernel.org> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
On 5/20/19 8:30 AM, Daniel Thompson wrote: > On Mon, May 20, 2019 at 08:14:03AM -0500, Rob Herring wrote: >> On Mon, May 20, 2019 at 3:59 AM Brian Masney <masneyb@onstation.org> wrote: >>> >>> The '#address-cells' and '#size-cells' properties were not defined in >>> the lm3630a bindings and would cause the following error when >>> attempting to validate the examples against the schema: >>> >>> Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: >>> '#address-cells', '#size-cells' do not match any of the regexes: >>> '^led@[01]$', 'pinctrl-[0-9]+' >>> >>> Correct this by adding those two properties. >>> >>> While we're here, move the ti,linear-mapping-mode property to the >>> led@[01] child nodes to correct the following validation error: >>> >>> Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: >>> led@0: 'ti,linear-mapping-mode' does not match any of the regexes: >>> 'pinctrl-[0-9]+' >>> >>> Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings") >>> Signed-off-by: Brian Masney <masneyb@onstation.org> >>> Reported-by: Rob Herring <robh+dt@kernel.org> >>> --- >>> .../leds/backlight/lm3630a-backlight.yaml | 20 +++++++++++++------ >>> 1 file changed, 14 insertions(+), 6 deletions(-) >> >> Reviewed-by: Rob Herring <robh@kernel.org> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > Acked-by: Dan Murphy <dmurphy@ti.com>
On Mon, 20 May 2019 04:58:46 -0400, Brian Masney wrote: > The '#address-cells' and '#size-cells' properties were not defined in > the lm3630a bindings and would cause the following error when > attempting to validate the examples against the schema: > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > '#address-cells', '#size-cells' do not match any of the regexes: > '^led@[01]$', 'pinctrl-[0-9]+' > > Correct this by adding those two properties. > > While we're here, move the ti,linear-mapping-mode property to the > led@[01] child nodes to correct the following validation error: > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > led@0: 'ti,linear-mapping-mode' does not match any of the regexes: > 'pinctrl-[0-9]+' > > Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings") > Signed-off-by: Brian Masney <masneyb@onstation.org> > Reported-by: Rob Herring <robh+dt@kernel.org> > --- > .../leds/backlight/lm3630a-backlight.yaml | 20 +++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > Applied, thanks. Rob
diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml index 4d61fe0a98a4..f0855e248ae5 100644 --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml @@ -23,16 +23,17 @@ properties: reg: maxItems: 1 - ti,linear-mapping-mode: - description: | - Enable linear mapping mode. If disabled, then it will use exponential - mapping mode in which the ramp up/down appears to have a more uniform - transition to the human eye. - type: boolean + '#address-cells': + const: 1 + + '#size-cells': + const: 0 required: - compatible - reg + - '#address-cells' + - '#size-cells' patternProperties: "^led@[01]$": @@ -73,6 +74,13 @@ patternProperties: minimum: 0 maximum: 255 + ti,linear-mapping-mode: + description: | + Enable linear mapping mode. If disabled, then it will use exponential + mapping mode in which the ramp up/down appears to have a more uniform + transition to the human eye. + type: boolean + required: - reg
The '#address-cells' and '#size-cells' properties were not defined in the lm3630a bindings and would cause the following error when attempting to validate the examples against the schema: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: '#address-cells', '#size-cells' do not match any of the regexes: '^led@[01]$', 'pinctrl-[0-9]+' Correct this by adding those two properties. While we're here, move the ti,linear-mapping-mode property to the led@[01] child nodes to correct the following validation error: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: led@0: 'ti,linear-mapping-mode' does not match any of the regexes: 'pinctrl-[0-9]+' Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings") Signed-off-by: Brian Masney <masneyb@onstation.org> Reported-by: Rob Herring <robh+dt@kernel.org> --- .../leds/backlight/lm3630a-backlight.yaml | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-)