Message ID | 155839428076.68606.9379127257564633311.stgit@magnolia (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | xfsprogs-5.1: fix various problems | expand |
On 5/20/19 6:18 PM, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > Data block sharing (a.k.a. reflink) has been stable for a while, so turn > it on by default. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> I'm cool with this. :) But I think we need a manpage update too. I also had some comment updates - I'll send a reply as a patch. -Eric
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index 8f84536e..afed46d0 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -2015,7 +2015,7 @@ _("rmapbt not supported without CRC support\n")); } cli->sb_feat.rmapbt = false; - if (cli->sb_feat.reflink) { + if (cli->sb_feat.reflink && cli_opt_set(&mopts, M_REFLINK)) { fprintf(stderr, _("reflink not supported without CRC support\n")); usage(); @@ -3900,7 +3900,7 @@ main( .finobt = true, .spinodes = true, .rmapbt = false, - .reflink = false, + .reflink = true, .parent_pointers = false, .nodalign = false, .nortalign = false,