| Message ID | 20190522133529.14164-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | c1a145a3ed9a40f3b6145feb97789e8eb49c5566 |
| Headers | show |
| Series | [v2] xhci: Use %zu for printing size_t type | expand |
On 22.5.2019 16.35, Fabio Estevam wrote: > Commit 597c56e372da ("xhci: update bounce buffer with correct sg num") > caused the following build warnings: > > drivers/usb/host/xhci-ring.c:676:19: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=] > > Use %zu for printing size_t type in order to fix the warnings. > > Fixes: 597c56e372da ("xhci: update bounce buffer with correct sg num") > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- Thanks for writing this follow-up patch Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
On Wed, May 22, 2019 at 05:08:13PM +0300, Mathias Nyman wrote: > On 22.5.2019 16.35, Fabio Estevam wrote: > > Commit 597c56e372da ("xhci: update bounce buffer with correct sg num") > > caused the following build warnings: > > > > drivers/usb/host/xhci-ring.c:676:19: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=] > > > > Use %zu for printing size_t type in order to fix the warnings. > > > > Fixes: 597c56e372da ("xhci: update bounce buffer with correct sg num") > > Reported-by: kbuild test robot <lkp@intel.com> > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > --- > > Thanks for writing this follow-up patch > > Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com> > > > Thanks, now queued up. greg k-h
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index ef7c8698772e..d04023d396d8 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -673,7 +673,7 @@ static void xhci_unmap_td_bounce_buffer(struct xhci_hcd *xhci, len = sg_pcopy_from_buffer(urb->sg, urb->num_sgs, seg->bounce_buf, seg->bounce_len, seg->bounce_offs); if (len != seg->bounce_len) - xhci_warn(xhci, "WARN Wrong bounce buffer read length: %ld != %d\n", + xhci_warn(xhci, "WARN Wrong bounce buffer read length: %zu != %d\n", len, seg->bounce_len); seg->bounce_len = 0; seg->bounce_offs = 0; @@ -3166,7 +3166,7 @@ static int xhci_align_td(struct xhci_hcd *xhci, struct urb *urb, u32 enqd_len, seg->bounce_buf, new_buff_len, enqd_len); if (len != seg->bounce_len) xhci_warn(xhci, - "WARN Wrong bounce buffer write length: %ld != %d\n", + "WARN Wrong bounce buffer write length: %zu != %d\n", len, seg->bounce_len); seg->bounce_dma = dma_map_single(dev, seg->bounce_buf, max_pkt, DMA_TO_DEVICE);
Commit 597c56e372da ("xhci: update bounce buffer with correct sg num") caused the following build warnings: drivers/usb/host/xhci-ring.c:676:19: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=] Use %zu for printing size_t type in order to fix the warnings. Fixes: 597c56e372da ("xhci: update bounce buffer with correct sg num") Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Changes since v1: - Fixed a typo when referencing the commit hci-->xhci drivers/usb/host/xhci-ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)