| Message ID | 20190515064405.3981-1-jeffrin@rajagiritech.edu.in (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 82ce6eb1dd13fd12e449b2ee2c2ec051e6f52c43 |
| Headers | show |
| Series | [v2] selftests: netfilter: missing error check when setting up veth interface | expand |
On Wed, May 15, 2019 at 12:14:04PM +0530, Jeffrin Jose T wrote: > A test for the basic NAT functionality uses ip command which > needs veth device.There is a condition where the kernel support > for veth is not compiled into the kernel and the test script > breaks.This patch contains code for reasonable error display > and correct code exit. Applied, thanks.
Thanks to all ! On Tue, May 21, 2019 at 11:41 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote: > > On Wed, May 15, 2019 at 12:14:04PM +0530, Jeffrin Jose T wrote: > > A test for the basic NAT functionality uses ip command which > > needs veth device.There is a condition where the kernel support > > for veth is not compiled into the kernel and the test script > > breaks.This patch contains code for reasonable error display > > and correct code exit. > > Applied, thanks.
diff --git a/tools/testing/selftests/netfilter/nft_nat.sh b/tools/testing/selftests/netfilter/nft_nat.sh index 8ec76681605c..f25f72a75cf3 100755 --- a/tools/testing/selftests/netfilter/nft_nat.sh +++ b/tools/testing/selftests/netfilter/nft_nat.sh @@ -23,7 +23,11 @@ ip netns add ns0 ip netns add ns1 ip netns add ns2 -ip link add veth0 netns ns0 type veth peer name eth0 netns ns1 +ip link add veth0 netns ns0 type veth peer name eth0 netns ns1 > /dev/null 2>&1 +if [ $? -ne 0 ];then + echo "SKIP: No virtual ethernet pair device support in kernel" + exit $ksft_skip +fi ip link add veth1 netns ns0 type veth peer name eth0 netns ns2 ip -net ns0 link set lo up
A test for the basic NAT functionality uses ip command which needs veth device.There is a condition where the kernel support for veth is not compiled into the kernel and the test script breaks.This patch contains code for reasonable error display and correct code exit. Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in> --- tools/testing/selftests/netfilter/nft_nat.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)