mbox series

[0/5] usb: gadget: udc: lpc32xx: add stotg04 phy support

Message ID 20190409120908.12079-1-alexandre.belloni@bootlin.com (mailing list archive)
Headers show
Series usb: gadget: udc: lpc32xx: add stotg04 phy support | expand

Message

Alexandre Belloni April 9, 2019, 12:09 p.m. UTC
Hi,

This series starts to clean up the lpc32xx udc driver and also repairs
interrupt handling so hotplugging actually works. The design I tested
that on uses an stotg04 instead of the usual isp1301 so support for that
is also added.

A bit more work is needed to get the RNDIS gadget driver to work.

Alexandre Belloni (5):
  usb: gadget: udc: lpc32xx: simplify probe
  usb: gadget: udc: lpc32xx: simplify vbus handling
  usb: gadget: udc: lpc32xx: properly setup phy interrupts
  usb: gadget: udc: lpc32xx: add support for stotg04 phy
  usb: gadget: udc: lpc32xx: rework interrupt handling

 drivers/usb/gadget/udc/lpc32xx_udc.c | 167 +++++++++++----------------
 1 file changed, 66 insertions(+), 101 deletions(-)

Comments

James Grant May 13, 2019, 11:32 a.m. UTC | #1
Tested with a board containing LPC3250 SOC and STOTG04 PHY by using 
serial gadget.

Needed patch "[PATCH] usb: gadget: udc: lpc32xx: allocate descriptor 
with GFP_ATOMIC" also.

Tested-by: James Grant <jamesg@zaltys.org>

Regards,
James Grant.

On 09/04/2019 14:09, Alexandre Belloni Wrote:
> Hi,
>
> This series starts to clean up the lpc32xx udc driver and also repairs
> interrupt handling so hotplugging actually works. The design I tested
> that on uses an stotg04 instead of the usual isp1301 so support for that
> is also added.
>
> A bit more work is needed to get the RNDIS gadget driver to work.
>
> Alexandre Belloni (5):
>    usb: gadget: udc: lpc32xx: simplify probe
>    usb: gadget: udc: lpc32xx: simplify vbus handling
>    usb: gadget: udc: lpc32xx: properly setup phy interrupts
>    usb: gadget: udc: lpc32xx: add support for stotg04 phy
>    usb: gadget: udc: lpc32xx: rework interrupt handling
>
>   drivers/usb/gadget/udc/lpc32xx_udc.c | 167 +++++++++++----------------
>   1 file changed, 66 insertions(+), 101 deletions(-)
Sylvain Lemieux May 22, 2019, 3 p.m. UTC | #2
You can add my "Acked-by" on the 5 patches.
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>

On Mon, May 13, 2019 at 7:32 AM James Grant <jamesg@zaltys.org> wrote:
>
> Tested with a board containing LPC3250 SOC and STOTG04 PHY by using
> serial gadget.
>
> Needed patch "[PATCH] usb: gadget: udc: lpc32xx: allocate descriptor
> with GFP_ATOMIC" also.
>
> Tested-by: James Grant <jamesg@zaltys.org>
>
> Regards,
> James Grant.
>
> On 09/04/2019 14:09, Alexandre Belloni Wrote:
> > Hi,
> >
> > This series starts to clean up the lpc32xx udc driver and also repairs
> > interrupt handling so hotplugging actually works. The design I tested
> > that on uses an stotg04 instead of the usual isp1301 so support for that
> > is also added.
> >
> > A bit more work is needed to get the RNDIS gadget driver to work.
> >
> > Alexandre Belloni (5):
> >    usb: gadget: udc: lpc32xx: simplify probe
> >    usb: gadget: udc: lpc32xx: simplify vbus handling
> >    usb: gadget: udc: lpc32xx: properly setup phy interrupts
> >    usb: gadget: udc: lpc32xx: add support for stotg04 phy
> >    usb: gadget: udc: lpc32xx: rework interrupt handling
> >
> >   drivers/usb/gadget/udc/lpc32xx_udc.c | 167 +++++++++++----------------
> >   1 file changed, 66 insertions(+), 101 deletions(-)