[v2,0/4] crypto: CAAM: Print debug messages at debug level

Message

Sascha Hauer May 23, 2019, 8:50 a.m. UTC

The CAAM driver has most of its debug messages inside #ifdef DEBUG and
then prints them at KERN_ERR level. Do this properly and print the
messages at DEBUG_LEVEL as they are supposed to. With this we can get
rid of a lot of ifdefs in the code.

Sascha

Changes since v1:
- Fix alignment on following lines when converting print_hex_dump to
  print_hex_dump_debug
- Add 1/4 to avoid crash when debugging is enabled

Sascha Hauer (4):
  crypto: caam: print IV only when non NULL
  crypto: caam: remove unused defines
  crypto: caam: print debug messages at debug level
  crypto: caam: print messages in caam_dump_sg at debug level

Sascha Hauer (4):
  crypto: caam: print IV only when non NULL
  crypto: caam: remove unused defines
  crypto: caam: print debug messages at debug level
  crypto: caam: print messages in caam_dump_sg at debug level

 drivers/crypto/caam/caamalg.c      | 161 ++++++++------------
 drivers/crypto/caam/caamalg_desc.c | 116 ++++++--------
 drivers/crypto/caam/caamalg_qi.c   |  56 +++----
 drivers/crypto/caam/caamalg_qi2.c  |   4 +-
 drivers/crypto/caam/caamhash.c     | 233 ++++++++++++-----------------
 drivers/crypto/caam/caamrng.c      |  22 ++-
 drivers/crypto/caam/error.c        |   8 +-
 drivers/crypto/caam/error.h        |   2 +-
 drivers/crypto/caam/key_gen.c      |  28 ++--
 drivers/crypto/caam/sg_sw_sec4.h   |   8 +-
 10 files changed, 253 insertions(+), 385 deletions(-)

Comments

Horia Geanta May 23, 2019, 10:18 a.m. UTC | #1

On 5/23/2019 11:50 AM, Sascha Hauer wrote:
> The CAAM driver has most of its debug messages inside #ifdef DEBUG and
> then prints them at KERN_ERR level. Do this properly and print the
> messages at DEBUG_LEVEL as they are supposed to. With this we can get
> rid of a lot of ifdefs in the code.
> 
Thanks Sascha!

For the series:
Reviewed-by: Horia Geantă <[e-mail]>

Horia