Message ID | 20190523204409.21068-1-jan.bobek@gmail.com (mailing list archive) |
---|---|
Headers | show |
Series | Support for i386/x86_64 with vector extensions | expand |
Jan Bobek <jan.bobek@gmail.com> writes: > This patch series adds support for i386 and x86_64 architectures to > RISU. Notably, vector registers (SSE, AVX, AVX-512) are supported for > verification of the apprentice. This is V3 of the series posted in [1] > and [2]. I've sent a patch to enable x86 in the build-all-arches tests script but otherwise I think this series looks good to merge. > > Changes is V3: > - fix a matching bug caused by misplaced index multiplication [3] > - print an error and exit when parse of the --xfeatures option fails [4] > > References: > 1. https://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg01294.html > 2. https://lists.nongnu.org/archive/html/qemu-devel/2019-05/msg04089.html > 3. https://lists.nongnu.org/archive/html/qemu-devel/2019-05/msg04922.html > 4. https://lists.nongnu.org/archive/html/qemu-devel/2019-05/msg04903.html > > Jan Bobek (10): > Makefile: undefine the arch name symbol > risu_i386: move reginfo_t and related defines to risu_reginfo_i386.h > risu_i386: move reginfo-related code to risu_reginfo_i386.c > risu_reginfo_i386: implement arch-specific reginfo interface > risu_i386: implement missing CPU-specific functions > risu_i386: remove old unused code > test_i386: change syntax from nasm to gas > configure: add i386/x86_64 architectures > risu_reginfo_i386: replace xfeature constants with symbolic names > risu_reginfo_i386: rework --xfeatures value parsing > > Richard Henderson (1): > i386: Add avx512 state to reginfo_t > > configure | 10 +- > Makefile | 5 +- > risu_reginfo_i386.h | 49 ++++++ > risu_i386.c | 142 ++-------------- > risu_reginfo_i386.c | 400 ++++++++++++++++++++++++++++++++++++++++++++ > test_i386.S | 80 +++++++++ > test_i386.s | 27 --- > 7 files changed, 556 insertions(+), 157 deletions(-) > create mode 100644 risu_reginfo_i386.h > create mode 100644 risu_reginfo_i386.c > create mode 100644 test_i386.S > delete mode 100644 test_i386.s -- Alex Bennée
On Fri, 24 May 2019 at 10:42, Alex Bennée <alex.bennee@linaro.org> wrote: > > > Jan Bobek <jan.bobek@gmail.com> writes: > > > This patch series adds support for i386 and x86_64 architectures to > > RISU. Notably, vector registers (SSE, AVX, AVX-512) are supported for > > verification of the apprentice. This is V3 of the series posted in [1] > > and [2]. > > I've sent a patch to enable x86 in the build-all-arches tests script but > otherwise I think this series looks good to merge. Alex: So should I merge this series, or does it need a respin ? thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Fri, 24 May 2019 at 10:42, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> >> Jan Bobek <jan.bobek@gmail.com> writes: >> >> > This patch series adds support for i386 and x86_64 architectures to >> > RISU. Notably, vector registers (SSE, AVX, AVX-512) are supported for >> > verification of the apprentice. This is V3 of the series posted in [1] >> > and [2]. >> >> I've sent a patch to enable x86 in the build-all-arches tests script but >> otherwise I think this series looks good to merge. > > Alex: So should I merge this series, or does it need a respin ? I think this can be merged. I assume there is more to come to actually generate the patterns but it doesn't break any of the existing stuff and has at least one test case. -- Alex Bennée
On Fri, 7 Jun 2019 at 12:58, Alex Bennée <alex.bennee@linaro.org> wrote: > > > Peter Maydell <peter.maydell@linaro.org> writes: > > > On Fri, 24 May 2019 at 10:42, Alex Bennée <alex.bennee@linaro.org> wrote: > >> > >> > >> Jan Bobek <jan.bobek@gmail.com> writes: > >> > >> > This patch series adds support for i386 and x86_64 architectures to > >> > RISU. Notably, vector registers (SSE, AVX, AVX-512) are supported for > >> > verification of the apprentice. This is V3 of the series posted in [1] > >> > and [2]. > >> > >> I've sent a patch to enable x86 in the build-all-arches tests script but > >> otherwise I think this series looks good to merge. > > > > Alex: So should I merge this series, or does it need a respin ? > > I think this can be merged. I assume there is more to come to actually > generate the patterns but it doesn't break any of the existing stuff and > has at least one test case. Thanks; pushed this series and your patch to add it to the build-all-archs script to risu master. -- PMM