| Message ID | 20190524032950.2398-1-rodrigorsdc@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: adis16240: add of_match_table entry | expand |
On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro <rodrigorsdc@gmail.com> wrote: > > This patch adds of_match_table entry in device driver in order to > enable spi fallback probing. > > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com> > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > --- > drivers/staging/iio/accel/adis16240.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c > index 8c6d23604eca..b80c8529784b 100644 > --- a/drivers/staging/iio/accel/adis16240.c > +++ b/drivers/staging/iio/accel/adis16240.c > @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match); > static struct spi_driver adis16240_driver = { > .driver = { > .name = "adis16240", > + .of_match_table = adis16240_of_match, This patch is missing the actual table. > }, > .probe = adis16240_probe, > .remove = adis16240_remove, > -- > 2.20.1 >
Hi Alexandru, On 05/24, Alexandru Ardelean wrote: > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro <rodrigorsdc@gmail.com> wrote: > > > > This patch adds of_match_table entry in device driver in order to > > enable spi fallback probing. > > > > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com> > > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > > --- > > drivers/staging/iio/accel/adis16240.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c > > index 8c6d23604eca..b80c8529784b 100644 > > --- a/drivers/staging/iio/accel/adis16240.c > > +++ b/drivers/staging/iio/accel/adis16240.c > > @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match); > > static struct spi_driver adis16240_driver = { > > .driver = { > > .name = "adis16240", > > + .of_match_table = adis16240_of_match, > > This patch is missing the actual table. Struct with compatible devices table was included separately in a previous patch at commit d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb. Yeah, I also thought it was missing the match table the first time I was this patch. It's really confusing when we have two patches, one depending on another, that are not part of the same patch set. We're trying to avoid things like this the most but that slipped out from our internal review. We're sorry about that. > > > }, > > .probe = adis16240_probe, > > .remove = adis16240_remove, > > -- > > 2.20.1 > >
On Fri, 2019-05-24 at 10:50 -0300, Marcelo Schmitt wrote: > [External] > > > Hi Alexandru, > > On 05/24, Alexandru Ardelean wrote: > > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro <rodrigorsdc@gmail.com> wrote: > > > > > > This patch adds of_match_table entry in device driver in order to > > > enable spi fallback probing. > > > > > > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com> > > > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > > > --- > > > drivers/staging/iio/accel/adis16240.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c > > > index 8c6d23604eca..b80c8529784b 100644 > > > --- a/drivers/staging/iio/accel/adis16240.c > > > +++ b/drivers/staging/iio/accel/adis16240.c > > > @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match); > > > static struct spi_driver adis16240_driver = { > > > .driver = { > > > .name = "adis16240", > > > + .of_match_table = adis16240_of_match, > > > > This patch is missing the actual table. > > Struct with compatible devices table was included separately in a > previous patch at commit d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb. > Yeah, I also thought it was missing the match table the first time I was > this patch. It's really confusing when we have two patches, one > depending on another, that are not part of the same patch set. We're > trying to avoid things like this the most but that slipped out from our > internal review. We're sorry about that. No worries. It happens to me too. Thanks Alex > > > > > > }, > > > .probe = adis16240_probe, > > > .remove = adis16240_remove, > > > -- > > > 2.20.1 > > >
On Fri, 24 May 2019 13:54:49 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Fri, 2019-05-24 at 10:50 -0300, Marcelo Schmitt wrote: > > [External] > > > > > > Hi Alexandru, > > > > On 05/24, Alexandru Ardelean wrote: > > > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro <rodrigorsdc@gmail.com> wrote: > > > > > > > > This patch adds of_match_table entry in device driver in order to > > > > enable spi fallback probing. > > > > > > > > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com> > > > > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > > > > --- > > > > drivers/staging/iio/accel/adis16240.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c > > > > index 8c6d23604eca..b80c8529784b 100644 > > > > --- a/drivers/staging/iio/accel/adis16240.c > > > > +++ b/drivers/staging/iio/accel/adis16240.c > > > > @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match); > > > > static struct spi_driver adis16240_driver = { > > > > .driver = { > > > > .name = "adis16240", > > > > + .of_match_table = adis16240_of_match, > > > > > > This patch is missing the actual table. > > > > Struct with compatible devices table was included separately in a > > previous patch at commit d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb. > > Yeah, I also thought it was missing the match table the first time I was > > this patch. It's really confusing when we have two patches, one > > depending on another, that are not part of the same patch set. We're > > trying to avoid things like this the most but that slipped out from our > > internal review. We're sorry about that. > > No worries. > > It happens to me too. > > Thanks > Alex Oops. I should have caught that one in review as well. Oh well, these things happen. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. I rebased the tree to pick up on all the other stuff in staging/staging-next after the mere window. Thanks, Jonathan > > > > > > > > > > }, > > > > .probe = adis16240_probe, > > > > .remove = adis16240_remove, > > > > -- > > > > 2.20.1 > > > >
diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c index 8c6d23604eca..b80c8529784b 100644 --- a/drivers/staging/iio/accel/adis16240.c +++ b/drivers/staging/iio/accel/adis16240.c @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match); static struct spi_driver adis16240_driver = { .driver = { .name = "adis16240", + .of_match_table = adis16240_of_match, }, .probe = adis16240_probe, .remove = adis16240_remove,