| Message ID | 20190408125406.16703-1-ismael.luceno@silicon-gears.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] git-gui: Handle Ctrl + BS/Del in the commit msg | expand |
On 08/Apr/2019 12:54, Ismael Luceno Cortes wrote: > - Control+BackSpace: Delete word to the left of the cursor. > - Control+Delete : Delete word to the right of the cursor. > > Originally introduced by BRIEF and Turbo Vision between 1985 and 1992, > they were adopted by most CUA-Compliant UIs, including those of: OS/2, > Windows, Mac OS, Qt, GTK, Open/Libre Office, Gecko, and GNU Emacs. > > In both cases Tk already implements the functionality bound to other key > combination, so we use that. <...> Ping.
Hi, On Mon, 6 May 2019, Ismael Luceno wrote: > On 08/Apr/2019 12:54, Ismael Luceno Cortes wrote: > > - Control+BackSpace: Delete word to the left of the cursor. > > - Control+Delete : Delete word to the right of the cursor. > > > > Originally introduced by BRIEF and Turbo Vision between 1985 and 1992, > > they were adopted by most CUA-Compliant UIs, including those of: OS/2, > > Windows, Mac OS, Qt, GTK, Open/Libre Office, Gecko, and GNU Emacs. > > > > In both cases Tk already implements the functionality bound to other key > > combination, so we use that. > <...> > > Ping. FWIW I am in favor of this patch. It is simple enough, and the commit message does a good job explaining why it is a good idea to do it. It's too bad that we do not have any active Git GUI maintainer... :-( Ciao, Johannes
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh index 6de74ce639..c4e0270626 100755 --- a/git-gui/git-gui.sh +++ b/git-gui/git-gui.sh @@ -3812,6 +3812,8 @@ bind $ui_comm <$M1B-Key-KP_Subtract> {show_less_context;break} bind $ui_comm <$M1B-Key-equal> {show_more_context;break} bind $ui_comm <$M1B-Key-plus> {show_more_context;break} bind $ui_comm <$M1B-Key-KP_Add> {show_more_context;break} +bind $ui_comm <Control-Key-BackSpace> {event generate %W <Meta-Delete>;break} +bind $ui_comm <Control-Key-Delete> {event generate %W <Meta-d>;break} bind $ui_diff <$M1B-Key-x> {tk_textCopy %W;break} bind $ui_diff <$M1B-Key-X> {tk_textCopy %W;break}
- Control+BackSpace: Delete word to the left of the cursor. - Control+Delete : Delete word to the right of the cursor. Originally introduced by BRIEF and Turbo Vision between 1985 and 1992, they were adopted by most CUA-Compliant UIs, including those of: OS/2, Windows, Mac OS, Qt, GTK, Open/Libre Office, Gecko, and GNU Emacs. In both cases Tk already implements the functionality bound to other key combination, so we use that. Graphical examples: Deleting to the left: v------ pointer X_WORD____X ^-----^------ selection Deleting to the right: v--------- pointer X_WORD_X ^--^------ selection Signed-off-by: Ismael Luceno <ismael.luceno@silicon-gears.com> --- CC: Junio C Hamano <gitster@pobox.com> CC: "brian m. carlson" <sandals@crustytoothpaste.net> CC: Pat Thoyts <patthoyts@users.sourceforge.net> Notes: Changes since v2: - Reimplemented via existing events, which correctly delete spaces. - Further improved commit message. Changes since v1: - Improved commit message. git-gui/git-gui.sh | 2 ++ 1 file changed, 2 insertions(+)