| Message ID | 20190527151859.GA3217@ip-172-31-44-144.us-west-2.compute.internal (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 98a13a8d253999cf25eb16d901c35fbd2a8455c4 |
| Headers | show |
| Series | userfaultfd: selftest: fix compiler warning | expand |
On Mon, May 27, 2019 at 03:18:59PM +0000, Alakesh Haloi wrote: > Fixes following compiler warning > > userfaultfd.c: In function ‘usage’: > userfaultfd.c:126:2: warning: format not a string literal and no format > arguments [-Wformat-security] > fprintf(stderr, examples); > > Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com> Reviewed-by: Peter Xu <peterx@redhat.com>
On Mon, May 27, 2019 at 03:18:59PM +0000, Alakesh Haloi wrote: > Fixes following compiler warning > > userfaultfd.c: In function ‘usage’: > userfaultfd.c:126:2: warning: format not a string literal and no format > arguments [-Wformat-security] > fprintf(stderr, examples); > > Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com> Reviewed-by: Mike Rapoport <rppt@linux.ibm.com> > --- > tools/testing/selftests/vm/userfaultfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c > index 5d1db824f73a..b3e6497b080c 100644 > --- a/tools/testing/selftests/vm/userfaultfd.c > +++ b/tools/testing/selftests/vm/userfaultfd.c > @@ -123,7 +123,7 @@ static void usage(void) > fprintf(stderr, "Supported <test type>: anon, hugetlb, " > "hugetlb_shared, shmem\n\n"); > fprintf(stderr, "Examples:\n\n"); > - fprintf(stderr, examples); > + fprintf(stderr, "%s", examples); > exit(1); > } > > -- > 2.17.1 >
diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c index 5d1db824f73a..b3e6497b080c 100644 --- a/tools/testing/selftests/vm/userfaultfd.c +++ b/tools/testing/selftests/vm/userfaultfd.c @@ -123,7 +123,7 @@ static void usage(void) fprintf(stderr, "Supported <test type>: anon, hugetlb, " "hugetlb_shared, shmem\n\n"); fprintf(stderr, "Examples:\n\n"); - fprintf(stderr, examples); + fprintf(stderr, "%s", examples); exit(1); }
Fixes following compiler warning userfaultfd.c: In function ‘usage’: userfaultfd.c:126:2: warning: format not a string literal and no format arguments [-Wformat-security] fprintf(stderr, examples); Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com> --- tools/testing/selftests/vm/userfaultfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)