| Message ID | 20190528190218.GA6950@ip-172-31-44-144.us-west-2.compute.internal (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 5fac1718e706d94a7078addee9075cfaea00ca8c |
| Headers | show |
| Series | [bpf,v2] selftests: bpf: fix compiler warning | expand |
On Tue, May 28, 2019 at 12:35 PM Alakesh Haloi <alakesh.haloi@gmail.com> wrote: > > Add missing header file following compiler warning > > prog_tests/flow_dissector.c: In function ‘tx_tap’: > prog_tests/flow_dissector.c:175:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration] > return writev(fd, iov, ARRAY_SIZE(iov)); > ^~~~~~ > write > > Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less mode") > Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com> Acked-by: Song Liu <songliubraving@fb.com> Thanks for the fix! > --- > tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > index fbd1d88a6095..c938283ac232 100644 > --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > @@ -3,6 +3,7 @@ > #include <error.h> > #include <linux/if.h> > #include <linux/if_tun.h> > +#include <sys/uio.h> > > #define CHECK_FLOW_KEYS(desc, got, expected) \ > CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) != 0, \ > -- > 2.17.1 >
On 05/28/2019 09:02 PM, Alakesh Haloi wrote: > Add missing header file following compiler warning > > prog_tests/flow_dissector.c: In function ‘tx_tap’: > prog_tests/flow_dissector.c:175:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration] > return writev(fd, iov, ARRAY_SIZE(iov)); > ^~~~~~ > write > > Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less mode") > Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com> Applied, thanks!
diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c index fbd1d88a6095..c938283ac232 100644 --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c @@ -3,6 +3,7 @@ #include <error.h> #include <linux/if.h> #include <linux/if_tun.h> +#include <sys/uio.h> #define CHECK_FLOW_KEYS(desc, got, expected) \ CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) != 0, \
Add missing header file following compiler warning prog_tests/flow_dissector.c: In function ‘tx_tap’: prog_tests/flow_dissector.c:175:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration] return writev(fd, iov, ARRAY_SIZE(iov)); ^~~~~~ write Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less mode") Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com> --- tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 + 1 file changed, 1 insertion(+)