| Message ID | 20190528142424.19626-4-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Assorted fixes discovered with gcc 4.1 | expand |
On Tue, May 28, 2019 at 4:24 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > With gcc 4.1, when compiling for a 32-bit platform: > > net/sched/sch_pie.c: In function ‘drop_early’: > net/sched/sch_pie.c:116: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:138: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:144: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:147: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c: In function ‘pie_qdisc_enqueue’: > net/sched/sch_pie.c:173: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c: In function ‘calculate_probability’: > net/sched/sch_pie.c:371: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:372: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:377: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:382: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:397: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:398: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:399: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:407: warning: integer constant is too large for ‘long’ type > net/sched/sch_pie.c:414: warning: integer constant is too large for ‘long’ type > > Fix this by adding the missing "ULL" suffix. > > Fixes: 3f7ae5f3dc5295ac ("net: sched: pie: add more cases to auto-tune alpha and beta") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> I created patches for all instances of this issue at some point in the past, but did not send those as we raised the minimum compiler version to one that handles this in the expected way without a warning. Maybe you can just ignore these as well? Arnd
diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 8fa129d3943e32ad..f3424833e6a7cd3b 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -31,7 +31,7 @@ #define QUEUE_THRESHOLD 16384 #define DQCOUNT_INVALID -1 -#define MAX_PROB 0xffffffffffffffff +#define MAX_PROB 0xffffffffffffffffULL #define PIE_SCALE 8 /* parameters used */
With gcc 4.1, when compiling for a 32-bit platform: net/sched/sch_pie.c: In function ‘drop_early’: net/sched/sch_pie.c:116: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:138: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:144: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:147: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c: In function ‘pie_qdisc_enqueue’: net/sched/sch_pie.c:173: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c: In function ‘calculate_probability’: net/sched/sch_pie.c:371: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:372: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:377: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:382: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:397: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:398: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:399: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:407: warning: integer constant is too large for ‘long’ type net/sched/sch_pie.c:414: warning: integer constant is too large for ‘long’ type Fix this by adding the missing "ULL" suffix. Fixes: 3f7ae5f3dc5295ac ("net: sched: pie: add more cases to auto-tune alpha and beta") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)