| Message ID | 20190529110355.GA19119@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: selftest_lrc: Check the correct variable | expand |
Quoting Dan Carpenter (2019-05-29 12:03:55) > We should check "request[n]" instead of just "request". > > Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Oops. Reviewd-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
Quoting Chris Wilson (2019-05-29 12:06:57) > Quoting Dan Carpenter (2019-05-29 12:03:55) > > We should check "request[n]" instead of just "request". > > > > Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Oops. > Reviewd-by: Chris Wilson <chris@chris-wilson.co.uk> s/Reviewd/Reviewed/ And pushed, thanks for the fix. -Chris
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index a8c50900e2d4..13674f836955 100644 --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c @@ -1526,8 +1526,8 @@ static int mask_virtual_engine(struct drm_i915_private *i915, for (n = 0; n < nsibling; n++) { request[n] = i915_request_create(ve); - if (IS_ERR(request)) { - err = PTR_ERR(request); + if (IS_ERR(request[n])) { + err = PTR_ERR(request[n]); nsibling = n; goto out; }
We should check "request[n]" instead of just "request". Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)