| Message ID | 1559621375-5436-3-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: renesas_usbhs: remove unused features | expand |
Hi Shimoda-san, On Tue, Jun 4, 2019 at 6:14 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Controlling PWMEN/EXTLP (named as "has_otg") was supported in v3.2, > but was never used by any platform. So, this patch remove it. Actually it was used, by legacy (pre-DT) board support for kzm9g and mackerel. The last user was removed by commit 30f8925a57d8ad49 ("ARM: shmobile: Remove legacy board code for KZM-A9-GT"). > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, Jun 04, 2019 at 01:09:35PM +0900, Yoshihiro Shimoda wrote: > Controlling PWMEN/EXTLP (named as "has_otg") was supported in v3.2, > but was never used by any platform. So, this patch remove it. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, June 4, 2019 6:14 PM > > Hi Shimoda-san, > > On Tue, Jun 4, 2019 at 6:14 AM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > Controlling PWMEN/EXTLP (named as "has_otg") was supported in v3.2, > > but was never used by any platform. So, this patch remove it. > > Actually it was used, by legacy (pre-DT) board support for kzm9g and > mackerel. > The last user was removed by commit 30f8925a57d8ad49 ("ARM: shmobile: > Remove legacy board code for KZM-A9-GT"). Thank you for the comment. I'll revise the commit log on v2. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you for your review! Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index c7c9c5d..a501ea6 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -95,10 +95,6 @@ void usbhs_sys_host_ctrl(struct usbhs_priv *priv, int enable) { u16 mask = DCFM | DRPD | DPRPU | HSE | USBE; u16 val = DCFM | DRPD | HSE | USBE; - int has_otg = usbhs_get_dparam(priv, has_otg); - - if (has_otg) - usbhs_bset(priv, DVSTCTR, (EXTLP | PWEN), (EXTLP | PWEN)); /* * if enable diff --git a/include/linux/usb/renesas_usbhs.h b/include/linux/usb/renesas_usbhs.h index a2481f4d..b2cba7c 100644 --- a/include/linux/usb/renesas_usbhs.h +++ b/include/linux/usb/renesas_usbhs.h @@ -186,7 +186,6 @@ struct renesas_usbhs_driver_param { /* * option: */ - u32 has_otg:1; /* for controlling PWEN/EXTLP */ u32 has_usb_dmac:1; /* for USB-DMAC */ u32 runtime_pwctrl:1; u32 has_cnen:1;
Controlling PWMEN/EXTLP (named as "has_otg") was supported in v3.2, but was never used by any platform. So, this patch remove it. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/renesas_usbhs/common.c | 4 ---- include/linux/usb/renesas_usbhs.h | 1 - 2 files changed, 5 deletions(-)