| Message ID | 15ed3957-d4f5-01a0-3d2e-d8a69cc435ce@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | include WARN, REPAIR build options in XFS_BUILD_OPTIONS | expand |
On Tue, Jun 04, 2019 at 06:23:25PM -0500, Eric Sandeen wrote: > The XFS_BUILD_OPTIONS string, shown at module init time and > in modinfo output, does not currently include all available > build options. So, add in CONFIG_XFS_WARN and CONFIG_XFS_REPAIR. > > It has been suggested in some quarters > That this is not enough. > Well ... I saw what you did there ;) Reviewed-by: Bill O'Donnell <billodo@redhat.com> > > Anybody who would like to see this in a sysfs file can send > a patch. :) > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> > --- > > I might send that patch, but would like to have the string > advertising build options be complete, for now. > > diff --git a/fs/xfs/xfs_super.h b/fs/xfs/xfs_super.h > index 21cb49a..763e43d 100644 > --- a/fs/xfs/xfs_super.h > +++ b/fs/xfs/xfs_super.h > @@ -38,6 +38,18 @@ > # define XFS_SCRUB_STRING > #endif > > +#ifdef CONFIG_XFS_ONLINE_REPAIR > +# define XFS_REPAIR_STRING "repair, " > +#else > +# define XFS_REPAIR_STRING > +#endif > + > +#ifdef CONFIG_XFS_WARN > +# define XFS_WARN_STRING "verbose warnings, " > +#else > +# define XFS_WARN_STRING > +#endif > + > #ifdef DEBUG > # define XFS_DBG_STRING "debug" > #else > @@ -49,6 +61,8 @@ > XFS_SECURITY_STRING \ > XFS_REALTIME_STRING \ > XFS_SCRUB_STRING \ > + XFS_REPAIR_STRING \ > + XFS_WARN_STRING \ > XFS_DBG_STRING /* DBG must be last */ > > struct xfs_inode; >
On Tue, Jun 04, 2019 at 06:23:25PM -0500, Eric Sandeen wrote: > The XFS_BUILD_OPTIONS string, shown at module init time and > in modinfo output, does not currently include all available > build options. So, add in CONFIG_XFS_WARN and CONFIG_XFS_REPAIR. > > It has been suggested in some quarters > That this is not enough. > Well ... > > Anybody who would like to see this in a sysfs file can send > a patch. :) > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> > --- > > I might send that patch, but would like to have the string > advertising build options be complete, for now. > Er, are you working on that patch now? LGTM, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > diff --git a/fs/xfs/xfs_super.h b/fs/xfs/xfs_super.h > index 21cb49a..763e43d 100644 > --- a/fs/xfs/xfs_super.h > +++ b/fs/xfs/xfs_super.h > @@ -38,6 +38,18 @@ > # define XFS_SCRUB_STRING > #endif > > +#ifdef CONFIG_XFS_ONLINE_REPAIR > +# define XFS_REPAIR_STRING "repair, " > +#else > +# define XFS_REPAIR_STRING > +#endif > + > +#ifdef CONFIG_XFS_WARN > +# define XFS_WARN_STRING "verbose warnings, " > +#else > +# define XFS_WARN_STRING > +#endif > + > #ifdef DEBUG > # define XFS_DBG_STRING "debug" > #else > @@ -49,6 +61,8 @@ > XFS_SECURITY_STRING \ > XFS_REALTIME_STRING \ > XFS_SCRUB_STRING \ > + XFS_REPAIR_STRING \ > + XFS_WARN_STRING \ > XFS_DBG_STRING /* DBG must be last */ > > struct xfs_inode; >
diff --git a/fs/xfs/xfs_super.h b/fs/xfs/xfs_super.h index 21cb49a..763e43d 100644 --- a/fs/xfs/xfs_super.h +++ b/fs/xfs/xfs_super.h @@ -38,6 +38,18 @@ # define XFS_SCRUB_STRING #endif +#ifdef CONFIG_XFS_ONLINE_REPAIR +# define XFS_REPAIR_STRING "repair, " +#else +# define XFS_REPAIR_STRING +#endif + +#ifdef CONFIG_XFS_WARN +# define XFS_WARN_STRING "verbose warnings, " +#else +# define XFS_WARN_STRING +#endif + #ifdef DEBUG # define XFS_DBG_STRING "debug" #else @@ -49,6 +61,8 @@ XFS_SECURITY_STRING \ XFS_REALTIME_STRING \ XFS_SCRUB_STRING \ + XFS_REPAIR_STRING \ + XFS_WARN_STRING \ XFS_DBG_STRING /* DBG must be last */ struct xfs_inode;
The XFS_BUILD_OPTIONS string, shown at module init time and in modinfo output, does not currently include all available build options. So, add in CONFIG_XFS_WARN and CONFIG_XFS_REPAIR. It has been suggested in some quarters That this is not enough. Well ... Anybody who would like to see this in a sysfs file can send a patch. :) Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- I might send that patch, but would like to have the string advertising build options be complete, for now.