| Message ID | d0d1cd16f3995d8c22a5a4a0d2018482cb739354.1559764506.git.skhan@linuxfoundation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fixes to cppcheck errors in v4l2-ioctl.c | expand |
On 6/5/19 11:53 PM, Shuah Khan wrote: > Fix the following cppcheck error: > > Checking drivers/media/v4l2-core/v4l2-ioctl.c ... > Checking drivers/media/v4l2-core/v4l2-ioctl.c: CONFIG_VIDEO_ADV_DEBUG... > [drivers/media/v4l2-core/v4l2-ioctl.c:2470]: (error) Uninitialized variable: sd This is a false report: sd is set by v4l2_device_for_each_subdev before it is used. I'm dropping this patch. Regards, Hans > > Signed-off-by: Shuah Khan <skhan@linuxfoundation.org> > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index 333e387bafeb..205addb949ce 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -2445,7 +2445,7 @@ static int v4l_dbg_g_chip_info(const struct v4l2_ioctl_ops *ops, > #ifdef CONFIG_VIDEO_ADV_DEBUG > struct video_device *vfd = video_devdata(file); > struct v4l2_dbg_chip_info *p = arg; > - struct v4l2_subdev *sd; > + struct v4l2_subdev *sd = NULL; > int idx = 0; > > switch (p->match.type) { >
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 333e387bafeb..205addb949ce 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c @@ -2445,7 +2445,7 @@ static int v4l_dbg_g_chip_info(const struct v4l2_ioctl_ops *ops, #ifdef CONFIG_VIDEO_ADV_DEBUG struct video_device *vfd = video_devdata(file); struct v4l2_dbg_chip_info *p = arg; - struct v4l2_subdev *sd; + struct v4l2_subdev *sd = NULL; int idx = 0; switch (p->match.type) {
Fix the following cppcheck error: Checking drivers/media/v4l2-core/v4l2-ioctl.c ... Checking drivers/media/v4l2-core/v4l2-ioctl.c: CONFIG_VIDEO_ADV_DEBUG... [drivers/media/v4l2-core/v4l2-ioctl.c:2470]: (error) Uninitialized variable: sd Signed-off-by: Shuah Khan <skhan@linuxfoundation.org> --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)