| Message ID | 20190525140908.2804-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | dbcbabf7da921f98beefb4a6f4b91eb62d072076 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [-next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices | expand |
Hi all, Friendly ping... On 2019/5/25 22:09, YueHaibing wrote: > We should return 'retval' as the correct return value > instead of always zero. > > Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/hid/hid-logitech-dj.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c > index 41baa4dbbfcc..7f8db602eec0 100644 > --- a/drivers/hid/hid-logitech-dj.c > +++ b/drivers/hid/hid-logitech-dj.c > @@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev) > HID_REQ_SET_REPORT); > > kfree(hidpp_report); > - return 0; > + return retval; > } > > static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev) >
Hi, On 11-06-19 05:00, Yuehaibing wrote: > Hi all, > > Friendly ping... > > On 2019/5/25 22:09, YueHaibing wrote: >> We should return 'retval' as the correct return value >> instead of always zero. >> >> Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers") >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> Patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans >> --- >> drivers/hid/hid-logitech-dj.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c >> index 41baa4dbbfcc..7f8db602eec0 100644 >> --- a/drivers/hid/hid-logitech-dj.c >> +++ b/drivers/hid/hid-logitech-dj.c >> @@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev) >> HID_REQ_SET_REPORT); >> >> kfree(hidpp_report); >> - return 0; >> + return retval; >> } >> >> static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev) >> >
On Tue, Jun 11, 2019 at 5:01 AM Yuehaibing <yuehaibing@huawei.com> wrote: > > Hi all, > > Friendly ping... Applied to for-5.3/logitech Thanks! Cheers, Benjamin > > On 2019/5/25 22:09, YueHaibing wrote: > > We should return 'retval' as the correct return value > > instead of always zero. > > > > Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > --- > > drivers/hid/hid-logitech-dj.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c > > index 41baa4dbbfcc..7f8db602eec0 100644 > > --- a/drivers/hid/hid-logitech-dj.c > > +++ b/drivers/hid/hid-logitech-dj.c > > @@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev) > > HID_REQ_SET_REPORT); > > > > kfree(hidpp_report); > > - return 0; > > + return retval; > > } > > > > static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev) > > >
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 41baa4dbbfcc..7f8db602eec0 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev) HID_REQ_SET_REPORT); kfree(hidpp_report); - return 0; + return retval; } static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)
We should return 'retval' as the correct return value instead of always zero. Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/hid/hid-logitech-dj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)