| Message ID | 8bcd72a762f0fd349f8bf7d0b134cc7033ae6f00.1560295286.git.steadmon@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add a JSON Schema for trace2 events | expand |
Josh Steadmon <steadmon@google.com> writes: > Correct the api-trace2 documentation, which lists "signal" as an > expected field for the signal event type, but which actually outputs > "signo" as the field name. Nice. Is this one of the findings made by your validation, by the way? > > Signed-off-by: Josh Steadmon <steadmon@google.com> > --- > Documentation/technical/api-trace2.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt > index 23c3cc7a37..fd1e628944 100644 > --- a/Documentation/technical/api-trace2.txt > +++ b/Documentation/technical/api-trace2.txt > @@ -668,7 +668,7 @@ completed.) > "event":"signal", > ... > "t_abs":0.001227, # elapsed time in seconds > - "signal":13 # SIGTERM, SIGINT, etc. > + "signo":13 # SIGTERM, SIGINT, etc. > } > ------------
On 2019.06.12 11:00, Junio C Hamano wrote: > Josh Steadmon <steadmon@google.com> writes: > > > Correct the api-trace2 documentation, which lists "signal" as an > > expected field for the signal event type, but which actually outputs > > "signo" as the field name. > > > Nice. Is this one of the findings made by your validation, by the way? Yes. I based both versions of the schema purely off the documentation, then tested against real output. This was the only discrepancy that was uncovered.
On 6/11/2019 7:31 PM, Josh Steadmon wrote: > Correct the api-trace2 documentation, which lists "signal" as an > expected field for the signal event type, but which actually outputs > "signo" as the field name. > > Signed-off-by: Josh Steadmon <steadmon@google.com> > --- > Documentation/technical/api-trace2.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt > index 23c3cc7a37..fd1e628944 100644 > --- a/Documentation/technical/api-trace2.txt > +++ b/Documentation/technical/api-trace2.txt > @@ -668,7 +668,7 @@ completed.) > "event":"signal", > ... > "t_abs":0.001227, # elapsed time in seconds > - "signal":13 # SIGTERM, SIGINT, etc. > + "signo":13 # SIGTERM, SIGINT, etc. > } > ------------ > > Nice! Thanks, Jeff
diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt index 23c3cc7a37..fd1e628944 100644 --- a/Documentation/technical/api-trace2.txt +++ b/Documentation/technical/api-trace2.txt @@ -668,7 +668,7 @@ completed.) "event":"signal", ... "t_abs":0.001227, # elapsed time in seconds - "signal":13 # SIGTERM, SIGINT, etc. + "signo":13 # SIGTERM, SIGINT, etc. } ------------
Correct the api-trace2 documentation, which lists "signal" as an expected field for the signal event type, but which actually outputs "signo" as the field name. Signed-off-by: Josh Steadmon <steadmon@google.com> --- Documentation/technical/api-trace2.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)