| Message ID | 20190608105619.593-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | treewide: simplify getting the adapter of an I2C client | expand |
On Sat, Jun 08, 2019 at 12:55:40PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > --- > > Please apply to your subsystem tree. > > drivers/clk/clk-cdce706.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-cdce706.c b/drivers/clk/clk-cdce706.c > index f21d9092564f..476d29c013e5 100644 > --- a/drivers/clk/clk-cdce706.c > +++ b/drivers/clk/clk-cdce706.c > @@ -633,7 +633,7 @@ of_clk_cdce_get(struct of_phandle_args *clkspec, void *data) > static int cdce706_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); > + struct i2c_adapter *adapter = client->adapter; > struct cdce706_dev_data *cdce; > int ret; > > -- > 2.19.1 >
Quoting Wolfram Sang (2019-06-08 03:55:40) > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- Applied to clk-next
diff --git a/drivers/clk/clk-cdce706.c b/drivers/clk/clk-cdce706.c index f21d9092564f..476d29c013e5 100644 --- a/drivers/clk/clk-cdce706.c +++ b/drivers/clk/clk-cdce706.c @@ -633,7 +633,7 @@ of_clk_cdce_get(struct of_phandle_args *clkspec, void *data) static int cdce706_probe(struct i2c_client *client, const struct i2c_device_id *id) { - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); + struct i2c_adapter *adapter = client->adapter; struct cdce706_dev_data *cdce; int ret;
We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Please apply to your subsystem tree. drivers/clk/clk-cdce706.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)