| Message ID | 20190606184923.39537-1-jeffrey.l.hugo@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | PM8005 and PMS405 regulator support | expand |
On Thu, Jun 06, 2019 at 11:49:23AM -0700, Jeffrey Hugo wrote: > From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> > > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
On Thu, Jun 06, 2019 at 11:49:23AM -0700, Jeffrey Hugo wrote: > + if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_HFS430) { > + /* since there is only one range */ > + range = spmi_regulator_find_range(vreg); > + vreg->desc.uV_step = range->step_uV; > + } This doesn't build for me: drivers/regulator/qcom_spmi-regulator.c: In function ‘qcom_spmi_regulator_probe’: drivers/regulator/qcom_spmi-regulator.c:1837:29: error: ‘SPMI_REGULATOR_LOGICAL_TYPE_HFS430’ undeclared (first use in this function); did you mean ‘SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS’? if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_HFS430) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS drivers/regulator/qcom_spmi-regulator.c:1837:29: note: each undeclared identifier is reported only once for each function it appears in
diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index 53a61fb65642..fd55438c25d6 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -1744,6 +1744,7 @@ MODULE_DEVICE_TABLE(of, qcom_spmi_regulator_match); static int qcom_spmi_regulator_probe(struct platform_device *pdev) { const struct spmi_regulator_data *reg; + const struct spmi_voltage_range *range; const struct of_device_id *match; struct regulator_config config = { }; struct regulator_dev *rdev; @@ -1833,6 +1834,12 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev) } } + if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_HFS430) { + /* since there is only one range */ + range = spmi_regulator_find_range(vreg); + vreg->desc.uV_step = range->step_uV; + } + config.dev = dev; config.driver_data = vreg; config.regmap = regmap;