diff mbox series

drm/connector: Fix kerneldoc warning in HDR_OUTPUT_METADATA description

Message ID 20190613151727.133696-1-sean@poorly.run (mailing list archive)
State New, archived
Headers show
Series drm/connector: Fix kerneldoc warning in HDR_OUTPUT_METADATA description | expand

Commit Message

Sean Paul June 13, 2019, 3:17 p.m. UTC 
From: Sean Paul <seanpaul@chromium.org>

Fixes the following warning:
../drivers/gpu/drm/drm_connector.c:981: WARNING: Definition list ends without a blank line; unexpected unindent.

Fixes: a09db883e5d9 ("drm: Fix docbook warnings in hdr metadata helper structures")
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Ville Syrjä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: "Ville Syrjä" <ville.syrjala@linux.intel.com>
Cc: Hans Verkuil <hansverk@cisco.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Cc: Sean Paul <sean@poorly.run> (v1)
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 drivers/gpu/drm/drm_connector.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Deucher June 13, 2019, 4:57 p.m. UTC | #1 
On Thu, Jun 13, 2019 at 11:17 AM Sean Paul <sean@poorly.run> wrote:
>
> From: Sean Paul <seanpaul@chromium.org>
>
> Fixes the following warning:
> ../drivers/gpu/drm/drm_connector.c:981: WARNING: Definition list ends without a blank line; unexpected unindent.
>
> Fixes: a09db883e5d9 ("drm: Fix docbook warnings in hdr metadata helper structures")
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Ville Syrjä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: "Ville Syrjä" <ville.syrjala@linux.intel.com>
> Cc: Hans Verkuil <hansverk@cisco.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: Sean Paul <sean@poorly.run> (v1)
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/drm_connector.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index a598a5eb48d21..3ccdcf3dfcde2 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -978,6 +978,7 @@ static const struct drm_prop_enum_list hdmi_colorspaces[] = {
>   *     Userspace will be responsible to do Tone mapping operation in case:
>   *             - Some layers are HDR and others are SDR
>   *             - HDR layers luminance is not same as sink
> + *
>   *     It will even need to do colorspace conversion and get all layers
>   *     to one common colorspace for blending. It can use either GL, Media
>   *     or display engine to get this done based on the capabilties of the
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sean Paul June 13, 2019, 7:06 p.m. UTC | #2 
On Thu, Jun 13, 2019 at 12:57:29PM -0400, Alex Deucher wrote:
> On Thu, Jun 13, 2019 at 11:17 AM Sean Paul <sean@poorly.run> wrote:
> >
> > From: Sean Paul <seanpaul@chromium.org>
> >
> > Fixes the following warning:
> > ../drivers/gpu/drm/drm_connector.c:981: WARNING: Definition list ends without a blank line; unexpected unindent.
> >
> > Fixes: a09db883e5d9 ("drm: Fix docbook warnings in hdr metadata helper structures")
> > Cc: Shashank Sharma <shashank.sharma@intel.com>
> > Cc: Ville Syrjä <ville.syrjala@linux.intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: "Ville Syrjä" <ville.syrjala@linux.intel.com>
> > Cc: Hans Verkuil <hansverk@cisco.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: linux-fbdev@vger.kernel.org
> > Cc: Sean Paul <sean@poorly.run> (v1)
> > Cc: Uma Shankar <uma.shankar@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> 
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Thanks Alex, I've applied this to -misc-next

> 
> > ---
> >  drivers/gpu/drm/drm_connector.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> > index a598a5eb48d21..3ccdcf3dfcde2 100644
> > --- a/drivers/gpu/drm/drm_connector.c
> > +++ b/drivers/gpu/drm/drm_connector.c
> > @@ -978,6 +978,7 @@ static const struct drm_prop_enum_list hdmi_colorspaces[] = {
> >   *     Userspace will be responsible to do Tone mapping operation in case:
> >   *             - Some layers are HDR and others are SDR
> >   *             - HDR layers luminance is not same as sink
> > + *
> >   *     It will even need to do colorspace conversion and get all layers
> >   *     to one common colorspace for blending. It can use either GL, Media
> >   *     or display engine to get this done based on the capabilties of the
> > --
> > Sean Paul, Software Engineer, Google / Chromium OS
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index a598a5eb48d21..3ccdcf3dfcde2 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -978,6 +978,7 @@  static const struct drm_prop_enum_list hdmi_colorspaces[] = {
  *	Userspace will be responsible to do Tone mapping operation in case:
  *		- Some layers are HDR and others are SDR
  *		- HDR layers luminance is not same as sink
+ *
  *	It will even need to do colorspace conversion and get all layers
  *	to one common colorspace for blending. It can use either GL, Media
  *	or display engine to get this done based on the capabilties of the