| Message ID | 20190613183727.28774-1-mreitz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iotests: Hide timestamps for skipped tests | expand |
On 6/13/19 1:37 PM, Max Reitz wrote: > Currently, the "thistime" variable is not reinitialized on every loop > iteration. This leads to tests that do not yield a run time (because > they failed or were skipped) printing the run time of the previous test > that did. Fix that by reinitializing "thistime" for every test. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > tests/qemu-iotests/check | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check > index 44ebf24080..f925606cc5 100755 > --- a/tests/qemu-iotests/check > +++ b/tests/qemu-iotests/check > @@ -773,6 +773,7 @@ do > printdiff=false # show diff to reference output? > status="" # test result summary > results="" # test result details > + thistime="" # time the test took > > if [ -n "$TESTS_REMAINING_LOG" ] ; then > sed -e "s/$seq//" -e 's/ / /' -e 's/^ *//' $TESTS_REMAINING_LOG > $TESTS_REMAINING_LOG.tmp >
On 6/13/19 8:37 PM, Max Reitz wrote: > Currently, the "thistime" variable is not reinitialized on every loop > iteration. This leads to tests that do not yield a run time (because > they failed or were skipped) printing the run time of the previous test > that did. Fix that by reinitializing "thistime" for every test. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > tests/qemu-iotests/check | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check > index 44ebf24080..f925606cc5 100755 > --- a/tests/qemu-iotests/check > +++ b/tests/qemu-iotests/check > @@ -773,6 +773,7 @@ do > printdiff=false # show diff to reference output? > status="" # test result summary > results="" # test result details > + thistime="" # time the test took > > if [ -n "$TESTS_REMAINING_LOG" ] ; then > sed -e "s/$seq//" -e 's/ / /' -e 's/^ *//' $TESTS_REMAINING_LOG > $TESTS_REMAINING_LOG.tmp > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Am 13.06.2019 um 20:37 hat Max Reitz geschrieben: > Currently, the "thistime" variable is not reinitialized on every loop > iteration. This leads to tests that do not yield a run time (because > they failed or were skipped) printing the run time of the previous test > that did. Fix that by reinitializing "thistime" for every test. > > Signed-off-by: Max Reitz <mreitz@redhat.com> Thanks, applied to the block branch. Kevin
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index 44ebf24080..f925606cc5 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -773,6 +773,7 @@ do printdiff=false # show diff to reference output? status="" # test result summary results="" # test result details + thistime="" # time the test took if [ -n "$TESTS_REMAINING_LOG" ] ; then sed -e "s/$seq//" -e 's/ / /' -e 's/^ *//' $TESTS_REMAINING_LOG > $TESTS_REMAINING_LOG.tmp
Currently, the "thistime" variable is not reinitialized on every loop iteration. This leads to tests that do not yield a run time (because they failed or were skipped) printing the run time of the previous test that did. Fix that by reinitializing "thistime" for every test. Signed-off-by: Max Reitz <mreitz@redhat.com> --- tests/qemu-iotests/check | 1 + 1 file changed, 1 insertion(+)