| Message ID | d654907d-a3a2-a00f-d6f5-3a34ae25ebcf@free.fr (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2] clk: qcom: msm8916: Don't build by default | expand |
On Thu 13 Jun 08:09 PDT 2019, Marc Gonzalez wrote: > QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options > built by default. Let's bring them back in line with the rest. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> This looks reasonable Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > Changes from v1: > - Drop the default altogether, instead of changing it to 'default MSM_GCC_8916' > --- > drivers/clk/qcom/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index e1ff83cc361e..6461a1aa7325 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -21,7 +21,6 @@ if COMMON_CLK_QCOM > > config QCOM_A53PLL > tristate "MSM8916 A53 PLL" > - default ARCH_QCOM > help > Support for the A53 PLL on MSM8916 devices. It provides > the CPU with frequencies above 1GHz. > @@ -31,7 +30,6 @@ config QCOM_A53PLL > config QCOM_CLK_APCS_MSM8916 > tristate "MSM8916 APCS Clock Controller" > depends on QCOM_APCS_IPC || COMPILE_TEST > - default ARCH_QCOM > help > Support for the APCS Clock Controller on msm8916 devices. The > APCS is managing the mux and divider which feeds the CPUs. > -- > 2.17.1
On 6/13/19 18:09, Marc Gonzalez wrote: > QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options > built by default. Let's bring them back in line with the rest. > This change looks fine, but maybe we should enable these in defconfig? Thanks, Georgi > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > --- > Changes from v1: > - Drop the default altogether, instead of changing it to 'default MSM_GCC_8916' > --- > drivers/clk/qcom/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index e1ff83cc361e..6461a1aa7325 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -21,7 +21,6 @@ if COMMON_CLK_QCOM > > config QCOM_A53PLL > tristate "MSM8916 A53 PLL" > - default ARCH_QCOM > help > Support for the A53 PLL on MSM8916 devices. It provides > the CPU with frequencies above 1GHz. > @@ -31,7 +30,6 @@ config QCOM_A53PLL > config QCOM_CLK_APCS_MSM8916 > tristate "MSM8916 APCS Clock Controller" > depends on QCOM_APCS_IPC || COMPILE_TEST > - default ARCH_QCOM > help > Support for the APCS Clock Controller on msm8916 devices. The > APCS is managing the mux and divider which feeds the CPUs. >
On 6/13/19 18:09, Marc Gonzalez wrote: > QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options > built by default. Let's bring them back in line with the rest. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> Acked-by: Georgi Djakov <georgi.djakov@linaro.org> In order to keep it functional, a separate patch is needed to enable the same config options in defconfig. The defconfig change should go through Andy and Bjorn. Thanks, Georgi > --- > Changes from v1: > - Drop the default altogether, instead of changing it to 'default MSM_GCC_8916' > --- > drivers/clk/qcom/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index e1ff83cc361e..6461a1aa7325 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -21,7 +21,6 @@ if COMMON_CLK_QCOM > > config QCOM_A53PLL > tristate "MSM8916 A53 PLL" > - default ARCH_QCOM > help > Support for the A53 PLL on MSM8916 devices. It provides > the CPU with frequencies above 1GHz. > @@ -31,7 +30,6 @@ config QCOM_A53PLL > config QCOM_CLK_APCS_MSM8916 > tristate "MSM8916 APCS Clock Controller" > depends on QCOM_APCS_IPC || COMPILE_TEST > - default ARCH_QCOM > help > Support for the APCS Clock Controller on msm8916 devices. The > APCS is managing the mux and divider which feeds the CPUs. >
Quoting Marc Gonzalez (2019-06-13 08:09:34) > QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options > built by default. Let's bring them back in line with the rest. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > --- Applied to clk-next
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index e1ff83cc361e..6461a1aa7325 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -21,7 +21,6 @@ if COMMON_CLK_QCOM config QCOM_A53PLL tristate "MSM8916 A53 PLL" - default ARCH_QCOM help Support for the A53 PLL on MSM8916 devices. It provides the CPU with frequencies above 1GHz. @@ -31,7 +30,6 @@ config QCOM_A53PLL config QCOM_CLK_APCS_MSM8916 tristate "MSM8916 APCS Clock Controller" depends on QCOM_APCS_IPC || COMPILE_TEST - default ARCH_QCOM help Support for the APCS Clock Controller on msm8916 devices. The APCS is managing the mux and divider which feeds the CPUs.
QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options built by default. Let's bring them back in line with the rest. Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> --- Changes from v1: - Drop the default altogether, instead of changing it to 'default MSM_GCC_8916' --- drivers/clk/qcom/Kconfig | 2 -- 1 file changed, 2 deletions(-)