| Message ID | a88f36a998eb3fc91cc70bc8fc76e3614706cdbe.1560529045.git.melissa.srw@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: ad7150: improve driver readability | expand |
On Fri, 14 Jun 2019 13:33:19 -0300 Melissa Wen <melissa.srw@gmail.com> wrote: > General cleaning of comments to remove useless information or improve > description. > > Signed-off-by: Melissa Wen <melissa.srw@gmail.com> Applied, Thanks, Jonathan > --- > drivers/staging/iio/cdc/ad7150.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > index 7d56f10a19ed..51d6b52bce8b 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -163,7 +163,8 @@ static int ad7150_read_event_config(struct iio_dev *indio_dev, > return -EINVAL; > } > > -/* lock should be held */ > +/* state_lock should be held to ensure consistent state*/ > + > static int ad7150_write_event_params(struct iio_dev *indio_dev, > unsigned int chan, > enum iio_event_type type, > @@ -479,10 +480,6 @@ static const struct iio_chan_spec ad7150_channels[] = { > AD7150_CAPACITANCE_CHAN(1) > }; > > -/* > - * threshold events > - */ > - > static irqreturn_t ad7150_event_handler(int irq, void *private) > { > struct iio_dev *indio_dev = private; > @@ -571,10 +568,6 @@ static const struct iio_info ad7150_info = { > .write_event_value = &ad7150_write_event_value, > }; > > -/* > - * device probe and remove > - */ > - > static int ad7150_probe(struct i2c_client *client, > const struct i2c_device_id *id) > {
diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c index 7d56f10a19ed..51d6b52bce8b 100644 --- a/drivers/staging/iio/cdc/ad7150.c +++ b/drivers/staging/iio/cdc/ad7150.c @@ -163,7 +163,8 @@ static int ad7150_read_event_config(struct iio_dev *indio_dev, return -EINVAL; } -/* lock should be held */ +/* state_lock should be held to ensure consistent state*/ + static int ad7150_write_event_params(struct iio_dev *indio_dev, unsigned int chan, enum iio_event_type type, @@ -479,10 +480,6 @@ static const struct iio_chan_spec ad7150_channels[] = { AD7150_CAPACITANCE_CHAN(1) }; -/* - * threshold events - */ - static irqreturn_t ad7150_event_handler(int irq, void *private) { struct iio_dev *indio_dev = private; @@ -571,10 +568,6 @@ static const struct iio_info ad7150_info = { .write_event_value = &ad7150_write_event_value, }; -/* - * device probe and remove - */ - static int ad7150_probe(struct i2c_client *client, const struct i2c_device_id *id) {
General cleaning of comments to remove useless information or improve description. Signed-off-by: Melissa Wen <melissa.srw@gmail.com> --- drivers/staging/iio/cdc/ad7150.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)