| Message ID | 20190614203615.12639-8-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | prime doc polish and ... a few cleanups | expand |
On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > Read the docs, komeda is not an old enough driver for this :-) > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: "James (Qian) Wang" <james.qian.wang@arm.com> > Cc: Liviu Dudau <liviu.dudau@arm.com> > --- > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > index 0c6396dc323f..b9d699cc7bbf 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > @@ -55,8 +55,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) > } > > static struct drm_driver komeda_kms_driver = { > - .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC | > - DRIVER_HAVE_IRQ, > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > .lastclose = drm_fb_helper_lastclose, > .irq_handler = komeda_kms_irq_handler, Hi Daniel: Thank you for the patch. And Ayan also sent two patches for this topic. like: For drop drm_irq_install: https://patchwork.freedesktop.org/series/61763/ For manually set drm->irq_enabled: https://patchwork.freedesktop.org/series/61776/ For clear, seems we'd better squash all these three patches into one single patch. Hi Ayan: Could you help the squash all these patches to a single one. Thanks James > .gem_free_object_unlocked = drm_gem_cma_free_object, > -- > 2.20.1
On Mon, Jun 17, 2019 at 06:26:08AM +0000, james qian wang (Arm Technology China) wrote: > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > > Read the docs, komeda is not an old enough driver for this :-) > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: "James (Qian) Wang" <james.qian.wang@arm.com> > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > --- > > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > index 0c6396dc323f..b9d699cc7bbf 100644 > > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > @@ -55,8 +55,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) > > } > > > > static struct drm_driver komeda_kms_driver = { > > - .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC | > > - DRIVER_HAVE_IRQ, > > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > > .lastclose = drm_fb_helper_lastclose, > > .irq_handler = komeda_kms_irq_handler, > > Hi Daniel: > > Thank you for the patch. > > And Ayan also sent two patches for this topic. like: > > For drop drm_irq_install: > https://patchwork.freedesktop.org/series/61763/ > For manually set drm->irq_enabled: > https://patchwork.freedesktop.org/series/61776/ > > For clear, seems we'd better squash all these three patches into one > single patch. Not sure how these other patches are related to mine directly. This here just removes a flag which does nothing, because komeda is not a legacy driver. And ack for merging right away would be nice. Thanks, Daniel > > Hi Ayan: > Could you help the squash all these patches to a single one. > > Thanks > James > > > .gem_free_object_unlocked = drm_gem_cma_free_object, > > -- > > 2.20.1
On 2019/06/17, james qian wang (Arm Technology China) wrote: > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > > Read the docs, komeda is not an old enough driver for this :-) > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: "James (Qian) Wang" <james.qian.wang@arm.com> > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > --- > > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > index 0c6396dc323f..b9d699cc7bbf 100644 > > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > @@ -55,8 +55,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) > > } > > > > static struct drm_driver komeda_kms_driver = { > > - .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC | > > - DRIVER_HAVE_IRQ, > > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > > .lastclose = drm_fb_helper_lastclose, > > .irq_handler = komeda_kms_irq_handler, > > Hi Daniel: > > Thank you for the patch. > > And Ayan also sent two patches for this topic. like: > > For drop drm_irq_install: > https://patchwork.freedesktop.org/series/61763/ > For manually set drm->irq_enabled: > https://patchwork.freedesktop.org/series/61776/ > > For clear, seems we'd better squash all these three patches into one > single patch. > > Hi Ayan: > Could you help the squash all these patches to a single one. > Considering the extra patches, might be worth splitting this outside of this huge series? Emil
On Mon, Jun 17, 2019 at 03:43:45PM +0200, Daniel Vetter wrote: > On Mon, Jun 17, 2019 at 06:26:08AM +0000, james qian wang (Arm Technology China) wrote: > > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > > > Read the docs, komeda is not an old enough driver for this :-) > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > Cc: "James (Qian) Wang" <james.qian.wang@arm.com> > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > --- > > > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > > index 0c6396dc323f..b9d699cc7bbf 100644 > > > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > > @@ -55,8 +55,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) > > > } > > > > > > static struct drm_driver komeda_kms_driver = { > > > - .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC | > > > - DRIVER_HAVE_IRQ, > > > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > > > .lastclose = drm_fb_helper_lastclose, > > > .irq_handler = komeda_kms_irq_handler, Since once komeda had dropped drm_irq_install, we don't need to expose this irq_handler to drm as well, So I want irq_handler and DRIVER_HAVE_IRQ to be removed together with the drop patch. I think better put the replacement in one patch. Thanks James > > > > Hi Daniel: > > > > Thank you for the patch. > > > > And Ayan also sent two patches for this topic. like: > > > > For drop drm_irq_install: > > https://patchwork.freedesktop.org/series/61763/ > > For manually set drm->irq_enabled: > > https://patchwork.freedesktop.org/series/61776/ > > > > For clear, seems we'd better squash all these three patches into one > > single patch. > > Not sure how these other patches are related to mine directly. This here > just removes a flag which does nothing, because komeda is not a legacy > driver. And ack for merging right away would be nice. > > Thanks, Daniel > > > > > Hi Ayan: > > Could you help the squash all these patches to a single one. > > > > Thanks > > James > > > > > .gem_free_object_unlocked = drm_gem_cma_free_object, > > > -- > > > 2.20.1 > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
On Tue, Jun 18, 2019 at 12:41:32PM +0800, James (Qian) Wang wrote: > On Mon, Jun 17, 2019 at 03:43:45PM +0200, Daniel Vetter wrote: > > On Mon, Jun 17, 2019 at 06:26:08AM +0000, james qian wang (Arm Technology China) wrote: > > > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > > > > Read the docs, komeda is not an old enough driver for this :-) > > > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > > Cc: "James (Qian) Wang" <james.qian.wang@arm.com> > > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > > --- > > > > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 +-- > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > > > index 0c6396dc323f..b9d699cc7bbf 100644 > > > > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > > > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > > > @@ -55,8 +55,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) > > > > } > > > > > > > > static struct drm_driver komeda_kms_driver = { > > > > - .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC | > > > > - DRIVER_HAVE_IRQ, > > > > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > > > > .lastclose = drm_fb_helper_lastclose, > > > > .irq_handler = komeda_kms_irq_handler, > > Since once komeda had dropped drm_irq_install, we don't need to expose > this irq_handler to drm as well, So I want irq_handler and DRIVER_HAVE_IRQ > to be removed together with the drop patch. > > I think better put the replacement in one patch. > > Thanks > James Sorry, please ignore my last reply. I thought DRIVER_HAVE_IRQ is a indicator for the drm_driver->irq_handler. It is NOT. Thanks for your patch Daniel: Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com> > > > > > > Hi Daniel: > > > > > > Thank you for the patch. > > > > > > And Ayan also sent two patches for this topic. like: > > > > > > For drop drm_irq_install: > > > https://patchwork.freedesktop.org/series/61763/ > > > For manually set drm->irq_enabled: > > > https://patchwork.freedesktop.org/series/61776/ > > > > > > For clear, seems we'd better squash all these three patches into one > > > single patch. > > > > Not sure how these other patches are related to mine directly. This here > > just removes a flag which does nothing, because komeda is not a legacy > > driver. And ack for merging right away would be nice. > > > > Thanks, Daniel > > > > > > > > Hi Ayan: > > > Could you help the squash all these patches to a single one. > > > > > > Thanks > > > James > > > > > > > .gem_free_object_unlocked = drm_gem_cma_free_object, > > > > -- > > > > 2.20.1 > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch
On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > Read the docs, komeda is not an old enough driver for this :-) > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: "James (Qian) Wang" <james.qian.wang@arm.com> > Cc: Liviu Dudau <liviu.dudau@arm.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> I'm assuming the whole series goes through drm-misc and I don't need to pull this patch into mali-dp tree. Please shout if my assumptions are incorrect. Best regards, Liviu > --- > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > index 0c6396dc323f..b9d699cc7bbf 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > @@ -55,8 +55,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) > } > > static struct drm_driver komeda_kms_driver = { > - .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC | > - DRIVER_HAVE_IRQ, > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > .lastclose = drm_fb_helper_lastclose, > .irq_handler = komeda_kms_irq_handler, > .gem_free_object_unlocked = drm_gem_cma_free_object, > -- > 2.20.1 >
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c index 0c6396dc323f..b9d699cc7bbf 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -55,8 +55,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) } static struct drm_driver komeda_kms_driver = { - .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC | - DRIVER_HAVE_IRQ, + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, .lastclose = drm_fb_helper_lastclose, .irq_handler = komeda_kms_irq_handler, .gem_free_object_unlocked = drm_gem_cma_free_object,
Read the docs, komeda is not an old enough driver for this :-) Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: "James (Qian) Wang" <james.qian.wang@arm.com> Cc: Liviu Dudau <liviu.dudau@arm.com> --- drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)