| Message ID | 1560778040-12386-1-git-send-email-periyasa@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b24d6461d9cf254e512a91ca430be59e70da0d5d |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath11k: fix extended stats update issue | expand |
On 17/06/2019 15:27, Karthikeyan Periyasamy wrote: > user not able to see the valid tx stats. htt stats update > process get failed due to the wrong argument pass to > ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not > the pdev index. so avoid the conversion logic of pdev id to pdev > index in htt stats update process. > > Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org> Hi, thanks, i just ran into this problem an hour ago :-) John > --- > drivers/net/wireless/ath/ath11k/dp_rx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c > index 1d9892e..971c437 100644 > --- a/drivers/net/wireless/ath/ath11k/dp_rx.c > +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c > @@ -1294,7 +1294,6 @@ static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab, > > len = FIELD_GET(HTT_T2H_PPDU_STATS_PAYLOAD_SIZE_M, *(u32 *)data); > pdev_id = FIELD_GET(HTT_T2H_PPDU_STATS_PDEV_ID_M, *(u32 *)data); > - pdev_id = DP_HW2SW_MACID(pdev_id); > ppdu_id = *((u32 *)data + 1); > > rcu_read_lock();
Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote: > user not able to see the valid tx stats. htt stats update > process get failed due to the wrong argument pass to > ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not > the pdev index. so avoid the conversion logic of pdev id to pdev > index in htt stats update process. > > Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath11k-bringup branch of ath.git, thanks. b24d6461d9cf ath11k: fix extended stats update issue
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index 1d9892e..971c437 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -1294,7 +1294,6 @@ static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab, len = FIELD_GET(HTT_T2H_PPDU_STATS_PAYLOAD_SIZE_M, *(u32 *)data); pdev_id = FIELD_GET(HTT_T2H_PPDU_STATS_PDEV_ID_M, *(u32 *)data); - pdev_id = DP_HW2SW_MACID(pdev_id); ppdu_id = *((u32 *)data + 1); rcu_read_lock();
user not able to see the valid tx stats. htt stats update process get failed due to the wrong argument pass to ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not the pdev index. so avoid the conversion logic of pdev id to pdev index in htt stats update process. Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org> --- drivers/net/wireless/ath/ath11k/dp_rx.c | 1 - 1 file changed, 1 deletion(-)