| Message ID | 20190618213406.7667-2-ezequiel@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RK3288 Gamma LUT | expand |
Hi, On Tue, Jun 18, 2019 at 2:43 PM Ezequiel Garcia <ezequiel@collabora.com> wrote: > > Add the register specifier description for an > optional gamma LUT address. > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > --- > .../bindings/display/rockchip/rockchip-vop.txt | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > index 4f58c5a2d195..97ad78cc7e03 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > @@ -20,6 +20,13 @@ Required properties: > "rockchip,rk3228-vop"; > "rockchip,rk3328-vop"; > > +- reg: Must contain one entry corresponding to the base address and length > + of the register space. Can optionally contain a second entry > + corresponding to the CRTC gamma LUT address. > + > +- reg-names: "base" for the base register space. If present, the CRTC > + gamma LUT name should be "lut". As per Rob Herring, current suggestion is to avoid reg-names when possible. The code should just look for the presence of a 2nd entry and assume that if it's there that it's the lut range. Full context: https://lore.kernel.org/lkml/CAL_Jsq+MMunmVWqeW9v2RyzsMKP+=kMzeTHNMG4JDHM7Fy0HBg@mail.gmail.com/ -Doug
On Thu, 2019-06-20 at 09:43 -0700, Doug Anderson wrote: > Hi, > > On Tue, Jun 18, 2019 at 2:43 PM Ezequiel Garcia <ezequiel@collabora.com> wrote: > > Add the register specifier description for an > > optional gamma LUT address. > > > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > > --- > > .../bindings/display/rockchip/rockchip-vop.txt | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip- > > vop.txt > > index 4f58c5a2d195..97ad78cc7e03 100644 > > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > > @@ -20,6 +20,13 @@ Required properties: > > "rockchip,rk3228-vop"; > > "rockchip,rk3328-vop"; > > > > +- reg: Must contain one entry corresponding to the base address and length > > + of the register space. Can optionally contain a second entry > > + corresponding to the CRTC gamma LUT address. > > + > > +- reg-names: "base" for the base register space. If present, the CRTC > > + gamma LUT name should be "lut". > > As per Rob Herring, current suggestion is to avoid reg-names when > possible. The code should just look for the presence of a 2nd entry > and assume that if it's there that it's the lut range. Full context: > > > https://lore.kernel.org/lkml/CAL_Jsq+MMunmVWqeW9v2RyzsMKP+=kMzeTHNMG4JDHM7Fy0HBg@mail.gmail.com/ > Oh, that's news to me. I was assuming having reg-names was preferred. Thanks for the feedback, I'll send a new version.
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index 4f58c5a2d195..97ad78cc7e03 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt @@ -20,6 +20,13 @@ Required properties: "rockchip,rk3228-vop"; "rockchip,rk3328-vop"; +- reg: Must contain one entry corresponding to the base address and length + of the register space. Can optionally contain a second entry + corresponding to the CRTC gamma LUT address. + +- reg-names: "base" for the base register space. If present, the CRTC + gamma LUT name should be "lut". + - interrupts: should contain a list of all VOP IP block interrupts in the order: VSYNC, LCD_SYSTEM. The interrupt specifier format depends on the interrupt controller used. @@ -48,7 +55,8 @@ Example: SoC specific DT entry: vopb: vopb@ff930000 { compatible = "rockchip,rk3288-vop"; - reg = <0xff930000 0x19c>; + reg = <0x0 0xff930000 0x0 0x19c>, <0x0 0xff931000 0x0 0x1000>; + reg-names = "base", "lut"; interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cru ACLK_VOP0>, <&cru DCLK_VOP0>, <&cru HCLK_VOP0>; clock-names = "aclk_vop", "dclk_vop", "hclk_vop";
Add the register specifier description for an optional gamma LUT address. Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> --- .../bindings/display/rockchip/rockchip-vop.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)