| Message ID | 20190618021820.14885-1-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V15,1/5] dt-bindings: fsl: scu: add thermal binding | expand |
Hi, Daniel/Rui/Eduardo Could you please take a look at this patch series? Anson > From: Anson Huang <Anson.Huang@nxp.com> > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > controller, the system controller is in charge of system power, clock and > thermal sensors etc. management, Linux kernel has to communicate with > system controller via MU (message unit) IPC to get temperature from thermal > sensors, this patch adds binding doc for i.MX system controller thermal > driver. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > Reviewed-by: Rob Herring <robh@kernel.org> > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > No change. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index a575e42..fc3844e 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -155,6 +155,17 @@ Required properties: > Optional properties: > - timeout-sec: contains the watchdog timeout in seconds. > > +Thermal bindings based on SCU Message Protocol > +------------------------------------------------------------ > + > +Required properties: > +- compatible: Should be : > + "fsl,imx8qxp-sc-thermal" > + followed by "fsl,imx-sc-thermal"; > + > +- #thermal-sensor-cells: See > Documentation/devicetree/bindings/thermal/thermal.txt > + for a description. > + > Example (imx8qxp): > ------------- > aliases { > @@ -222,6 +233,11 @@ firmware { > compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt"; > timeout-sec = <60>; > }; > + > + tsens: thermal-sensor { > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc- > thermal"; > + #thermal-sensor-cells = <1>; > + }; > }; > }; > > -- > 2.7.4
Ping... > Hi, Daniel/Rui/Eduardo > Could you please take a look at this patch series? > > Anson > > > From: Anson Huang <Anson.Huang@nxp.com> > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > controller, the system controller is in charge of system power, clock > > and thermal sensors etc. management, Linux kernel has to communicate > > with system controller via MU (message unit) IPC to get temperature > > from thermal sensors, this patch adds binding doc for i.MX system > > controller thermal driver. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > No change. > > --- > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 > ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > index a575e42..fc3844e 100644 > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > @@ -155,6 +155,17 @@ Required properties: > > Optional properties: > > - timeout-sec: contains the watchdog timeout in seconds. > > > > +Thermal bindings based on SCU Message Protocol > > +------------------------------------------------------------ > > + > > +Required properties: > > +- compatible: Should be : > > + "fsl,imx8qxp-sc-thermal" > > + followed by "fsl,imx-sc-thermal"; > > + > > +- #thermal-sensor-cells: See > > Documentation/devicetree/bindings/thermal/thermal.txt > > + for a description. > > + > > Example (imx8qxp): > > ------------- > > aliases { > > @@ -222,6 +233,11 @@ firmware { > > compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt"; > > timeout-sec = <60>; > > }; > > + > > + tsens: thermal-sensor { > > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc- > > thermal"; > > + #thermal-sensor-cells = <1>; > > + }; > > }; > > }; > > > > -- > > 2.7.4
Hi, Anson, We're missing ACK from the maintainers for patch 4/5 and 5/5, if we want to shipped the patch via thermal tree. For patch 2/5, as it introduces a new API for OF_THERMAL, I'd like to get Eduardo' feedback before taking them. thanks, rui On Wed, 2019-07-24 at 03:16 +0000, Anson Huang wrote: > Ping... > > > Hi, Daniel/Rui/Eduardo > > Could you please take a look at this patch series? > > > > Anson > > > > > From: Anson Huang <Anson.Huang@nxp.com> > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > > > system > > > controller, the system controller is in charge of system power, > > > clock > > > and thermal sensors etc. management, Linux kernel has to > > > communicate > > > with system controller via MU (message unit) IPC to get > > > temperature > > > from thermal sensors, this patch adds binding doc for i.MX system > > > controller thermal driver. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> > > > --- > > > No change. > > > --- > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 > > > > ++++++++++++++++ > > > 1 file changed, 16 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > index a575e42..fc3844e 100644 > > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > @@ -155,6 +155,17 @@ Required properties: > > > Optional properties: > > > - timeout-sec: contains the watchdog timeout in seconds. > > > > > > +Thermal bindings based on SCU Message Protocol > > > +------------------------------------------------------------ > > > + > > > +Required properties: > > > +- compatible: Should be : > > > + "fsl,imx8qxp-sc-thermal" > > > + followed by "fsl,imx-sc-thermal"; > > > + > > > +- #thermal-sensor-cells: See > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > + for a description. > > > + > > > Example (imx8qxp): > > > ------------- > > > aliases { > > > @@ -222,6 +233,11 @@ firmware { > > > compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc- > > > wdt"; > > > timeout-sec = <60>; > > > }; > > > + > > > + tsens: thermal-sensor { > > > + compatible = "fsl,imx8qxp-sc-thermal", > > > "fsl,imx-sc- > > > thermal"; > > > + #thermal-sensor-cells = <1>; > > > + }; > > > }; > > > }; > > > > > > -- > > > 2.7.4 > >
Hi, Rui > Subject: Re: [PATCH V15 1/5] dt-bindings: fsl: scu: add thermal binding > > Hi, Anson, > > We're missing ACK from the maintainers for patch 4/5 and 5/5, if we want to > shipped the patch via thermal tree. I think 4/5 and 5/5 can be taken by Shawn Guo once the driver part is taken, he normally do it in this way, once driver and dt-binding are taken, I will notify him. > > For patch 2/5, as it introduces a new API for OF_THERMAL, I'd like to get > Eduardo' feedback before taking them. OK, NOT sure when he can take a look at it, we are kind of pending on this for some time, let's wait. If you have chance to talk to him, please help ask for help from him about this patch series, thanks a lot! thanks, Anson
Ping again, it has been 3 months passed. > Subject: RE: [PATCH V15 1/5] dt-bindings: fsl: scu: add thermal binding > > Ping... > > > Hi, Daniel/Rui/Eduardo > > Could you please take a look at this patch series? > > > > Anson > > > > > From: Anson Huang <Anson.Huang@nxp.com> > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > > controller, the system controller is in charge of system power, > > > clock and thermal sensors etc. management, Linux kernel has to > > > communicate with system controller via MU (message unit) IPC to get > > > temperature from thermal sensors, this patch adds binding doc for > > > i.MX system controller thermal driver. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> > > > --- > > > No change. > > > --- > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 > > ++++++++++++++++ > > > 1 file changed, 16 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > index a575e42..fc3844e 100644 > > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > @@ -155,6 +155,17 @@ Required properties: > > > Optional properties: > > > - timeout-sec: contains the watchdog timeout in seconds. > > > > > > +Thermal bindings based on SCU Message Protocol > > > +------------------------------------------------------------ > > > + > > > +Required properties: > > > +- compatible: Should be : > > > + "fsl,imx8qxp-sc-thermal" > > > + followed by "fsl,imx-sc-thermal"; > > > + > > > +- #thermal-sensor-cells: See > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > + for a description. > > > + > > > Example (imx8qxp): > > > ------------- > > > aliases { > > > @@ -222,6 +233,11 @@ firmware { > > > compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt"; > > > timeout-sec = <60>; > > > }; > > > + > > > + tsens: thermal-sensor { > > > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc- > > > thermal"; > > > + #thermal-sensor-cells = <1>; > > > + }; > > > }; > > > }; > > > > > > -- > > > 2.7.4
Ping.... It has been more than half year, is there anyone can help on thermal sub-system? Anson > Subject: RE: [PATCH V15 1/5] dt-bindings: fsl: scu: add thermal binding > > Ping again, it has been 3 months passed. > > > Subject: RE: [PATCH V15 1/5] dt-bindings: fsl: scu: add thermal > > binding > > > > Ping... > > > > > Hi, Daniel/Rui/Eduardo > > > Could you please take a look at this patch series? > > > > > > Anson > > > > > > > From: Anson Huang <Anson.Huang@nxp.com> > > > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > > > > system controller, the system controller is in charge of system > > > > power, clock and thermal sensors etc. management, Linux kernel has > > > > to communicate with system controller via MU (message unit) IPC to > > > > get temperature from thermal sensors, this patch adds binding doc > > > > for i.MX system controller thermal driver. > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> > > > > --- > > > > No change. > > > > --- > > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 > > > ++++++++++++++++ > > > > 1 file changed, 16 insertions(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > index a575e42..fc3844e 100644 > > > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > @@ -155,6 +155,17 @@ Required properties: > > > > Optional properties: > > > > - timeout-sec: contains the watchdog timeout in seconds. > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > +------------------------------------------------------------ > > > > + > > > > +Required properties: > > > > +- compatible: Should be : > > > > + "fsl,imx8qxp-sc-thermal" > > > > + followed by "fsl,imx-sc-thermal"; > > > > + > > > > +- #thermal-sensor-cells: See > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > + for a description. > > > > + > > > > Example (imx8qxp): > > > > ------------- > > > > aliases { > > > > @@ -222,6 +233,11 @@ firmware { > > > > compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt"; > > > > timeout-sec = <60>; > > > > }; > > > > + > > > > + tsens: thermal-sensor { > > > > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc- > > > > thermal"; > > > > + #thermal-sensor-cells = <1>; > > > > + }; > > > > }; > > > > }; > > > > > > > > -- > > > > 2.7.4
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt index a575e42..fc3844e 100644 --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt @@ -155,6 +155,17 @@ Required properties: Optional properties: - timeout-sec: contains the watchdog timeout in seconds. +Thermal bindings based on SCU Message Protocol +------------------------------------------------------------ + +Required properties: +- compatible: Should be : + "fsl,imx8qxp-sc-thermal" + followed by "fsl,imx-sc-thermal"; + +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt + for a description. + Example (imx8qxp): ------------- aliases { @@ -222,6 +233,11 @@ firmware { compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt"; timeout-sec = <60>; }; + + tsens: thermal-sensor { + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal"; + #thermal-sensor-cells = <1>; + }; }; };