| Message ID | 20190701175900.4034-2-alex@ghiti.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Hugetlbfs support for riscv | expand |
Catalin, Palmer, On Mon, 1 Jul 2019, Alexandre Ghiti wrote: > ARCH_WANT_HUGE_PMD_SHARE config was declared in both architectures: > move this declaration in arch/Kconfig and make those architectures > select it. > > Signed-off-by: Alexandre Ghiti <alex@ghiti.fr> Since the change from v2 to v3 was minor (the removal of the "config ARCH_WANT_HUGE_PMD_SHARE" line from the arm64 port), I'm planning to apply your Reviewed-by:s and acks from https://lore.kernel.org/linux-riscv/20190603172723.GH63283@arrakis.emea.arm.com/ https://lore.kernel.org/linux-riscv/mhng-4d1d4acb-f65f-4ed4-bc86-85a14b7c3e16@palmer-si-x1e/ If there's any objection, please let me know as soon as possible. - Paul
On 2019/7/2 1:58, Alexandre Ghiti wrote: > ARCH_WANT_HUGE_PMD_SHARE config was declared in both architectures: > move this declaration in arch/Kconfig and make those architectures > select it. > > Signed-off-by: Alexandre Ghiti <alex@ghiti.fr> > --- > arch/Kconfig | 3 +++ > arch/arm64/Kconfig | 4 +--- > arch/x86/Kconfig | 4 +--- > 3 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index c47b328eada0..d2f212dc8e72 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -577,6 +577,9 @@ config HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD > config HAVE_ARCH_HUGE_VMAP > bool > > +config ARCH_WANT_HUGE_PMD_SHARE > + bool > + > config HAVE_ARCH_SOFT_DIRTY > bool > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 697ea0510729..c862575decd3 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -71,6 +71,7 @@ config ARM64 > select ARCH_SUPPORTS_NUMA_BALANCING > select ARCH_WANT_COMPAT_IPC_PARSE_VERSION if COMPAT > select ARCH_WANT_FRAME_POINTERS > + select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > select ARCH_HAS_UBSAN_SANITIZE_ALL > select ARM_AMBA > select ARM_ARCH_TIMER > @@ -901,9 +902,6 @@ config HW_PERF_EVENTS > config SYS_SUPPORTS_HUGETLBFS > def_bool y > > -config ARCH_WANT_HUGE_PMD_SHARE > - def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > - Reviewed-by: Hanjun Guo <guohanjun@huawei.com> Thanks Hanjun
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
On 7/1/19 8:51 PM, Paul Walmsley wrote: > Catalin, Palmer, > > On Mon, 1 Jul 2019, Alexandre Ghiti wrote: > >> ARCH_WANT_HUGE_PMD_SHARE config was declared in both architectures: >> move this declaration in arch/Kconfig and make those architectures >> select it. >> >> Signed-off-by: Alexandre Ghiti <alex@ghiti.fr> > Since the change from v2 to v3 was minor (the removal of the "config > ARCH_WANT_HUGE_PMD_SHARE" line from the arm64 port), I'm planning to > apply your Reviewed-by:s and acks from > > https://lore.kernel.org/linux-riscv/20190603172723.GH63283@arrakis.emea.arm.com/ > > https://lore.kernel.org/linux-riscv/mhng-4d1d4acb-f65f-4ed4-bc86-85a14b7c3e16@palmer-si-x1e/ Ingo acked this patch too in that case. Sorry for that, I was unsure if I could add them. Thanks for your answer, Alex > > If there's any objection, please let me know as soon as possible. > > > - Paul
On 7/2/19 3:27 AM, Hanjun Guo wrote: > On 2019/7/2 1:58, Alexandre Ghiti wrote: >> ARCH_WANT_HUGE_PMD_SHARE config was declared in both architectures: >> move this declaration in arch/Kconfig and make those architectures >> select it. >> >> Signed-off-by: Alexandre Ghiti <alex@ghiti.fr> >> --- >> arch/Kconfig | 3 +++ >> arch/arm64/Kconfig | 4 +--- >> arch/x86/Kconfig | 4 +--- >> 3 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/arch/Kconfig b/arch/Kconfig >> index c47b328eada0..d2f212dc8e72 100644 >> --- a/arch/Kconfig >> +++ b/arch/Kconfig >> @@ -577,6 +577,9 @@ config HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD >> config HAVE_ARCH_HUGE_VMAP >> bool >> >> +config ARCH_WANT_HUGE_PMD_SHARE >> + bool >> + >> config HAVE_ARCH_SOFT_DIRTY >> bool >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 697ea0510729..c862575decd3 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -71,6 +71,7 @@ config ARM64 >> select ARCH_SUPPORTS_NUMA_BALANCING >> select ARCH_WANT_COMPAT_IPC_PARSE_VERSION if COMPAT >> select ARCH_WANT_FRAME_POINTERS >> + select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) >> select ARCH_HAS_UBSAN_SANITIZE_ALL >> select ARM_AMBA >> select ARM_ARCH_TIMER >> @@ -901,9 +902,6 @@ config HW_PERF_EVENTS >> config SYS_SUPPORTS_HUGETLBFS >> def_bool y >> >> -config ARCH_WANT_HUGE_PMD_SHARE >> - def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) >> - > Reviewed-by: Hanjun Guo <guohanjun@huawei.com> Thanks for catching the previous mistake again and thanks for that, Alex > > Thanks > Hanjun > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
diff --git a/arch/Kconfig b/arch/Kconfig index c47b328eada0..d2f212dc8e72 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -577,6 +577,9 @@ config HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD config HAVE_ARCH_HUGE_VMAP bool +config ARCH_WANT_HUGE_PMD_SHARE + bool + config HAVE_ARCH_SOFT_DIRTY bool diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 697ea0510729..c862575decd3 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -71,6 +71,7 @@ config ARM64 select ARCH_SUPPORTS_NUMA_BALANCING select ARCH_WANT_COMPAT_IPC_PARSE_VERSION if COMPAT select ARCH_WANT_FRAME_POINTERS + select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) select ARCH_HAS_UBSAN_SANITIZE_ALL select ARM_AMBA select ARM_ARCH_TIMER @@ -901,9 +902,6 @@ config HW_PERF_EVENTS config SYS_SUPPORTS_HUGETLBFS def_bool y -config ARCH_WANT_HUGE_PMD_SHARE - def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) - config ARCH_HAS_CACHE_LINE_SIZE def_bool y diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2bbbd4d1ba31..fa021ec38803 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -93,6 +93,7 @@ config X86 select ARCH_USE_QUEUED_SPINLOCKS select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH select ARCH_WANTS_DYNAMIC_TASK_STRUCT + select ARCH_WANT_HUGE_PMD_SHARE select ARCH_WANTS_THP_SWAP if X86_64 select BUILDTIME_EXTABLE_SORT select CLKEVT_I8253 @@ -301,9 +302,6 @@ config ARCH_HIBERNATION_POSSIBLE config ARCH_SUSPEND_POSSIBLE def_bool y -config ARCH_WANT_HUGE_PMD_SHARE - def_bool y - config ARCH_WANT_GENERAL_HUGETLB def_bool y
ARCH_WANT_HUGE_PMD_SHARE config was declared in both architectures: move this declaration in arch/Kconfig and make those architectures select it. Signed-off-by: Alexandre Ghiti <alex@ghiti.fr> --- arch/Kconfig | 3 +++ arch/arm64/Kconfig | 4 +--- arch/x86/Kconfig | 4 +--- 3 files changed, 5 insertions(+), 6 deletions(-)