| Message ID | 20190601075257.GA24550@jimmy.localdomain (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | bd21f0222adab64974b7d1b4b8c7ce6b23e9ea4d |
| Headers | show |
| Series | Fix chipmunk-like voice when using Logitech C270 for recording audio. | expand |
Hello! On 01.06.2019 10:52, Marco Zatta wrote: > This patch fixes the chipmunk-like voice that manifets randomly when > using the integrated mic of the Logitech Webcam HD C270. > > The issue was solved initially for this device by commit > 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix It's not how you should cite the commits, see below: <12-digit SHA1> ("<summary>") > back. > > Signed-off-by: Marco Zatta <marco@zatta.me> [...] MBR, Sergei
Hi! On Sat, Jun 01, 2019 at 12:33:06PM +0300, Sergei Shtylyov wrote: > Hello! > > On 01.06.2019 10:52, Marco Zatta wrote: > > > This patch fixes the chipmunk-like voice that manifets randomly when > > using the integrated mic of the Logitech Webcam HD C270. > > > > The issue was solved initially for this device by commit > > 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by > > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix > > It's not how you should cite the commits, see below: > > <12-digit SHA1> ("<summary>") > You are right, I am sorry about that. The commits are 2394d67e446bf616a0885167d5f0d397bdacfdfc ("USB: add RESET_RESUME for webcams shown to be quirky") and e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0 ("usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams") > > back. > > > > Signed-off-by: Marco Zatta <marco@zatta.me> > [...] > > MBR, Sergei Best regards, Marco
On Sat, Jun 01, 2019 at 12:11:37PM +0200, Marco Zatta wrote: > Hi! > On Sat, Jun 01, 2019 at 12:33:06PM +0300, Sergei Shtylyov wrote: > > Hello! > > > > On 01.06.2019 10:52, Marco Zatta wrote: > > > > > This patch fixes the chipmunk-like voice that manifets randomly when > > > using the integrated mic of the Logitech Webcam HD C270. > > > > > > The issue was solved initially for this device by commit > > > 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by > > > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix > > > > It's not how you should cite the commits, see below: > > > > <12-digit SHA1> ("<summary>") > > > > You are right, I am sorry about that. The commits are > 2394d67e446bf616a0885167d5f0d397bdacfdfc ("USB: add RESET_RESUME for > webcams shown to be quirky") and > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0 ("usb: Add > USB_QUIRK_RESET_RESUME for all Logitech UVC webcams") No problem, I'll fix this up when applying the patch next week, thanks! greg k-h
Am Samstag, den 01.06.2019, 09:52 +0200 schrieb Marco Zatta: > This patch fixes the chipmunk-like voice that manifets randomly when > using the integrated mic of the Logitech Webcam HD C270. > > The issue was solved initially for this device by commit > 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix > back. Are you sure only the C270 is affected? Regards Oliver
On Mon, Jun 03, 2019 at 11:58:10AM +0200, Oliver Neukum wrote: > Are you sure only the C270 is affected? > > Regards > Oliver > Hello Oliver, No, unfortunately I am not sure but I am missing the hardware to properly test. I am quite sure that it fixes the problem in the C270 though :) Thanks for that, since you were the author of the first commit. Bests, Marco
Am Montag, den 03.06.2019, 19:55 +0200 schrieb Marco Zatta: > On Mon, Jun 03, 2019 at 11:58:10AM +0200, Oliver Neukum wrote: > > Are you sure only the C270 is affected? > > > > Regards > > Oliver > > Hello Oliver, > > No, unfortunately I am not sure but I am missing the hardware to > properly test. I am quite sure that it fixes the problem in the C270 > though :) Well, after all that time neither do I have the test hardware. And I doubt that for some reason only the C270 should be affected. > Thanks for that, since you were the author of the first commit. I appreciate your patch, but I think teh safe option would be to do it for all models. Regards Oliver PS: Are you really in Montenegro or is that just a close address?
On Tue, Jun 04, 2019 at 11:14:37AM +0200, Oliver Neukum wrote: > Am Montag, den 03.06.2019, 19:55 +0200 schrieb Marco Zatta: > > On Mon, Jun 03, 2019 at 11:58:10AM +0200, Oliver Neukum wrote: > > > Are you sure only the C270 is affected? > > > > > > Regards > > > Oliver > > > > Hello Oliver, > > > > No, unfortunately I am not sure but I am missing the hardware to > > properly test. I am quite sure that it fixes the problem in the C270 > > though :) > > Well, after all that time neither do I have the test hardware. > And I doubt that for some reason only the C270 should be affected. > > > Thanks for that, since you were the author of the first commit. > > I appreciate your patch, but I think teh safe option would be to do > it for all models. As we don't have anyone else complaining at the moment, let's just take this patch as-for now. thanks, greg k-h
On Mon, Jun 3, 2019 at 12:46 PM Oliver Neukum <oneukum@suse.com> wrote: > > Am Samstag, den 01.06.2019, 09:52 +0200 schrieb Marco Zatta: > > This patch fixes the chipmunk-like voice that manifets randomly when > > using the integrated mic of the Logitech Webcam HD C270. > > > > The issue was solved initially for this device by commit > > 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by > > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix > > back. > > Are you sure only the C270 is affected? I can unfortunately confirm that it doesn't just seem to be the C270. I've been having the same problem with my Logitech Webcam Pro 9000 which was one of the models that 2394d67e446b applied the RESET_RESUME quirk to, and adding it to the quirks list appears to have solved the problem. This doesn't make much sense though. e387ef5c47dd should apply this quirk to all Logitech UVC webcams, and this is definitely a UVC-based Logitech webcam with the appropriate VID and interface descriptor. Surely it shouldn't make any difference whether I add an entry for the specific VID+PID pair of my particular camera or not? The C270 is as well, I think. What's particularly annoying is that since this is an intermittent problem, it's hard to tell if I'm chasing a phantom solution for it again. Haven't managed to replicate it since applying this fix and did so pretty quickly before but you never know.
Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton: > This doesn't make much sense though. e387ef5c47dd should apply this > quirk to all Logitech UVC webcams, and this is definitely a UVC-based > Logitech webcam with the appropriate VID and interface descriptor. > Surely it shouldn't make any difference whether I add an entry for the > specific VID+PID pair of my particular camera or not? The C270 is as > well, I think. Well, it is applied a little later. > What's particularly annoying is that since this is an intermittent > problem, it's hard to tell if I'm chasing a phantom solution for it > again. Haven't managed to replicate it since applying this fix and did > so pretty quickly before but you never know. Should I just readd everything removed in e387ef5c47dd? Greg, what do you think? This is hard to test, the hardware is old and I want to avoid chasing them all separately. Regards Oliver
On Tue, Jul 02, 2019 at 02:46:42PM +0200, Oliver Neukum wrote: > Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton: > > > This doesn't make much sense though. e387ef5c47dd should apply this > > quirk to all Logitech UVC webcams, and this is definitely a UVC-based > > Logitech webcam with the appropriate VID and interface descriptor. > > Surely it shouldn't make any difference whether I add an entry for the > > specific VID+PID pair of my particular camera or not? The C270 is as > > well, I think. > > Well, it is applied a little later. > > > What's particularly annoying is that since this is an intermittent > > problem, it's hard to tell if I'm chasing a phantom solution for it > > again. Haven't managed to replicate it since applying this fix and did > > so pretty quickly before but you never know. > > Should I just readd everything removed in e387ef5c47dd? > > Greg, what do you think? This is hard to test, the hardware is old > and I want to avoid chasing them all separately. It's up to you, if you think the issue is resolved if we readd everything, that's fine with me. thanks, greg k-h
Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton: > What's particularly annoying is that since this is an intermittent > problem, it's hard to tell if I'm chasing a phantom solution for it > again. Haven't managed to replicate it since applying this fix and did > so pretty quickly before but you never know. > This is time for the sledge hammer. No more surgical solutions. Could you test the attached patch? Regards Oliver
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 6082b008969b..6b6413073584 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -215,6 +215,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* Cherry Stream G230 2.0 (G85-231) and 3.0 (G85-232) */ { USB_DEVICE(0x046a, 0x0023), .driver_info = USB_QUIRK_RESET_RESUME }, + /* Logitech HD Webcam C270 */ + { USB_DEVICE(0x046d, 0x0825), .driver_info = USB_QUIRK_RESET_RESUME }, + /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */ { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT }, { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
This patch fixes the chipmunk-like voice that manifets randomly when using the integrated mic of the Logitech Webcam HD C270. The issue was solved initially for this device by commit 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix back. Signed-off-by: Marco Zatta <marco@zatta.me> --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+)