diff mbox series

[1/3] drm/bridge: ti-sn65dsi86: add link to datasheet

Message ID 20190702154419.20812-2-robdclark@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show
Series drm/bridge: ti-sn65dsi86: debugfs and mode_flags fix | expand

Commit Message

Rob Clark July 2, 2019, 3:44 p.m. UTC 
From: Rob Clark <robdclark@chromium.org>

The bridge has pretty good docs, lets add a link to make them easier to
find.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jeffrey Hugo July 2, 2019, 5:03 p.m. UTC | #1 
On Tue, Jul 2, 2019 at 9:45 AM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> The bridge has pretty good docs, lets add a link to make them easier to
> find.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>

This is in the DT binding, but having it in the driver as well is a nice touch.

Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Andrzej Hajda July 4, 2019, 12:26 p.m. UTC | #2 
On 02.07.2019 17:44, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> The bridge has pretty good docs, lets add a link to make them easier to
> find.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>


Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

 --
Regards
Andrzej


> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index bcca9173c72a..f1a2493b86d9 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1,6 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
>   * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> + * datasheet: http://www.ti.com/lit/ds/symlink/sn65dsi86.pdf
>   */
>  
>  #include <linux/clk.h>
Laurent Pinchart July 4, 2019, 12:32 p.m. UTC | #3 
Hi Rob,

Thank you for the patch.

On Tue, Jul 02, 2019 at 08:44:16AM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> The bridge has pretty good docs, lets add a link to make them easier to
> find.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index bcca9173c72a..f1a2493b86d9 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1,6 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
>   * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> + * datasheet: http://www.ti.com/lit/ds/symlink/sn65dsi86.pdf

It's in the DT bindings and it's easy to find so I'm not sure it adds
lots of value to mention it here, but I don't feel very strongly about
it, so if you think it can be useful I don't mind. I would however put a
blank line after the copyright line in that case, and
s/datasheet/Datasheet/

>   */
>  
>  #include <linux/clk.h>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index bcca9173c72a..f1a2493b86d9 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -1,6 +1,7 @@ 
 // SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ * datasheet: http://www.ti.com/lit/ds/symlink/sn65dsi86.pdf
  */
 
 #include <linux/clk.h>