| Message ID | 20190706150738.4619-1-carmeli.tamir@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | security/commoncap: Use xattr security prefix len | expand |
On Sat, 6 Jul 2019, Carmeli Tamir wrote: > Using the existing defined XATTR_SECURITY_PREFIX_LEN instead of > sizeof(XATTR_SECURITY_PREFIX) - 1. Pretty simple cleanup. > > Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com> Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-lsm Thanks!
diff --git a/security/commoncap.c b/security/commoncap.c index c0b9664ee49e..99d1fcae22fd 100644 --- a/security/commoncap.c +++ b/security/commoncap.c @@ -915,7 +915,7 @@ int cap_inode_setxattr(struct dentry *dentry, const char *name, /* Ignore non-security xattrs */ if (strncmp(name, XATTR_SECURITY_PREFIX, - sizeof(XATTR_SECURITY_PREFIX) - 1) != 0) + XATTR_SECURITY_PREFIX_LEN) != 0) return 0; /* @@ -947,7 +947,7 @@ int cap_inode_removexattr(struct dentry *dentry, const char *name) /* Ignore non-security xattrs */ if (strncmp(name, XATTR_SECURITY_PREFIX, - sizeof(XATTR_SECURITY_PREFIX) - 1) != 0) + XATTR_SECURITY_PREFIX_LEN) != 0) return 0; if (strcmp(name, XATTR_NAME_CAPS) == 0) {
Using the existing defined XATTR_SECURITY_PREFIX_LEN instead of sizeof(XATTR_SECURITY_PREFIX) - 1. Pretty simple cleanup. Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com> --- security/commoncap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)