| Message ID | 20190401171724.215780-1-dianders@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/panel: simple: Add mode support to devicetree | expand |
Am Montag, 1. April 2019, 19:17:17 CEST schrieb Douglas Anderson: > I'm reviving Sean Paul's old patchset to get mode support in device > tree. The cover letter for his v3 is at: > https://lists.freedesktop.org/archives/dri-devel/2018-February/165162.html > > No code is different between v4 and v5, just commit messages and text > in the bindings. > > I've pulled together the patches that didn't land in v3, addressed > outstanding feedback, and reposted. Atop them I've added patches for > rk3288-veyron-chromebook (used for jaq, jerry, mighty, speedy) and > rk3288-veryon-minnie. > > Please let me know how they look. > > In general I have added people to the whole series who I think would > like the whole series and then let get_maintainer pick extra people it > thinks are relevant to each individual patch. If I see you respond to > any of the patches in the series, though, I'll add you to the whole > series Cc list next time. sadly it looks like the panel-simple parts haven't made it into drm-misc yet and the conversation on patch 1/7 seems to have stalled after Doug's replies. Thierry, do you have an opinion on these? Thanks Heiko > Changes in v5: > - Removed bit about OS may ignore (Rob/Ezequiel) > - Added Heiko's Tested-by > - It's not just jerry, it's most rk3288 Chromebooks (Heiko) > > Changes in v4: > - Simplify desc. for when override should be used (Thierry/Laurent) > - Removed Rob H review since it's been a year and wording changed > - Don't add mode from timing if override was specified (Thierry) > - Add warning if timing and fixed mode was specified (Thierry) > - Don't add fixed mode if timing was specified (Thierry) > - Refactor/rename a bit to avoid extra indentation from "if" tests > - i should be unsigned (Thierry) > - Add annoying WARN_ONs for some cases (Thierry) > - Simplify 'No display_timing found' handling (Thierry) > - Rename to panel_simple_parse_override_mode() (Thierry) > - Rebase to top of Heiko's tree > - Converted changelog to after-the-cut for non-DRM change. > - display_timing for Innolux n116bge new for v4. > - display_timing for AUO b101ean01 new for v4. > - rk3288-veyron-jerry patch new for v4. > - rk3288-veyron-minnie patch new for v4. > > Changes in v3: > - Go back to using the timing subnode directly, but rename to > panel-timing (Rob) > - No longer parse display-timings subnode, use panel-timing (Rob) > - Unwrap the timing from display-timings and rename panel-timing (Rob) > > Changes in v2: > - Split out the binding into a new patch (Rob) > - display-timings is a new section (Rob) > - Use the full display-timings subnode instead of picking the timing > out (Rob/Thierry) > - Parse the full display-timings node (using the native-mode) (Rob) > - Wrap the timing in display-timings node to match binding (Rob/Thierry) > > Douglas Anderson (4): > drm/panel: simple: Use display_timing for Innolux n116bge > drm/panel: simple: Use display_timing for AUO b101ean01 > ARM: dts: rockchip: Specify rk3288-veyron-chromebook's display timings > ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings > > Sean Paul (3): > dt-bindings: Add panel-timing subnode to simple-panel > drm/panel: simple: Add ability to override typical timing > arm64: dts: rockchip: Specify override mode for kevin panel > > .../bindings/display/panel/simple-panel.txt | 22 +++ > .../boot/dts/rk3288-veyron-chromebook.dtsi | 14 ++ > arch/arm/boot/dts/rk3288-veyron-minnie.dts | 14 ++ > .../boot/dts/rockchip/rk3399-gru-kevin.dts | 14 ++ > drivers/gpu/drm/panel/panel-simple.c | 171 ++++++++++++++---- > 5 files changed, 203 insertions(+), 32 deletions(-) > >
Hi Douglas. On Mon, Apr 01, 2019 at 10:17:17AM -0700, Douglas Anderson wrote: > I'm reviving Sean Paul's old patchset to get mode support in device > tree. The cover letter for his v3 is at: > https://lists.freedesktop.org/archives/dri-devel/2018-February/165162.html > > No code is different between v4 and v5, just commit messages and text > in the bindings. > > I've pulled together the patches that didn't land in v3, addressed > outstanding feedback, and reposted. Atop them I've added patches for > rk3288-veyron-chromebook (used for jaq, jerry, mighty, speedy) and > rk3288-veryon-minnie. > > Please let me know how they look. > > In general I have added people to the whole series who I think would > like the whole series and then let get_maintainer pick extra people it > thinks are relevant to each individual patch. If I see you respond to > any of the patches in the series, though, I'll add you to the whole > series Cc list next time. > > Changes in v5: > - Removed bit about OS may ignore (Rob/Ezequiel) > - Added Heiko's Tested-by > - It's not just jerry, it's most rk3288 Chromebooks (Heiko) What are the plans to move forward with this? Or did you drop the whole idea again? Sam
Hi, On Wed, Jun 26, 2019 at 6:00 AM Sam Ravnborg <sam@ravnborg.org> wrote: > > Hi Douglas. > > On Mon, Apr 01, 2019 at 10:17:17AM -0700, Douglas Anderson wrote: > > I'm reviving Sean Paul's old patchset to get mode support in device > > tree. The cover letter for his v3 is at: > > https://lists.freedesktop.org/archives/dri-devel/2018-February/165162.html > > > > No code is different between v4 and v5, just commit messages and text > > in the bindings. > > > > I've pulled together the patches that didn't land in v3, addressed > > outstanding feedback, and reposted. Atop them I've added patches for > > rk3288-veyron-chromebook (used for jaq, jerry, mighty, speedy) and > > rk3288-veryon-minnie. > > > > Please let me know how they look. > > > > In general I have added people to the whole series who I think would > > like the whole series and then let get_maintainer pick extra people it > > thinks are relevant to each individual patch. If I see you respond to > > any of the patches in the series, though, I'll add you to the whole > > series Cc list next time. > > > > Changes in v5: > > - Removed bit about OS may ignore (Rob/Ezequiel) > > - Added Heiko's Tested-by > > - It's not just jerry, it's most rk3288 Chromebooks (Heiko) > > What are the plans to move forward with this? > Or did you drop the whole idea again? At the moment I'm blocked on Thierry responding, either taking the patch or telling me what I need to do to fix it. I saw Sean Paul ping Thierry on IRC on June 3rd and as far as I could tell there was no response. https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel&highlight_names=&date=2019-06-03&show_html=true ...and as you can see Heiko pinged this thread on June 14th. Thierry: can you help give us some direction? Are you uninterested in reviewing them and would prefer that I find someone to land them in drm-misc directly? -Doug
Hi, On Wed, Jun 26, 2019 at 7:41 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Wed, Jun 26, 2019 at 6:00 AM Sam Ravnborg <sam@ravnborg.org> wrote: > > > > Hi Douglas. > > > > On Mon, Apr 01, 2019 at 10:17:17AM -0700, Douglas Anderson wrote: > > > I'm reviving Sean Paul's old patchset to get mode support in device > > > tree. The cover letter for his v3 is at: > > > https://lists.freedesktop.org/archives/dri-devel/2018-February/165162.html > > > > > > No code is different between v4 and v5, just commit messages and text > > > in the bindings. > > > > > > I've pulled together the patches that didn't land in v3, addressed > > > outstanding feedback, and reposted. Atop them I've added patches for > > > rk3288-veyron-chromebook (used for jaq, jerry, mighty, speedy) and > > > rk3288-veryon-minnie. > > > > > > Please let me know how they look. > > > > > > In general I have added people to the whole series who I think would > > > like the whole series and then let get_maintainer pick extra people it > > > thinks are relevant to each individual patch. If I see you respond to > > > any of the patches in the series, though, I'll add you to the whole > > > series Cc list next time. > > > > > > Changes in v5: > > > - Removed bit about OS may ignore (Rob/Ezequiel) > > > - Added Heiko's Tested-by > > > - It's not just jerry, it's most rk3288 Chromebooks (Heiko) > > > > What are the plans to move forward with this? > > Or did you drop the whole idea again? > > At the moment I'm blocked on Thierry responding, either taking the > patch or telling me what I need to do to fix it. I saw Sean Paul ping > Thierry on IRC on June 3rd and as far as I could tell there was no > response. > > https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel&highlight_names=&date=2019-06-03&show_html=true > > ...and as you can see Heiko pinged this thread on June 14th. > > Thierry: can you help give us some direction? Are you uninterested in > reviewing them and would prefer that I find someone to land them in > drm-misc directly? Sam: Oh! I hadn't noticed that you've been added as a panel maintainer in commit ef0db94f94a0 ("MAINTAINERS: Add Sam as reviewer for drm/panel"). Does that mean you are able to provide some advice for how to land this series? As far as I know everything is in order for it to land, but if you are aware of something I need to do to spin it then please let me know! Thanks! -Doug
On Fri, Jun 28, 2019 at 9:55 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Wed, Jun 26, 2019 at 7:41 AM Doug Anderson <dianders@chromium.org> wrote: > > > > Hi, > > > > On Wed, Jun 26, 2019 at 6:00 AM Sam Ravnborg <sam@ravnborg.org> wrote: > > > > > > Hi Douglas. > > > > > > On Mon, Apr 01, 2019 at 10:17:17AM -0700, Douglas Anderson wrote: > > > > I'm reviving Sean Paul's old patchset to get mode support in device > > > > tree. The cover letter for his v3 is at: > > > > https://lists.freedesktop.org/archives/dri-devel/2018-February/165162.html > > > > > > > > No code is different between v4 and v5, just commit messages and text > > > > in the bindings. > > > > > > > > I've pulled together the patches that didn't land in v3, addressed > > > > outstanding feedback, and reposted. Atop them I've added patches for > > > > rk3288-veyron-chromebook (used for jaq, jerry, mighty, speedy) and > > > > rk3288-veryon-minnie. > > > > > > > > Please let me know how they look. > > > > > > > > In general I have added people to the whole series who I think would > > > > like the whole series and then let get_maintainer pick extra people it > > > > thinks are relevant to each individual patch. If I see you respond to > > > > any of the patches in the series, though, I'll add you to the whole > > > > series Cc list next time. > > > > > > > > Changes in v5: > > > > - Removed bit about OS may ignore (Rob/Ezequiel) > > > > - Added Heiko's Tested-by > > > > - It's not just jerry, it's most rk3288 Chromebooks (Heiko) > > > > > > What are the plans to move forward with this? > > > Or did you drop the whole idea again? > > > > At the moment I'm blocked on Thierry responding, either taking the > > patch or telling me what I need to do to fix it. I saw Sean Paul ping > > Thierry on IRC on June 3rd and as far as I could tell there was no > > response. > > > > https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel&highlight_names=&date=2019-06-03&show_html=true > > > > ...and as you can see Heiko pinged this thread on June 14th. > > > > Thierry: can you help give us some direction? Are you uninterested in > > reviewing them and would prefer that I find someone to land them in > > drm-misc directly? > > Sam: Oh! I hadn't noticed that you've been added as a panel > maintainer in commit ef0db94f94a0 ("MAINTAINERS: Add Sam as reviewer > for drm/panel"). Does that mean you are able to provide some advice > for how to land this series? As far as I know everything is in order > for it to land, but if you are aware of something I need to do to spin > it then please let me know! BTW, at least for the binding, this will get implicitly supported in the schema conversion[1] as simple-panel as a binding is gone and panel-common already had timing node defined. A schema for the timing node is still needed though (hint :) ). Rob [1] https://patchwork.ozlabs.org/patch/1121538/
Hi Doug. > Sam: Oh! I hadn't noticed that you've been added as a panel > maintainer in commit ef0db94f94a0 ("MAINTAINERS: Add Sam as reviewer > for drm/panel"). Does that mean you are able to provide some advice > for how to land this series? Reviewer only, not maintainer.... It is on my TODO list for the weekend to go through the patch set in details and provide feedback. I have read them before, but I miss to do a more detailed read through. But I cannot apply this unless Thierry or one of the DRM maintainers ack it. We simply need someone with a better general knowledge of DRM to ack it than I have. Sam
Hi Sam, Am Freitag, 28. Juni 2019, 19:13:42 CEST schrieb Sam Ravnborg: > Hi Doug. > > > Sam: Oh! I hadn't noticed that you've been added as a panel > > maintainer in commit ef0db94f94a0 ("MAINTAINERS: Add Sam as reviewer > > for drm/panel"). Does that mean you are able to provide some advice > > for how to land this series? > Reviewer only, not maintainer.... > > It is on my TODO list for the weekend to go through the patch set in > details and provide feedback. I have read them before, but I miss to do > a more detailed read through. > > But I cannot apply this unless Thierry or one of the DRM maintainers > ack it. > We simply need someone with a better general knowledge of DRM to ack it > than I have. So Thierry was able to look at the patches yesterday it seems and has Acked all the relevant ones. As a drm-misc-contributor I could also apply them myself, but now don't want to preempt any additional comments you might have ;-) . So I guess my question would be if you still want to do a review or if I should apply them. In any case, I'd like to take the actual dts patches (patches 3+6+7 if I'm not mistaken) through my tree up to arm-soc after the fact, to prevent conflicts. Thanks Heiko
Hi Sam, On Sat, Jun 29, 2019 at 7:09 AM Heiko Stübner <heiko@sntech.de> wrote: > > Hi Sam, > > Am Freitag, 28. Juni 2019, 19:13:42 CEST schrieb Sam Ravnborg: > > Hi Doug. > > > > > Sam: Oh! I hadn't noticed that you've been added as a panel > > > maintainer in commit ef0db94f94a0 ("MAINTAINERS: Add Sam as reviewer > > > for drm/panel"). Does that mean you are able to provide some advice > > > for how to land this series? > > Reviewer only, not maintainer.... > > > > It is on my TODO list for the weekend to go through the patch set in > > details and provide feedback. I have read them before, but I miss to do > > a more detailed read through. > > > > But I cannot apply this unless Thierry or one of the DRM maintainers > > ack it. > > We simply need someone with a better general knowledge of DRM to ack it > > than I have. > > So Thierry was able to look at the patches yesterday it seems and has Acked > all the relevant ones. As a drm-misc-contributor I could also apply them > myself, but now don't want to preempt any additional comments you might > have ;-) . So I guess my question would be if you still want to do a review > or if I should apply them. Hopefully you saw, but I responded to all of your review feedback. In the end, I thought it'd be OK to land the series as-is and I can fix up nits in a follow-up series, though I'm waiting for your responses to a couple questions first. It would be ideal if you could confirm that you're OK with this plan even if you don't have time to respond in detail to my emails yet. I think Heiko can land them all through the appropriate channels since the patches have all the proper Acks. Thanks! -Doug
Hi Dough. > > So Thierry was able to look at the patches yesterday it seems and has Acked > > all the relevant ones. As a drm-misc-contributor I could also apply them > > myself, but now don't want to preempt any additional comments you might > > have ;-) . So I guess my question would be if you still want to do a review > > or if I should apply them. > > Hopefully you saw, but I responded to all of your review feedback. In > the end, I thought it'd be OK to land the series as-is and I can fix > up nits in a follow-up series, though I'm waiting for your responses > to a couple questions first. > > It would be ideal if you could confirm that you're OK with this plan > even if you don't have time to respond in detail to my emails yet. I > think Heiko can land them all through the appropriate channels since > the patches have all the proper Acks. My main concern was the bug cocerning override_mode - which turned out to be me confused. There is one part about flags that does not yet makes sense but we can fix it later. Please resend a series that applies to drm-misc-next so we can land this. Sam