| Message ID | 20190708161423.31006-1-efremov@linux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sunrpc/cache: remove the exporting of cache_seq_next | expand |
Makes sense, thanks; apply for 5.3.--b. On Mon, Jul 08, 2019 at 07:14:23PM +0300, Denis Efremov wrote: > The function cache_seq_next is declared static and marked > EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the > function is not used outside of the net/sunrpc/cache.c file it is > defined in, this commit removes the EXPORT_SYMBOL_GPL() marking. > > Fixes: d48cf356a130 ("SUNRPC: Remove non-RCU protected lookup") > Signed-off-by: Denis Efremov <efremov@linux.com> > --- > net/sunrpc/cache.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c > index 66fbb9d2fba7..6f1528f271ee 100644 > --- a/net/sunrpc/cache.c > +++ b/net/sunrpc/cache.c > @@ -1375,7 +1375,6 @@ static void *cache_seq_next(struct seq_file *m, void *p, loff_t *pos) > hlist_first_rcu(&cd->hash_table[hash])), > struct cache_head, cache_list); > } > -EXPORT_SYMBOL_GPL(cache_seq_next); > > void *cache_seq_start_rcu(struct seq_file *m, loff_t *pos) > __acquires(RCU) > -- > 2.21.0
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c index 66fbb9d2fba7..6f1528f271ee 100644 --- a/net/sunrpc/cache.c +++ b/net/sunrpc/cache.c @@ -1375,7 +1375,6 @@ static void *cache_seq_next(struct seq_file *m, void *p, loff_t *pos) hlist_first_rcu(&cd->hash_table[hash])), struct cache_head, cache_list); } -EXPORT_SYMBOL_GPL(cache_seq_next); void *cache_seq_start_rcu(struct seq_file *m, loff_t *pos) __acquires(RCU)
The function cache_seq_next is declared static and marked EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the function is not used outside of the net/sunrpc/cache.c file it is defined in, this commit removes the EXPORT_SYMBOL_GPL() marking. Fixes: d48cf356a130 ("SUNRPC: Remove non-RCU protected lookup") Signed-off-by: Denis Efremov <efremov@linux.com> --- net/sunrpc/cache.c | 1 - 1 file changed, 1 deletion(-)