| Message ID | 20190711110340.16672-1-vivek.gautam@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] soc: qcom: llcc: Rename llcc-sdm845 to llcc-plat | expand |
On Thu 11 Jul 04:03 PDT 2019, Vivek Gautam wrote: > To avoid adding files for each future supported SoCs rename > the file to a generic name - llcc-plat, so that llcc configuration > tables for other SoCs can be added in the same driver. > We've had a generic LLCC Kconfig option and then a specific SDM845 one, with this change we have two different generic options and both would either always be enabled or disabled. So I think you should drop QCOM_SDM845_LLCC and build both llcc-slice and llcc-plat into the same qcom_llcc.ko instead. Regards, Bjorn > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- > drivers/soc/qcom/Kconfig | 10 +++++----- > drivers/soc/qcom/Makefile | 2 +- > drivers/soc/qcom/{llcc-sdm845.c => llcc-plat.c} | 0 > 3 files changed, 6 insertions(+), 6 deletions(-) > rename drivers/soc/qcom/{llcc-sdm845.c => llcc-plat.c} (100%) > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index a6d1bfb17279..8110d415b18e 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -62,13 +62,13 @@ config QCOM_LLCC > to clients that use the LLCC. Say yes here to enable LLCC slice > driver. > > -config QCOM_SDM845_LLCC > - tristate "Qualcomm Technologies, Inc. SDM845 LLCC driver" > +config QCOM_PLAT_LLCC > + tristate "Qualcomm Technologies, Inc. platform LLCC driver" > depends on QCOM_LLCC > help > - Say yes here to enable the LLCC driver for SDM845. This provides > - data required to configure LLCC so that clients can start using the > - LLCC slices. > + Say yes here to enable the LLCC driver for Qcom platforms, such as > + SDM845. This provides data required to configure LLCC so that > + clients can start using the LLCC slices. > > config QCOM_MDT_LOADER > tristate > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index eeb088beb15f..3bf26667d7ee 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -21,6 +21,6 @@ obj-$(CONFIG_QCOM_SMSM) += smsm.o > obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o > obj-$(CONFIG_QCOM_APR) += apr.o > obj-$(CONFIG_QCOM_LLCC) += llcc-slice.o > -obj-$(CONFIG_QCOM_SDM845_LLCC) += llcc-sdm845.o > +obj-$(CONFIG_QCOM_PLAT_LLCC) += llcc-plat.o > obj-$(CONFIG_QCOM_RPMHPD) += rpmhpd.o > obj-$(CONFIG_QCOM_RPMPD) += rpmpd.o > diff --git a/drivers/soc/qcom/llcc-sdm845.c b/drivers/soc/qcom/llcc-plat.c > similarity index 100% > rename from drivers/soc/qcom/llcc-sdm845.c > rename to drivers/soc/qcom/llcc-plat.c > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >
On Thu, Jul 11, 2019 at 9:19 PM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Thu 11 Jul 04:03 PDT 2019, Vivek Gautam wrote: > > > To avoid adding files for each future supported SoCs rename > > the file to a generic name - llcc-plat, so that llcc configuration > > tables for other SoCs can be added in the same driver. > > > > We've had a generic LLCC Kconfig option and then a specific SDM845 one, > with this change we have two different generic options and both would > either always be enabled or disabled. > > So I think you should drop QCOM_SDM845_LLCC and build both llcc-slice > and llcc-plat into the same qcom_llcc.ko instead. Yea. I can chuck off the llcc-slice module. But for readability would it still be better to maintain separate files. I will drop the SDM845 config, and keep only QCOM_LLC. Best regards Vivek > > Regards, > Bjorn > > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > > --- > > drivers/soc/qcom/Kconfig | 10 +++++----- > > drivers/soc/qcom/Makefile | 2 +- > > drivers/soc/qcom/{llcc-sdm845.c => llcc-plat.c} | 0 > > 3 files changed, 6 insertions(+), 6 deletions(-) > > rename drivers/soc/qcom/{llcc-sdm845.c => llcc-plat.c} (100%) > > > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > > index a6d1bfb17279..8110d415b18e 100644 > > --- a/drivers/soc/qcom/Kconfig > > +++ b/drivers/soc/qcom/Kconfig > > @@ -62,13 +62,13 @@ config QCOM_LLCC > > to clients that use the LLCC. Say yes here to enable LLCC slice > > driver. > > > > -config QCOM_SDM845_LLCC > > - tristate "Qualcomm Technologies, Inc. SDM845 LLCC driver" > > +config QCOM_PLAT_LLCC > > + tristate "Qualcomm Technologies, Inc. platform LLCC driver" > > depends on QCOM_LLCC > > help > > - Say yes here to enable the LLCC driver for SDM845. This provides > > - data required to configure LLCC so that clients can start using the > > - LLCC slices. > > + Say yes here to enable the LLCC driver for Qcom platforms, such as > > + SDM845. This provides data required to configure LLCC so that > > + clients can start using the LLCC slices. > > > > config QCOM_MDT_LOADER > > tristate > > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > > index eeb088beb15f..3bf26667d7ee 100644 > > --- a/drivers/soc/qcom/Makefile > > +++ b/drivers/soc/qcom/Makefile > > @@ -21,6 +21,6 @@ obj-$(CONFIG_QCOM_SMSM) += smsm.o > > obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o > > obj-$(CONFIG_QCOM_APR) += apr.o > > obj-$(CONFIG_QCOM_LLCC) += llcc-slice.o > > -obj-$(CONFIG_QCOM_SDM845_LLCC) += llcc-sdm845.o > > +obj-$(CONFIG_QCOM_PLAT_LLCC) += llcc-plat.o > > obj-$(CONFIG_QCOM_RPMHPD) += rpmhpd.o > > obj-$(CONFIG_QCOM_RPMPD) += rpmpd.o > > diff --git a/drivers/soc/qcom/llcc-sdm845.c b/drivers/soc/qcom/llcc-plat.c > > similarity index 100% > > rename from drivers/soc/qcom/llcc-sdm845.c > > rename to drivers/soc/qcom/llcc-plat.c > > -- > > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > > of Code Aurora Forum, hosted by The Linux Foundation > >
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index a6d1bfb17279..8110d415b18e 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -62,13 +62,13 @@ config QCOM_LLCC to clients that use the LLCC. Say yes here to enable LLCC slice driver. -config QCOM_SDM845_LLCC - tristate "Qualcomm Technologies, Inc. SDM845 LLCC driver" +config QCOM_PLAT_LLCC + tristate "Qualcomm Technologies, Inc. platform LLCC driver" depends on QCOM_LLCC help - Say yes here to enable the LLCC driver for SDM845. This provides - data required to configure LLCC so that clients can start using the - LLCC slices. + Say yes here to enable the LLCC driver for Qcom platforms, such as + SDM845. This provides data required to configure LLCC so that + clients can start using the LLCC slices. config QCOM_MDT_LOADER tristate diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile index eeb088beb15f..3bf26667d7ee 100644 --- a/drivers/soc/qcom/Makefile +++ b/drivers/soc/qcom/Makefile @@ -21,6 +21,6 @@ obj-$(CONFIG_QCOM_SMSM) += smsm.o obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o obj-$(CONFIG_QCOM_APR) += apr.o obj-$(CONFIG_QCOM_LLCC) += llcc-slice.o -obj-$(CONFIG_QCOM_SDM845_LLCC) += llcc-sdm845.o +obj-$(CONFIG_QCOM_PLAT_LLCC) += llcc-plat.o obj-$(CONFIG_QCOM_RPMHPD) += rpmhpd.o obj-$(CONFIG_QCOM_RPMPD) += rpmpd.o diff --git a/drivers/soc/qcom/llcc-sdm845.c b/drivers/soc/qcom/llcc-plat.c similarity index 100% rename from drivers/soc/qcom/llcc-sdm845.c rename to drivers/soc/qcom/llcc-plat.c
To avoid adding files for each future supported SoCs rename the file to a generic name - llcc-plat, so that llcc configuration tables for other SoCs can be added in the same driver. Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> --- drivers/soc/qcom/Kconfig | 10 +++++----- drivers/soc/qcom/Makefile | 2 +- drivers/soc/qcom/{llcc-sdm845.c => llcc-plat.c} | 0 3 files changed, 6 insertions(+), 6 deletions(-) rename drivers/soc/qcom/{llcc-sdm845.c => llcc-plat.c} (100%)