mbox series

[0/2] Staging: fbtft: Fix probing of gpio descriptor

Message ID 1562833913-10510-1-git-send-email-preid@electromag.com.au (mailing list archive)
Headers show
Series Staging: fbtft: Fix probing of gpio descriptor | expand

Message

Phil Reid July 11, 2019, 8:31 a.m. UTC
GPIO probing and reset polarity are broken.
Fix them.

Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")

Phil Reid (2):
  Staging: fbtft: Fix probing of gpio descriptor
  Staging: fbtft: Fix reset assertion when using gpio descriptor

 drivers/staging/fbtft/fbtft-core.c | 43 ++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 23 deletions(-)

Comments

Nicolas Saenz Julienne July 15, 2019, 2:27 p.m. UTC | #1
On Thu, 2019-07-11 at 16:31 +0800, Phil Reid wrote:
> GPIO probing and reset polarity are broken.
> Fix them.
> 
> Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> interface")
> 
> Phil Reid (2):
>   Staging: fbtft: Fix probing of gpio descriptor
>   Staging: fbtft: Fix reset assertion when using gpio descriptor
> 
>  drivers/staging/fbtft/fbtft-core.c | 43 ++++++++++++++++++-------------------
> -
>  1 file changed, 20 insertions(+), 23 deletions(-)
> 

You can add my:

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

The only issue I see is in the second patch, who should also have the same
'Fixes' tag.

BTW, while testing I found another issue, I'll send a fix shortly.

Kind regards,
Nicolas