| Message ID | 20190709183209.y64keopah5rkismc@arbad (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level | expand |
Hello Andreas, Am Dienstag, den 09.07.2019, 20:32 +0200 schrieb Andreas Klinger: > mmc cards on mmc1 are not detected because of wrong card detect (cd) > level. > > Change cd from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW. > > This is necessary because of commit e63201f19438 ("mmc: omap_hsmmc: > Delete platform data GPIO CD and WP") Thanks for noticing. But the fix is already in master. Teresa > > Signed-off-by: Andreas Klinger <ak@it-klinger.de> > --- > arch/arm/boot/dts/am335x-wega.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am335x-wega.dtsi > b/arch/arm/boot/dts/am335x-wega.dtsi > index b7d28a20341f..84581fed3d06 100644 > --- a/arch/arm/boot/dts/am335x-wega.dtsi > +++ b/arch/arm/boot/dts/am335x-wega.dtsi > @@ -157,7 +157,7 @@ > bus-width = <4>; > pinctrl-names = "default"; > pinctrl-0 = <&mmc1_pins>; > - cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; > + cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; > status = "okay"; > }; > > -- > 2.11.0 > >
* Andreas Klinger <ak@it-klinger.de> [190709 11:32]: > mmc cards on mmc1 are not detected because of wrong card detect (cd) level. > > Change cd from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW. > > This is necessary because of commit e63201f19438 ("mmc: omap_hsmmc: > Delete platform data GPIO CD and WP") > > Signed-off-by: Andreas Klinger <ak@it-klinger.de> > --- > arch/arm/boot/dts/am335x-wega.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am335x-wega.dtsi b/arch/arm/boot/dts/am335x-wega.dtsi > index b7d28a20341f..84581fed3d06 100644 > --- a/arch/arm/boot/dts/am335x-wega.dtsi > +++ b/arch/arm/boot/dts/am335x-wega.dtsi > @@ -157,7 +157,7 @@ > bus-width = <4>; > pinctrl-names = "default"; > pinctrl-0 = <&mmc1_pins>; > - cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; > + cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; > status = "okay"; > }; > Looks like this already got fixed with an earlier commit 8a0098c05a27 ("ARM: dts: am335x phytec boards: Fix cd-gpios active level"). Regards, Tony
diff --git a/arch/arm/boot/dts/am335x-wega.dtsi b/arch/arm/boot/dts/am335x-wega.dtsi index b7d28a20341f..84581fed3d06 100644 --- a/arch/arm/boot/dts/am335x-wega.dtsi +++ b/arch/arm/boot/dts/am335x-wega.dtsi @@ -157,7 +157,7 @@ bus-width = <4>; pinctrl-names = "default"; pinctrl-0 = <&mmc1_pins>; - cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; + cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; status = "okay"; };
mmc cards on mmc1 are not detected because of wrong card detect (cd) level. Change cd from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW. This is necessary because of commit e63201f19438 ("mmc: omap_hsmmc: Delete platform data GPIO CD and WP") Signed-off-by: Andreas Klinger <ak@it-klinger.de> --- arch/arm/boot/dts/am335x-wega.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)