| Message ID | 1563297318-4900-1-git-send-email-wahrenst@gmx.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dmaengine: bcm2835: Print error in case setting DMA mask fails | expand |
On 16-07-19, 19:15, Stefan Wahren wrote: > During enabling of the RPi 4, we found out that the driver doesn't provide > a helpful error message in case setting DMA mask fails. So add one. Applied, thanks
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index 8101ff2f..970f654 100644 --- a/drivers/dma/bcm2835-dma.c +++ b/drivers/dma/bcm2835-dma.c @@ -871,8 +871,10 @@ static int bcm2835_dma_probe(struct platform_device *pdev) pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask; rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); - if (rc) + if (rc) { + dev_err(&pdev->dev, "Unable to set DMA mask\n"); return rc; + } od = devm_kzalloc(&pdev->dev, sizeof(*od), GFP_KERNEL); if (!od)
During enabling of the RPi 4, we found out that the driver doesn't provide a helpful error message in case setting DMA mask fails. So add one. Signed-off-by: Stefan Wahren <wahrenst@gmx.net> --- drivers/dma/bcm2835-dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.7.4