diff mbox series

[v2,2/2] hwmon/k10temp: Add support for AMD family 17h, model 70h CPUs

Message ID 20190722174653.2391-1-marcel.p.bocu@gmail.com (mailing list archive)
State Accepted
Headers show
Series [v2,1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 70h | expand

Commit Message

Marcel Bocu July 22, 2019, 5:46 p.m. UTC 
It would seem like model 70h is behaving in the same way as model 30h,
so let's just add the new F3 PCI ID to the list of compatible devices.

Unlike previous Ryzen/Threadripper, Ryzen gen 3 processors do not need
temperature offsets anymore. This has been reported in the press and
verified on my Ryzen 3700X by checking that the idle temperature
reported by k10temp is matching the temperature reported by the
firmware.

Vicki Pfau sent an identical patch after I checked that no-one had
written this patch. I would have been happy about dropping my patch but
unlike for his patch series, I had already Cc:ed the x86 people and
they already reviewed the changes. Since Vicki has not answered to
any email after his initial series, let's assume he is on vacation
and let's avoid duplication of reviews from the maintainers and merge
my series. To acknowledge Vicki's anteriority, I added his S-o-b to
the patch.

v2, suggested by Guenter Roeck and Brian Woods:
  - rename from 71h to 70h

Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Marcel Bocu <marcel.p.bocu@gmail.com>
Tested-by: Marcel Bocu <marcel.p.bocu@gmail.com>

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: "Woods, Brian" <Brian.Woods@amd.com>
Cc: Clemens Ladisch <clemens@ladisch.de>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
---
 drivers/hwmon/k10temp.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck July 22, 2019, 6:23 p.m. UTC | #1 
On Mon, Jul 22, 2019 at 08:46:53PM +0300, Marcel Bocu wrote:
> It would seem like model 70h is behaving in the same way as model 30h,
> so let's just add the new F3 PCI ID to the list of compatible devices.
> 
> Unlike previous Ryzen/Threadripper, Ryzen gen 3 processors do not need
> temperature offsets anymore. This has been reported in the press and
> verified on my Ryzen 3700X by checking that the idle temperature
> reported by k10temp is matching the temperature reported by the
> firmware.
> 
> Vicki Pfau sent an identical patch after I checked that no-one had
> written this patch. I would have been happy about dropping my patch but
> unlike for his patch series, I had already Cc:ed the x86 people and
> they already reviewed the changes. Since Vicki has not answered to
> any email after his initial series, let's assume he is on vacation
> and let's avoid duplication of reviews from the maintainers and merge
> my series. To acknowledge Vicki's anteriority, I added his S-o-b to
> the patch.
> 
> v2, suggested by Guenter Roeck and Brian Woods:
>   - rename from 71h to 70h
> 
> Signed-off-by: Vicki Pfau <vi@endrift.com>
> Signed-off-by: Marcel Bocu <marcel.p.bocu@gmail.com>
> Tested-by: Marcel Bocu <marcel.p.bocu@gmail.com>
> 
Applied to hwmon-next.

Note that I made a small change to the description of each patch:

s/ he / she /
s/his/her/

Guenter
Marcel Bocu July 22, 2019, 9:12 p.m. UTC | #2 
On 22/07/2019 21:23, Guenter Roeck wrote:
> On Mon, Jul 22, 2019 at 08:46:53PM +0300, Marcel Bocu wrote:
>> It would seem like model 70h is behaving in the same way as model 30h,
>> so let's just add the new F3 PCI ID to the list of compatible devices.
>>
>> Unlike previous Ryzen/Threadripper, Ryzen gen 3 processors do not need
>> temperature offsets anymore. This has been reported in the press and
>> verified on my Ryzen 3700X by checking that the idle temperature
>> reported by k10temp is matching the temperature reported by the
>> firmware.
>>
>> Vicki Pfau sent an identical patch after I checked that no-one had
>> written this patch. I would have been happy about dropping my patch but
>> unlike for his patch series, I had already Cc:ed the x86 people and
>> they already reviewed the changes. Since Vicki has not answered to
>> any email after his initial series, let's assume he is on vacation
>> and let's avoid duplication of reviews from the maintainers and merge
>> my series. To acknowledge Vicki's anteriority, I added his S-o-b to
>> the patch.
>>
>> v2, suggested by Guenter Roeck and Brian Woods:
>>   - rename from 71h to 70h
>>
>> Signed-off-by: Vicki Pfau <vi@endrift.com>
>> Signed-off-by: Marcel Bocu <marcel.p.bocu@gmail.com>
>> Tested-by: Marcel Bocu <marcel.p.bocu@gmail.com>
>>
> Applied to hwmon-next.
> 
> Note that I made a small change to the description of each patch:
> 
> s/ he / she /
> s/his/her/

Thanks! I'll go find my brown bag and repeat 100 times "don't assume
gender!".

Now, let's see if we can find more sensors to expose :)

Marcel

> 
> Guenter
>
diff mbox series

Patch

diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index c77e89239dcd..5c1dddde193c 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -349,6 +349,7 @@  static const struct pci_device_id k10temp_id_table[] = {
 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_DF_F3) },
 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_M10H_DF_F3) },
 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_M30H_DF_F3) },
+	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_M70H_DF_F3) },
 	{ PCI_VDEVICE(HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
 	{}
 };