| Message ID | 1564048377976.39897@bt.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Invert Endian bit in SPARCv9 MMU TTE | expand |
On 7/25/19 11:52 AM, tony.nguyen@bt.com wrote: > Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> > --- > target/mips/op_helper.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c > index 9e2e02f..dccb8df 100644 > --- a/target/mips/op_helper.c > +++ b/target/mips/op_helper.c > @@ -24,6 +24,7 @@ > #include "exec/helper-proto.h" > #include "exec/exec-all.h" > #include "exec/cpu_ldst.h" > +#include "exec/memop.h" > #include "sysemu/kvm.h" > > /*****************************************************************************/ > @@ -4740,11 +4741,11 @@ void helper_cache(CPUMIPSState *env, target_ulong addr, uint32_t op) > if (op == 9) { > /* Index Store Tag */ > memory_region_dispatch_write(env->itc_tag, index, env->CP0_TagLo, > - 8, MEMTXATTRS_UNSPECIFIED); > + SIZE_MEMOP(8), MEMTXATTRS_UNSPECIFIED); > } else if (op == 5) { > /* Index Load Tag */ > memory_region_dispatch_read(env->itc_tag, index, &env->CP0_TagLo, > - 8, MEMTXATTRS_UNSPECIFIED); > + SIZE_MEMOP(8), MEMTXATTRS_UNSPECIFIED); > } > #endif > } > -- > 1.8.3.1 > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 7/25/19 11:52 AM, tony.nguyen@bt.com wrote: <no description> I think Aleksandar will ask you to describe what the MemOp does, you can add something like: The MEMOP_SIZE() macro will allow us to later easily convert the memory_region_dispatch_ACCESS() functions to ... Meanwhile this macro is a no-op. Thus this patch does not introduce any logical change. And you can reuse this blob in the other patches around. With an improved patch description: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> > --- > target/mips/op_helper.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c > index 9e2e02f..dccb8df 100644 > --- a/target/mips/op_helper.c > +++ b/target/mips/op_helper.c > @@ -24,6 +24,7 @@ > #include "exec/helper-proto.h" > #include "exec/exec-all.h" > #include "exec/cpu_ldst.h" > +#include "exec/memop.h" > #include "sysemu/kvm.h" > > /*****************************************************************************/ > @@ -4740,11 +4741,11 @@ void helper_cache(CPUMIPSState *env, target_ulong addr, uint32_t op) > if (op == 9) { > /* Index Store Tag */ > memory_region_dispatch_write(env->itc_tag, index, env->CP0_TagLo, > - 8, MEMTXATTRS_UNSPECIFIED); > + SIZE_MEMOP(8), MEMTXATTRS_UNSPECIFIED); > } else if (op == 5) { > /* Index Load Tag */ > memory_region_dispatch_read(env->itc_tag, index, &env->CP0_TagLo, > - 8, MEMTXATTRS_UNSPECIFIED); > + SIZE_MEMOP(8), MEMTXATTRS_UNSPECIFIED); > } > #endif > } > -- > 1.8.3.1 > > >
diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index 9e2e02f..dccb8df 100644 --- a/target/mips/op_helper.c +++ b/target/mips/op_helper.c @@ -24,6 +24,7 @@ #include "exec/helper-proto.h" #include "exec/exec-all.h" #include "exec/cpu_ldst.h" +#include "exec/memop.h" #include "sysemu/kvm.h" /*****************************************************************************/ @@ -4740,11 +4741,11 @@ void helper_cache(CPUMIPSState *env, target_ulong addr, uint32_t op) if (op == 9) { /* Index Store Tag */ memory_region_dispatch_write(env->itc_tag, index, env->CP0_TagLo, - 8, MEMTXATTRS_UNSPECIFIED); + SIZE_MEMOP(8), MEMTXATTRS_UNSPECIFIED); } else if (op == 5) { /* Index Load Tag */ memory_region_dispatch_read(env->itc_tag, index, &env->CP0_TagLo, - 8, MEMTXATTRS_UNSPECIFIED); + SIZE_MEMOP(8), MEMTXATTRS_UNSPECIFIED); } #endif }
Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> --- target/mips/op_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 1.8.3.1