| Message ID | cover.1564091601.git.amit.kucheria@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | thermal: qcom: tsens: Add interrupt support | expand |
Hi Amit, On Fri, Jul 26, 2019 at 03:48:35AM +0530, Amit Kucheria wrote: > Add interrupt support to TSENS. The first 6 patches are general fixes and > cleanups to the driver before interrupt support is introduced. > > This series has been developed against qcs404 and sdm845 and then tested on > msm8916. Testing on msm8998 and msm8974 would be appreciated since I don't > have hardware handy. Further, I plan to test on msm8996 and also submit to > kernelci. > > I'm sending this out for more review to get help with testing. I can test this on msm8974 for you using a Nexus 5. Here's what I've done so far: The device tree nodes appear in sysfs: / # ls -1 /sys/class/thermal/ cooling_device0 cooling_device1 thermal_zone0 thermal_zone1 thermal_zone2 thermal_zone3 thermal_zone4 thermal_zone5 thermal_zone6 thermal_zone7 thermal_zone8 thermal_zone9 The various temperatures were in the upper 40s and I threw some work at all four CPU cores to warm up the phone and watched the various temperatures rise: / # for i in $(seq 0 9) ; do > TYPE=$(cat /sys/class/thermal/thermal_zone$i/type) > TEMP=$(cat /sys/class/thermal/thermal_zone$i/temp) > echo "$TYPE = $TEMP" > done cpu-thermal0 = 66000 cpu-thermal1 = 66000 cpu-thermal2 = 66000 cpu-thermal3 = 66000 q6-dsp-thermal = 60000 modemtx-thermal = 57000 video-thermal = 61000 wlan-thermal = 65000 gpu-thermal-top = 61000 gpu-thermal-bottom = 59000 To test the interrupt support, I lowered all of the temperature trips to 51C but I'm not sure where to read that notification. I assume one of the cooling devices or a governor should be started? Sorry but I haven't done any work in the thermal subsystem yet and I'm short on time this morning to investigate right now. Brian
(Resending from a desktop client because mobile gmail apparently sends html that gets rejected by all lists) On Fri, Jul 26, 2019 at 4:06 PM Brian Masney <masneyb@onstation.org> wrote: > > Hi Amit, > > On Fri, Jul 26, 2019 at 03:48:35AM +0530, Amit Kucheria wrote: > > Add interrupt support to TSENS. The first 6 patches are general fixes and > > cleanups to the driver before interrupt support is introduced. > > > > This series has been developed against qcs404 and sdm845 and then tested on > > msm8916. Testing on msm8998 and msm8974 would be appreciated since I don't > > have hardware handy. Further, I plan to test on msm8996 and also submit to > > kernelci. > > > > I'm sending this out for more review to get help with testing. > > I can test this on msm8974 for you using a Nexus 5. Here's what I've > done so far: Thanks. I was hoping that would be the case given all your effort getting Nexus 5 supported. :-) > The device tree nodes appear in sysfs: > > / # ls -1 /sys/class/thermal/ > cooling_device0 > cooling_device1 > thermal_zone0 > thermal_zone1 > thermal_zone2 > thermal_zone3 > thermal_zone4 > thermal_zone5 > thermal_zone6 > thermal_zone7 > thermal_zone8 > thermal_zone9 Looks good. What are the contents of the files inside the two cooling_device directories? The output of the following command would be nice: $ grep "" cooling_device?/* > The various temperatures were in the upper 40s and I threw some work at > all four CPU cores to warm up the phone and watched the various > temperatures rise: > > / # for i in $(seq 0 9) ; do > > TYPE=$(cat /sys/class/thermal/thermal_zone$i/type) > > TEMP=$(cat /sys/class/thermal/thermal_zone$i/temp) > > echo "$TYPE = $TEMP" > > done > cpu-thermal0 = 66000 > cpu-thermal1 = 66000 > cpu-thermal2 = 66000 > cpu-thermal3 = 66000 > q6-dsp-thermal = 60000 > modemtx-thermal = 57000 > video-thermal = 61000 > wlan-thermal = 65000 > gpu-thermal-top = 61000 > gpu-thermal-bottom = 59000 > > To test the interrupt support, I lowered all of the temperature trips to > 51C but I'm not sure where to read that notification. I assume one of > the cooling devices or a governor should be started? Sorry but I haven't > done any work in the thermal subsystem yet and I'm short on time this > morning to investigate right now. For now, just checking if the tsens interrupt in /proc/interrupts fires should be fine. I have another patch to add some information to debugs that I'll send at some point. How well does cpufreq work on 8974? I haven't looked at it yet but we'll need it for thermal throttling. > Brian
Hi Amit, On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > The device tree nodes appear in sysfs: > > > > / # ls -1 /sys/class/thermal/ > > cooling_device0 > > cooling_device1 > > thermal_zone0 > > thermal_zone1 > > thermal_zone2 > > thermal_zone3 > > thermal_zone4 > > thermal_zone5 > > thermal_zone6 > > thermal_zone7 > > thermal_zone8 > > thermal_zone9 > > Looks good. What are the contents of the files inside the two > cooling_device directories? The output of the following command would > be nice: > > $ grep "" cooling_device?/* /sys/class/thermal # grep "" cooling_device?/* cooling_device0/cur_state:100000 cooling_device0/max_state:2500000 cooling_device0/type:smbb-usbin cooling_device1/cur_state:500000 cooling_device1/max_state:2500000 cooling_device1/type:smbb-dcin > > The various temperatures were in the upper 40s and I threw some work at > > all four CPU cores to warm up the phone and watched the various > > temperatures rise: > > > > / # for i in $(seq 0 9) ; do > > > TYPE=$(cat /sys/class/thermal/thermal_zone$i/type) > > > TEMP=$(cat /sys/class/thermal/thermal_zone$i/temp) > > > echo "$TYPE = $TEMP" > > > done > > cpu-thermal0 = 66000 > > cpu-thermal1 = 66000 > > cpu-thermal2 = 66000 > > cpu-thermal3 = 66000 > > q6-dsp-thermal = 60000 > > modemtx-thermal = 57000 > > video-thermal = 61000 > > wlan-thermal = 65000 > > gpu-thermal-top = 61000 > > gpu-thermal-bottom = 59000 > > > > To test the interrupt support, I lowered all of the temperature trips to > > 51C but I'm not sure where to read that notification. I assume one of > > the cooling devices or a governor should be started? Sorry but I haven't > > done any work in the thermal subsystem yet and I'm short on time this > > morning to investigate right now. > > For now, just checking if the tsens interrupt in /proc/interrupts > fires should be fine. I have another patch to add some information to > debugs that I'll send at some point. An interrupt fires as each thermal zone exceeds the trip temperature and an interrupt fires again when it goes below that temperature. Here's my new test script: for i in $(seq 0 9) ; do TYPE=$(cat /sys/class/thermal/thermal_zone$i/type) TEMP=$(cat /sys/class/thermal/thermal_zone$i/temp) TRIP=$(cat /sys/class/thermal/thermal_zone$i/trip_point_0_temp) echo "$TYPE = $TEMP. trip = $TRIP" done # Warm the phone up /sys/class/thermal # /temp.sh cpu-thermal0 = 57000. trip = 51000 cpu-thermal1 = 56000. trip = 51000 cpu-thermal2 = 57000. trip = 51000 cpu-thermal3 = 56000. trip = 51000 q6-dsp-thermal = 51000. trip = 51000 modemtx-thermal = 49000. trip = 51000 video-thermal = 53000. trip = 51000 wlan-thermal = 55000. trip = 51000 gpu-thermal-top = 53000. trip = 51000 gpu-thermal-bottom = 52000. trip = 51000 /sys/class/thermal # grep tsens /proc/interrupts 27: 8 0 0 0 GIC-0 216 Level tsens # Let the phone cool off /sys/class/thermal # /temp.sh cpu-thermal0 = 48000. trip = 51000 cpu-thermal1 = 48000. trip = 51000 cpu-thermal2 = 49000. trip = 51000 cpu-thermal3 = 48000. trip = 51000 q6-dsp-thermal = 47000. trip = 51000 modemtx-thermal = 45000. trip = 51000 video-thermal = 48000. trip = 51000 wlan-thermal = 48000. trip = 51000 gpu-thermal-top = 48000. trip = 51000 gpu-thermal-bottom = 47000. trip = 51000 /sys/class/thermal # grep tsens /proc/interrupts 27: 19 0 0 0 GIC-0 216 Level tsens > How well does cpufreq work on 8974? I haven't looked at it yet but > we'll need it for thermal throttling. I'm not sure how to tell if the frequency is dynamically changed during runtime on arm. x86-64 shows this information in /proc/cpuinfo. Here's the /proc/cpuinfo on the Nexus 5: /sys/class/thermal # cat /proc/cpuinfo processor : 0 model name : ARMv7 Processor rev 0 (v7l) BogoMIPS : 38.40 Features : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32 evtstrm CPU implementer : 0x51 CPU architecture: 7 CPU variant : 0x2 CPU part : 0x06f CPU revision : 0 # 3 more CPUs like 0.... Hardware : Generic DT based system Revision : 0000 Serial : 0000000000000000 Brian
On Fri, Jul 26, 2019 at 4:59 PM Brian Masney <masneyb@onstation.org> wrote: > > Hi Amit, > > On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > > The device tree nodes appear in sysfs: > > > > > > / # ls -1 /sys/class/thermal/ > > > cooling_device0 > > > cooling_device1 > > > thermal_zone0 > > > thermal_zone1 > > > thermal_zone2 > > > thermal_zone3 > > > thermal_zone4 > > > thermal_zone5 > > > thermal_zone6 > > > thermal_zone7 > > > thermal_zone8 > > > thermal_zone9 > > > > Looks good. What are the contents of the files inside the two > > cooling_device directories? The output of the following command would > > be nice: > > > > $ grep "" cooling_device?/* > > /sys/class/thermal # grep "" cooling_device?/* > cooling_device0/cur_state:100000 > cooling_device0/max_state:2500000 > cooling_device0/type:smbb-usbin > cooling_device1/cur_state:500000 > cooling_device1/max_state:2500000 > cooling_device1/type:smbb-dcin > > > > The various temperatures were in the upper 40s and I threw some work at > > > all four CPU cores to warm up the phone and watched the various > > > temperatures rise: > > > > > > / # for i in $(seq 0 9) ; do > > > > TYPE=$(cat /sys/class/thermal/thermal_zone$i/type) > > > > TEMP=$(cat /sys/class/thermal/thermal_zone$i/temp) > > > > echo "$TYPE = $TEMP" > > > > done > > > cpu-thermal0 = 66000 > > > cpu-thermal1 = 66000 > > > cpu-thermal2 = 66000 > > > cpu-thermal3 = 66000 > > > q6-dsp-thermal = 60000 > > > modemtx-thermal = 57000 > > > video-thermal = 61000 > > > wlan-thermal = 65000 > > > gpu-thermal-top = 61000 > > > gpu-thermal-bottom = 59000 > > > > > > To test the interrupt support, I lowered all of the temperature trips to > > > 51C but I'm not sure where to read that notification. I assume one of > > > the cooling devices or a governor should be started? Sorry but I haven't > > > done any work in the thermal subsystem yet and I'm short on time this > > > morning to investigate right now. > > > > For now, just checking if the tsens interrupt in /proc/interrupts > > fires should be fine. I have another patch to add some information to > > debugs that I'll send at some point. > > An interrupt fires as each thermal zone exceeds the trip temperature and > an interrupt fires again when it goes below that temperature. > Here's my new test script: > > for i in $(seq 0 9) ; do > TYPE=$(cat /sys/class/thermal/thermal_zone$i/type) > TEMP=$(cat /sys/class/thermal/thermal_zone$i/temp) > TRIP=$(cat /sys/class/thermal/thermal_zone$i/trip_point_0_temp) > echo "$TYPE = $TEMP. trip = $TRIP" > done > > # Warm the phone up > > /sys/class/thermal # /temp.sh > cpu-thermal0 = 57000. trip = 51000 > cpu-thermal1 = 56000. trip = 51000 > cpu-thermal2 = 57000. trip = 51000 > cpu-thermal3 = 56000. trip = 51000 > q6-dsp-thermal = 51000. trip = 51000 > modemtx-thermal = 49000. trip = 51000 > video-thermal = 53000. trip = 51000 > wlan-thermal = 55000. trip = 51000 > gpu-thermal-top = 53000. trip = 51000 > gpu-thermal-bottom = 52000. trip = 51000 > > /sys/class/thermal # grep tsens /proc/interrupts > 27: 8 0 0 0 GIC-0 216 Level tsens > > # Let the phone cool off > > /sys/class/thermal # /temp.sh > cpu-thermal0 = 48000. trip = 51000 > cpu-thermal1 = 48000. trip = 51000 > cpu-thermal2 = 49000. trip = 51000 > cpu-thermal3 = 48000. trip = 51000 > q6-dsp-thermal = 47000. trip = 51000 > modemtx-thermal = 45000. trip = 51000 > video-thermal = 48000. trip = 51000 > wlan-thermal = 48000. trip = 51000 > gpu-thermal-top = 48000. trip = 51000 > gpu-thermal-bottom = 47000. trip = 51000 > > /sys/class/thermal # grep tsens /proc/interrupts > 27: 19 0 0 0 GIC-0 216 Level tsens OK, seems reasonable. I'll finish up a debugfs patch that'll dump more state transition information to give more insight. > > How well does cpufreq work on 8974? I haven't looked at it yet but > > we'll need it for thermal throttling. > > I'm not sure how to tell if the frequency is dynamically changed during > runtime on arm. x86-64 shows this information in /proc/cpuinfo. Here's > the /proc/cpuinfo on the Nexus 5: Nah. /proc/cpuinfo won't show what we need. Try the following: $ grep "" /sys/devices/system/cpu/cpufreq/policy?/* More specifically, the following files have the information you need. Run watch -n1 on them. $ grep "" /sys/devices/system/cpu/cpufreq/policy?/scaling_*_freq Thanks for your help. Regards, Amit
On Sat, Jul 27, 2019 at 12:58:54PM +0530, Amit Kucheria wrote: > On Fri, Jul 26, 2019 at 4:59 PM Brian Masney <masneyb@onstation.org> wrote: > > On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > > How well does cpufreq work on 8974? I haven't looked at it yet but > > > we'll need it for thermal throttling. > > > > I'm not sure how to tell if the frequency is dynamically changed during > > runtime on arm. x86-64 shows this information in /proc/cpuinfo. Here's > > the /proc/cpuinfo on the Nexus 5: > > Nah. /proc/cpuinfo won't show what we need. > > Try the following: > > $ grep "" /sys/devices/system/cpu/cpufreq/policy?/* > > More specifically, the following files have the information you need. > Run watch -n1 on them. > > $ grep "" /sys/devices/system/cpu/cpufreq/policy?/scaling_*_freq There's no cpufreq directory on msm8974: # ls -1 /sys/devices/system/cpu/ cpu0 cpu1 cpu2 cpu3 cpuidle hotplug isolated kernel_max modalias offline online possible power present smt uevent I'm using qcom_defconfig. Brian
On Montag, 29. Juli 2019 11:07:35 CEST Brian Masney wrote: > On Sat, Jul 27, 2019 at 12:58:54PM +0530, Amit Kucheria wrote: > > On Fri, Jul 26, 2019 at 4:59 PM Brian Masney <masneyb@onstation.org> wrote: > > > On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > > > How well does cpufreq work on 8974? I haven't looked at it yet but > > > > we'll need it for thermal throttling. > > > > > > I'm not sure how to tell if the frequency is dynamically changed during > > > runtime on arm. x86-64 shows this information in /proc/cpuinfo. Here's > > > > > the /proc/cpuinfo on the Nexus 5: > > Nah. /proc/cpuinfo won't show what we need. > > > > Try the following: > > > > $ grep "" /sys/devices/system/cpu/cpufreq/policy?/* > > > > More specifically, the following files have the information you need. > > Run watch -n1 on them. > > > > $ grep "" /sys/devices/system/cpu/cpufreq/policy?/scaling_*_freq > > There's no cpufreq directory on msm8974: > > # ls -1 /sys/devices/system/cpu/ > cpu0 > cpu1 > cpu2 > cpu3 > cpuidle > hotplug > isolated > kernel_max > modalias > offline > online > possible > power > present > smt > uevent > > I'm using qcom_defconfig. > > Brian Hi Brian, cpufreq isn't supported on msm8974 yet. I have these patches [0] in my tree but I'm not sure they work correctly, but I haven't tested much with them. Feel free to try them on hammerhead. Luca [0] https://github.com/z3ntu/linux/compare/b0917f53ada0e929896a094b451219cd8091366e...6459ca6aff498c9d12acd35709b4903effc4c3f8
On Mon, Jul 29, 2019 at 3:03 PM Luca Weiss <luca@z3ntu.xyz> wrote: > > On Montag, 29. Juli 2019 11:07:35 CEST Brian Masney wrote: > > On Sat, Jul 27, 2019 at 12:58:54PM +0530, Amit Kucheria wrote: > > > On Fri, Jul 26, 2019 at 4:59 PM Brian Masney <masneyb@onstation.org> wrote: > > > > On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > > > > How well does cpufreq work on 8974? I haven't looked at it yet but > > > > > we'll need it for thermal throttling. > > > > > > > > I'm not sure how to tell if the frequency is dynamically changed during > > > > runtime on arm. x86-64 shows this information in /proc/cpuinfo. Here's > > > > > > > the /proc/cpuinfo on the Nexus 5: > > > Nah. /proc/cpuinfo won't show what we need. > > > > > > Try the following: > > > > > > $ grep "" /sys/devices/system/cpu/cpufreq/policy?/* > > > > > > More specifically, the following files have the information you need. > > > Run watch -n1 on them. > > > > > > $ grep "" /sys/devices/system/cpu/cpufreq/policy?/scaling_*_freq > > > > There's no cpufreq directory on msm8974: > > > > # ls -1 /sys/devices/system/cpu/ > > cpu0 > > cpu1 > > cpu2 > > cpu3 > > cpuidle > > hotplug > > isolated > > kernel_max > > modalias > > offline > > online > > possible > > power > > present > > smt > > uevent > > > > I'm using qcom_defconfig. > > > > Brian > > Hi Brian, > cpufreq isn't supported on msm8974 yet. > I have these patches [0] in my tree but I'm not sure they work correctly, but I haven't tested much with them. Feel free to try them on hammerhead. > > Luca > > [0] https://github.com/z3ntu/linux/compare/b0917f53ada0e929896a094b451219cd8091366e...6459ca6aff498c9d12acd35709b4903effc4c3f8 Niklas is working on refactoring some of the Krait code[1]. I'm not sure if he looked at 8974 directly as part of the refactor adding him here to get a better sense of the state of cpufreq on 8974. [1] https://lore.kernel.org/linux-arm-msm/20190726080823.xwhxagv5iuhudmic@vireshk-i7/T/#t
On Fri, Jul 26, 2019 at 3:48 AM Amit Kucheria <amit.kucheria@linaro.org> wrote: > > Add interrupt support to TSENS. The first 6 patches are general fixes and > cleanups to the driver before interrupt support is introduced. > > This series has been developed against qcs404 and sdm845 and then tested on > msm8916. Testing on msm8998 and msm8974 would be appreciated since I don't > have hardware handy. Further, I plan to test on msm8996 and also submit to > kernelci. Gentle nudge for reviews. This has now been successfully tested on 8974 (along with 8916, qcs404, sdm845). Testing on msm8998 would be much appreciated. > I'm sending this out for more review to get help with testing. > > Amit Kucheria (15): > drivers: thermal: tsens: Get rid of id field in tsens_sensor > drivers: thermal: tsens: Simplify code flow in tsens_probe > drivers: thermal: tsens: Add __func__ identifier to debug statements > drivers: thermal: tsens: Add debugfs support > arm: dts: msm8974: thermal: Add thermal zones for each sensor > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > dt: thermal: tsens: Document interrupt support in tsens driver > arm64: dts: sdm845: thermal: Add interrupt support > arm64: dts: msm8996: thermal: Add interrupt support > arm64: dts: msm8998: thermal: Add interrupt support > arm64: dts: qcs404: thermal: Add interrupt support > arm64: dts: msm8974: thermal: Add interrupt support > arm64: dts: msm8916: thermal: Add interrupt support > drivers: thermal: tsens: Create function to return sign-extended > temperature > drivers: thermal: tsens: Add interrupt support > > .../bindings/thermal/qcom-tsens.txt | 5 + > arch/arm/boot/dts/qcom-msm8974.dtsi | 108 +++- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 26 +- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 +- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 82 +-- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 42 +- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 +-- > drivers/thermal/qcom/tsens-8960.c | 4 +- > drivers/thermal/qcom/tsens-common.c | 610 +++++++++++++++++- > drivers/thermal/qcom/tsens-v0_1.c | 11 + > drivers/thermal/qcom/tsens-v1.c | 29 + > drivers/thermal/qcom/tsens-v2.c | 18 + > drivers/thermal/qcom/tsens.c | 52 +- > drivers/thermal/qcom/tsens.h | 285 +++++++- > 14 files changed, 1214 insertions(+), 206 deletions(-) > > -- > 2.17.1 >
On Mon, Jul 29, 2019 at 03:20:11PM +0530, Amit Kucheria wrote: > On Mon, Jul 29, 2019 at 3:03 PM Luca Weiss <luca@z3ntu.xyz> wrote: > > > > On Montag, 29. Juli 2019 11:07:35 CEST Brian Masney wrote: > > > On Sat, Jul 27, 2019 at 12:58:54PM +0530, Amit Kucheria wrote: > > > > On Fri, Jul 26, 2019 at 4:59 PM Brian Masney <masneyb@onstation.org> wrote: > > > > > On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > > > > > How well does cpufreq work on 8974? I haven't looked at it yet but > > > > > > we'll need it for thermal throttling. > > > > > > > > > > I'm not sure how to tell if the frequency is dynamically changed during > > > > > runtime on arm. x86-64 shows this information in /proc/cpuinfo. Here's > > > > > > > > > the /proc/cpuinfo on the Nexus 5: > > > > Nah. /proc/cpuinfo won't show what we need. > > > > > > > > Try the following: > > > > > > > > $ grep "" /sys/devices/system/cpu/cpufreq/policy?/* > > > > > > > > More specifically, the following files have the information you need. > > > > Run watch -n1 on them. > > > > > > > > $ grep "" /sys/devices/system/cpu/cpufreq/policy?/scaling_*_freq > > > > > > There's no cpufreq directory on msm8974: > > > > > > # ls -1 /sys/devices/system/cpu/ > > > cpu0 > > > cpu1 > > > cpu2 > > > cpu3 > > > cpuidle > > > hotplug > > > isolated > > > kernel_max > > > modalias > > > offline > > > online > > > possible > > > power > > > present > > > smt > > > uevent > > > > > > I'm using qcom_defconfig. > > > > > > Brian > > > > Hi Brian, > > cpufreq isn't supported on msm8974 yet. > > I have these patches [0] in my tree but I'm not sure they work correctly, but I haven't tested much with them. Feel free to try them on hammerhead. > > > > Luca > > > > [0] https://github.com/z3ntu/linux/compare/b0917f53ada0e929896a094b451219cd8091366e...6459ca6aff498c9d12acd35709b4903effc4c3f8 > > Niklas is working on refactoring some of the Krait code[1]. I'm not > sure if he looked at 8974 directly as part of the refactor adding him > here to get a better sense of the state of cpufreq on 8974. Hello, I took and cleaned up Sricharans commit "cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs" from his Krait cpufreq series. The commit renames and refactors the Kryo cpufreq driver. This commit is now in linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/commit/?h=cpufreq/arm/linux-next&id=106b976debd36b0e61847769f8edd71bfea56ed7 I also added Qualcomm A53 support to this driver. However, Krait CPUs are different from both Kryo and Qualcomm A53, so you will need to take Sricharans patch series and rebase it on top of linux-next. Kind regards, Niklas > > [1] https://lore.kernel.org/linux-arm-msm/20190726080823.xwhxagv5iuhudmic@vireshk-i7/T/#t
Add interrupt support to TSENS. The first 6 patches are general fixes and cleanups to the driver before interrupt support is introduced. This series has been developed against qcs404 and sdm845 and then tested on msm8916. Testing on msm8998 and msm8974 would be appreciated since I don't have hardware handy. Further, I plan to test on msm8996 and also submit to kernelci. I'm sending this out for more review to get help with testing. Amit Kucheria (15): drivers: thermal: tsens: Get rid of id field in tsens_sensor drivers: thermal: tsens: Simplify code flow in tsens_probe drivers: thermal: tsens: Add __func__ identifier to debug statements drivers: thermal: tsens: Add debugfs support arm: dts: msm8974: thermal: Add thermal zones for each sensor arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors dt: thermal: tsens: Document interrupt support in tsens driver arm64: dts: sdm845: thermal: Add interrupt support arm64: dts: msm8996: thermal: Add interrupt support arm64: dts: msm8998: thermal: Add interrupt support arm64: dts: qcs404: thermal: Add interrupt support arm64: dts: msm8974: thermal: Add interrupt support arm64: dts: msm8916: thermal: Add interrupt support drivers: thermal: tsens: Create function to return sign-extended temperature drivers: thermal: tsens: Add interrupt support .../bindings/thermal/qcom-tsens.txt | 5 + arch/arm/boot/dts/qcom-msm8974.dtsi | 108 +++- arch/arm64/boot/dts/qcom/msm8916.dtsi | 26 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 +- arch/arm64/boot/dts/qcom/msm8998.dtsi | 82 +-- arch/arm64/boot/dts/qcom/qcs404.dtsi | 42 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 +-- drivers/thermal/qcom/tsens-8960.c | 4 +- drivers/thermal/qcom/tsens-common.c | 610 +++++++++++++++++- drivers/thermal/qcom/tsens-v0_1.c | 11 + drivers/thermal/qcom/tsens-v1.c | 29 + drivers/thermal/qcom/tsens-v2.c | 18 + drivers/thermal/qcom/tsens.c | 52 +- drivers/thermal/qcom/tsens.h | 285 +++++++- 14 files changed, 1214 insertions(+), 206 deletions(-)