| Message ID | 20190729143007.GA8067@embeddedor (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | c78a66584d0318e2a01a3f10857c9b517d23bf7a |
| Headers | show |
| Series | scsi: sun3_scsi: Mark expected switch fall-throughs | expand |
Hi Gustavo, On Mon, Jul 29, 2019 at 4:32 PM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/scsi/sun3_scsi.c: warning: this statement may fall through > [-Wimplicit-fallthrough=]: => 399:9, 403:9 > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Thanks! Tested-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- a/drivers/scsi/sun3_scsi.c > +++ b/drivers/scsi/sun3_scsi.c > @@ -397,10 +397,12 @@ static int sun3scsi_dma_finish(int write_flag) > case CSR_LEFT_3: > *vaddr = (dregs->bpack_lo & 0xff00) >> 8; > vaddr--; > + /* Fall through */ > > case CSR_LEFT_2: > *vaddr = (dregs->bpack_hi & 0x00ff); > vaddr--; > + /* Fall through */ > I think it would be clearer if you would drop the blank lines. > case CSR_LEFT_1: > *vaddr = (dregs->bpack_hi & 0xff00) >> 8; Gr{oetje,eeting}s, Geert
Gustavo, > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/scsi/sun3_scsi.c: warning: this statement may fall through > [-Wimplicit-fallthrough=]: => 399:9, 403:9 Applied to 5.4/scsi-queue, thanks!
diff --git a/drivers/scsi/sun3_scsi.c b/drivers/scsi/sun3_scsi.c index 3d80ab67a626..955e4c938d49 100644 --- a/drivers/scsi/sun3_scsi.c +++ b/drivers/scsi/sun3_scsi.c @@ -397,10 +397,12 @@ static int sun3scsi_dma_finish(int write_flag) case CSR_LEFT_3: *vaddr = (dregs->bpack_lo & 0xff00) >> 8; vaddr--; + /* Fall through */ case CSR_LEFT_2: *vaddr = (dregs->bpack_hi & 0x00ff); vaddr--; + /* Fall through */ case CSR_LEFT_1: *vaddr = (dregs->bpack_hi & 0xff00) >> 8;
Mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/scsi/sun3_scsi.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 399:9, 403:9 Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/scsi/sun3_scsi.c | 2 ++ 1 file changed, 2 insertions(+)