| Message ID | 20190729141349.28465-1-sebastien.szymanski@armadeus.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] drm: mxsfb: add i.MX6UL in Kconfig | expand |
Hi Sébastien, On Mon, Jul 29, 2019 at 11:14 AM Sébastien Szymanski <sebastien.szymanski@armadeus.com> wrote: > config DRM_MXSFB > - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller" > + tristate "i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB LCD controller" This IP is also found on i.MX6SL, i.MX7D, i.MX7S, i.MX8M, i.MX8QXP, etc I think it would be better if we do not keep increasing the list of supported SoCs in the Kconfig text. What about just having the text like this instead? tristate "MXSFB LCD controller" > depends on DRM && OF > depends on COMMON_CLK > select DRM_MXS > @@ -14,7 +14,7 @@ config DRM_MXSFB > select DRM_KMS_CMA_HELPER > select DRM_PANEL > help > - Choose this option if you have an i.MX23/i.MX28/i.MX6SX MXSFB > + Choose this option if you have an i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB > LCD controller. and here it would become: Choose this option if you want to support the MXSFB LCD controller.
Hi Sébastien, On Mon, Jul 29, 2019 at 11:27:37AM -0300, Fabio Estevam wrote: > Hi Sébastien, > > On Mon, Jul 29, 2019 at 11:14 AM Sébastien Szymanski > <sebastien.szymanski@armadeus.com> wrote: > > > config DRM_MXSFB > > - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller" > > + tristate "i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB LCD controller" > > This IP is also found on i.MX6SL, i.MX7D, i.MX7S, i.MX8M, i.MX8QXP, etc > > I think it would be better if we do not keep increasing the list of > supported SoCs in the Kconfig text. Could we throw a COMPILE_TEST in the mix so we get better build coverage too? Sam
Hi Sam, On Mon, Jul 29, 2019 at 11:37 AM Sam Ravnborg <sam@ravnborg.org> wrote: > Could we throw a COMPILE_TEST in the mix so we get better build > coverage too? There is no architecture dependency to build this driver, so we already have build coverage for it. Regards, Fabio Estevam
Hi Fabio. On Mon, Jul 29, 2019 at 12:51:08PM -0300, Fabio Estevam wrote: > Hi Sam, > > On Mon, Jul 29, 2019 at 11:37 AM Sam Ravnborg <sam@ravnborg.org> wrote: > > > Could we throw a COMPILE_TEST in the mix so we get better build > > coverage too? > > There is no architecture dependency to build this driver, so we > already have build coverage for it. Super, thanks for the info. Sam
diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig index 0dca8f27169e..4571d4990e6f 100644 --- a/drivers/gpu/drm/mxsfb/Kconfig +++ b/drivers/gpu/drm/mxsfb/Kconfig @@ -5,7 +5,7 @@ config DRM_MXS Choose this option to select drivers for MXS FB devices config DRM_MXSFB - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller" + tristate "i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB LCD controller" depends on DRM && OF depends on COMMON_CLK select DRM_MXS @@ -14,7 +14,7 @@ config DRM_MXSFB select DRM_KMS_CMA_HELPER select DRM_PANEL help - Choose this option if you have an i.MX23/i.MX28/i.MX6SX MXSFB + Choose this option if you have an i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB LCD controller. If M is selected the module will be called mxsfb.
This controller is also found on i.MX6UL and i.MX6ULL so update Kconfig accordingly. Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com> --- drivers/gpu/drm/mxsfb/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)