| Message ID | 20190731195713.3150463-4-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: move lpc32xx and dove to multiplatform | expand |
On Wed, Jul 31, 2019 at 09:56:45PM +0200, Arnd Bergmann wrote: > The only thing that prevents building this driver on other > platforms is the mach/hardware.h include, which is not actually > used here at all, so remove the line and allow CONFIG_COMPILE_TEST. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Guenter Roeck <linux@roeck-us.net> What is the plan for this patch ? Push through watchdog or through your branch ? Thanks, Guenter
On Wed, Jul 31, 2019 at 10:23 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On Wed, Jul 31, 2019 at 09:56:45PM +0200, Arnd Bergmann wrote: > > The only thing that prevents building this driver on other > > platforms is the mach/hardware.h include, which is not actually > > used here at all, so remove the line and allow CONFIG_COMPILE_TEST. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > What is the plan for this patch ? Push through watchdog > or through your branch ? I would prefer my branch so I can apply the final patch without waiting for another release. Not in a hurry though, so if some other maintainer wants to take the respective driver patch through their tree instead of the arm-soc one, I'll just wait anyway. Arnd
On Wed, Jul 31, 2019 at 10:26:35PM +0200, Arnd Bergmann wrote: > On Wed, Jul 31, 2019 at 10:23 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > On Wed, Jul 31, 2019 at 09:56:45PM +0200, Arnd Bergmann wrote: > > > The only thing that prevents building this driver on other > > > platforms is the mach/hardware.h include, which is not actually > > > used here at all, so remove the line and allow CONFIG_COMPILE_TEST. > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > > > What is the plan for this patch ? Push through watchdog > > or through your branch ? > > I would prefer my branch so I can apply the final patch without waiting > for another release. Not in a hurry though, so if some other maintainer Ok with me. Guenter
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com> On Wed, Jul 31, 2019 at 4:36 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On Wed, Jul 31, 2019 at 10:26:35PM +0200, Arnd Bergmann wrote: > > On Wed, Jul 31, 2019 at 10:23 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > On Wed, Jul 31, 2019 at 09:56:45PM +0200, Arnd Bergmann wrote: > > > > The only thing that prevents building this driver on other > > > > platforms is the mach/hardware.h include, which is not actually > > > > used here at all, so remove the line and allow CONFIG_COMPILE_TEST. > > > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > > > > > What is the plan for this patch ? Push through watchdog > > > or through your branch ? > > > > I would prefer my branch so I can apply the final patch without waiting > > for another release. Not in a hurry though, so if some other maintainer > > Ok with me. > > Guenter
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 8188963a405b..a45f9e3e442b 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -551,7 +551,7 @@ config OMAP_WATCHDOG config PNX4008_WATCHDOG tristate "LPC32XX Watchdog" - depends on ARCH_LPC32XX + depends on ARCH_LPC32XX || COMPILE_TEST select WATCHDOG_CORE help Say Y here if to include support for the watchdog timer diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c index 7b446b696f2b..e0ea133c1690 100644 --- a/drivers/watchdog/pnx4008_wdt.c +++ b/drivers/watchdog/pnx4008_wdt.c @@ -30,7 +30,6 @@ #include <linux/of.h> #include <linux/delay.h> #include <linux/reboot.h> -#include <mach/hardware.h> /* WatchDog Timer - Chapter 23 Page 207 */
The only thing that prevents building this driver on other platforms is the mach/hardware.h include, which is not actually used here at all, so remove the line and allow CONFIG_COMPILE_TEST. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/watchdog/Kconfig | 2 +- drivers/watchdog/pnx4008_wdt.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)