| Message ID | 20190731073748.17664-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b2567ebb78bdde9a49010957a0ea5a2514f3fed2 |
| Headers | show |
| Series | [-next] RDMA/hns: remove set but not used variable 'irq_num' | expand |
On Wed, Jul 31, 2019 at 03:37:48PM +0800, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function hns_roce_v2_cleanup_eq_table: > drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5920:6: > warning: variable irq_num set but not used [-Wunused-but-set-variable] > > It is not used since > commit 33db6f94847c ("RDMA/hns: Refactor eq table init for hip08") > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 -- > 1 file changed, 2 deletions(-) > I'm hitting this error too. Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
On Thu, 2019-08-01 at 13:10 +0300, Leon Romanovsky wrote: > On Wed, Jul 31, 2019 at 03:37:48PM +0800, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function > > hns_roce_v2_cleanup_eq_table: > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5920:6: > > warning: variable irq_num set but not used [-Wunused-but-set- > > variable] > > > > It is not used since > > commit 33db6f94847c ("RDMA/hns: Refactor eq table init for hip08") > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > --- > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > I'm hitting this error too. > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@mellanox.com> Applied to for-next, thanks.
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index 83c58be..59f88bf0 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -5917,12 +5917,10 @@ static int hns_roce_v2_init_eq_table(struct hns_roce_dev *hr_dev) static void hns_roce_v2_cleanup_eq_table(struct hns_roce_dev *hr_dev) { struct hns_roce_eq_table *eq_table = &hr_dev->eq_table; - int irq_num; int eq_num; int i; eq_num = hr_dev->caps.num_comp_vectors + hr_dev->caps.num_aeq_vectors; - irq_num = eq_num + hr_dev->caps.num_other_vectors; /* Disable irq */ hns_roce_v2_int_mask_enable(hr_dev, eq_num, EQ_DISABLE);
Fixes gcc '-Wunused-but-set-variable' warning: drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function hns_roce_v2_cleanup_eq_table: drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5920:6: warning: variable irq_num set but not used [-Wunused-but-set-variable] It is not used since commit 33db6f94847c ("RDMA/hns: Refactor eq table init for hip08") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 -- 1 file changed, 2 deletions(-)