| Message ID | 20190712070026.13088-7-ramalingam.c@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | HDCP2.2 Phase II | expand |
Hi Ram, Just a minor nitpick. Regards Shashank > -----Original Message----- > From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of > Ramalingam C > Sent: Friday, July 12, 2019 12:30 PM > To: intel-gfx <intel-gfx@lists.freedesktop.org>; dri-devel <dri- > devel@lists.freedesktop.org>; Pekka Paalanen <ppaalanen@gmail.com>; Daniel > Vetter <daniel@ffwll.ch> > Subject: [PATCH v10 6/6] drm/hdcp: reference for srm file format > > In the kernel documentation, HDCP specifications links are shared as a reference for > SRM table format. > > Signed-off-by: Ramalingam C <ramalingam.c@intel.com> > --- > drivers/gpu/drm/drm_hdcp.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/drm_hdcp.c b/drivers/gpu/drm/drm_hdcp.c index > 77433ee3d652..803bf8283b83 100644 > --- a/drivers/gpu/drm/drm_hdcp.c > +++ b/drivers/gpu/drm/drm_hdcp.c > @@ -271,6 +271,13 @@ static void drm_hdcp_request_srm(struct drm_device > *drm_dev) > * > * SRM should be presented in the name of "display_hdcp_srm.bin". > * > + * Format of the SRM table that userspace needs to write into the > + binary file > + * is defined at I would just prefer addition of 2 ',' and a ':', something like: Format of the SRM table, that the userspace needs to write into the binary file, is defined at: With this change, please feel free to use: Reviewed-by: Shashank Sharma <shashank.sharma@intel.com> > + * 1. Renewability chapter on 55th page of HDCP 1.4 specification > + * > + https://www.digital-cp.com/sites/default/files/specifications/HDCP%20S > + pecification%20Rev1_4_Secure.pdf > + * 2. Renewability chapter on 63rd page of HDCP 2.2 specification > + * > + https://www.digital-cp.com/sites/default/files/specifications/HDCP%20o > + n%20HDMI%20Specification%20Rev2_2_Final1.pdf > + * > * Returns: > * TRUE on any of the KSV is revoked, else FALSE. > */ > -- > 2.19.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 2019-08-01 at 16:06:37 +0530, Sharma, Shashank wrote: > Hi Ram, > Just a minor nitpick. > > Regards > Shashank > > -----Original Message----- > > From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of > > Ramalingam C > > Sent: Friday, July 12, 2019 12:30 PM > > To: intel-gfx <intel-gfx@lists.freedesktop.org>; dri-devel <dri- > > devel@lists.freedesktop.org>; Pekka Paalanen <ppaalanen@gmail.com>; Daniel > > Vetter <daniel@ffwll.ch> > > Subject: [PATCH v10 6/6] drm/hdcp: reference for srm file format > > > > In the kernel documentation, HDCP specifications links are shared as a reference for > > SRM table format. > > > > Signed-off-by: Ramalingam C <ramalingam.c@intel.com> > > --- > > drivers/gpu/drm/drm_hdcp.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_hdcp.c b/drivers/gpu/drm/drm_hdcp.c index > > 77433ee3d652..803bf8283b83 100644 > > --- a/drivers/gpu/drm/drm_hdcp.c > > +++ b/drivers/gpu/drm/drm_hdcp.c > > @@ -271,6 +271,13 @@ static void drm_hdcp_request_srm(struct drm_device > > *drm_dev) > > * > > * SRM should be presented in the name of "display_hdcp_srm.bin". > > * > > + * Format of the SRM table that userspace needs to write into the > > + binary file > > + * is defined at > I would just prefer addition of 2 ',' and a ':', something like: > Format of the SRM table, that the userspace needs to write into the binary file, is defined at: > > With this change, please feel free to use: > Reviewed-by: Shashank Sharma <shashank.sharma@intel.com> Thanks Shashank. -Ram > > > + * 1. Renewability chapter on 55th page of HDCP 1.4 specification > > + * > > + https://www.digital-cp.com/sites/default/files/specifications/HDCP%20S > > + pecification%20Rev1_4_Secure.pdf > > + * 2. Renewability chapter on 63rd page of HDCP 2.2 specification > > + * > > + https://www.digital-cp.com/sites/default/files/specifications/HDCP%20o > > + n%20HDMI%20Specification%20Rev2_2_Final1.pdf > > + * > > * Returns: > > * TRUE on any of the KSV is revoked, else FALSE. > > */ > > -- > > 2.19.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_hdcp.c b/drivers/gpu/drm/drm_hdcp.c index 77433ee3d652..803bf8283b83 100644 --- a/drivers/gpu/drm/drm_hdcp.c +++ b/drivers/gpu/drm/drm_hdcp.c @@ -271,6 +271,13 @@ static void drm_hdcp_request_srm(struct drm_device *drm_dev) * * SRM should be presented in the name of "display_hdcp_srm.bin". * + * Format of the SRM table that userspace needs to write into the binary file + * is defined at + * 1. Renewability chapter on 55th page of HDCP 1.4 specification + * https://www.digital-cp.com/sites/default/files/specifications/HDCP%20Specification%20Rev1_4_Secure.pdf + * 2. Renewability chapter on 63rd page of HDCP 2.2 specification + * https://www.digital-cp.com/sites/default/files/specifications/HDCP%20on%20HDMI%20Specification%20Rev2_2_Final1.pdf + * * Returns: * TRUE on any of the KSV is revoked, else FALSE. */
In the kernel documentation, HDCP specifications links are shared as a reference for SRM table format. Signed-off-by: Ramalingam C <ramalingam.c@intel.com> --- drivers/gpu/drm/drm_hdcp.c | 7 +++++++ 1 file changed, 7 insertions(+)