| Message ID | f14db3287b23ed8af9bdbf8001e2e2fe7ae9e43a.camel@perches.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 31d0e6c149b8c9a9bddc6d68f8600918bb771cb9 |
| Headers | show |
| Series | [V2] mlx5: Fix formats with line continuation whitespace | expand |
On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote: > The line continuations unintentionally add whitespace so > instead use coalesced formats to remove the whitespace. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > > v2: Remove excess space after %u > > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote: > On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote: > > The line continuations unintentionally add whitespace so > > instead use coalesced formats to remove the whitespace. > > > > Signed-off-by: Joe Perches <joe@perches.com> > > --- > > > > v2: Remove excess space after %u > > > > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@mellanox.com> Applied, thanks.
On Tue, 2018-11-06 at 16:34 -0500, Doug Ledford wrote: > On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote: > > On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote: > > > The line continuations unintentionally add whitespace so > > > instead use coalesced formats to remove the whitespace. > > > > > > Signed-off-by: Joe Perches <joe@perches.com> > > > --- > > > > > > v2: Remove excess space after %u > > > > > > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++---- > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > > Thanks, > > Reviewed-by: Leon Romanovsky <leonro@mellanox.com> > > Applied, thanks. Still not upstream. How long does it take?
On Fri, 2019-08-02 at 11:09 -0700, Joe Perches wrote: > On Tue, 2018-11-06 at 16:34 -0500, Doug Ledford wrote: > > On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote: > > > On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote: > > > > The line continuations unintentionally add whitespace so > > > > instead use coalesced formats to remove the whitespace. > > > > > > > > Signed-off-by: Joe Perches <joe@perches.com> > > > > --- > > > > > > > > v2: Remove excess space after %u > > > > > > > > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++---- > > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > > > > > Thanks, > > > Reviewed-by: Leon Romanovsky <leonro@mellanox.com> > > > > Applied, thanks. > > Still not upstream. How long does it take? > Doug, Leon, this patch still apply, let me know what happened here ? and if you want me to apply it to one of my branches. Thanks, Saeed.
On Fri, 2019-08-02 at 18:32 +0000, Saeed Mahameed wrote: > On Fri, 2019-08-02 at 11:09 -0700, Joe Perches wrote: > > On Tue, 2018-11-06 at 16:34 -0500, Doug Ledford wrote: > > > On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote: > > > > On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote: > > > > > The line continuations unintentionally add whitespace so > > > > > instead use coalesced formats to remove the whitespace. > > > > > > > > > > Signed-off-by: Joe Perches <joe@perches.com> > > > > > --- > > > > > > > > > > v2: Remove excess space after %u > > > > > > > > > > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++---- > > > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > > > > > > > > Thanks, > > > > Reviewed-by: Leon Romanovsky <leonro@mellanox.com> > > > > > > Applied, thanks. > > > > Still not upstream. How long does it take? > > > > Doug, Leon, this patch still apply, let me know what happened here ? > and if you want me to apply it to one of my branches. I'm not entirely sure what happened here. Obviously I said I had taken it, which I don't do under my normal workflow until I've actually applied and build tested the patch. For it to not make it into the tree means that I probably applied it to my wip/dl-for-next branch, but prior to moving it to for-next, I might have had a rebase and it got lost in the shuffle or something like that. My apologies for letting it slip through the cracks. Anyway, I pulled the patch from patchworks, applied it, and pushed it to k.o.
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/rl.c b/drivers/net/ethernet/mellanox/mlx5/core/rl.c index bc86dffdc43c..377b7e65ecf1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/rl.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/rl.c @@ -188,8 +188,7 @@ int mlx5_rl_add_rate(struct mlx5_core_dev *dev, u16 *index, /* new rate limit */ err = mlx5_set_pp_rate_limit_cmd(dev, entry->index, rl); if (err) { - mlx5_core_err(dev, "Failed configuring rate limit(err %d): \ - rate %u, max_burst_sz %u, typical_pkt_sz %u\n", + mlx5_core_err(dev, "Failed configuring rate limit(err %d): rate %u, max_burst_sz %u, typical_pkt_sz %u\n", err, rl->rate, rl->max_burst_sz, rl->typical_pkt_sz); goto out; @@ -218,8 +217,7 @@ void mlx5_rl_remove_rate(struct mlx5_core_dev *dev, struct mlx5_rate_limit *rl) mutex_lock(&table->rl_lock); entry = find_rl_entry(table, rl); if (!entry || !entry->refcount) { - mlx5_core_warn(dev, "Rate %u, max_burst_sz %u typical_pkt_sz %u \ - are not configured\n", + mlx5_core_warn(dev, "Rate %u, max_burst_sz %u typical_pkt_sz %u are not configured\n", rl->rate, rl->max_burst_sz, rl->typical_pkt_sz); goto out; }
The line continuations unintentionally add whitespace so instead use coalesced formats to remove the whitespace. Signed-off-by: Joe Perches <joe@perches.com> --- v2: Remove excess space after %u drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)